Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracing: update semconv to v1.23.1 #37884

Merged
merged 12 commits into from
Jan 12, 2024
Merged

Tracing: update semconv to v1.23.1 #37884

merged 12 commits into from
Jan 12, 2024

Conversation

lmolkova
Copy link
Member

@lmolkova lmolkova commented Dec 1, 2023

Fixes #37440 and #37441

@lmolkova lmolkova force-pushed the tracing-update-semconv branch from 117ce89 to 6e5fcd6 Compare December 1, 2023 01:01
@azure-sdk
Copy link
Collaborator

azure-sdk commented Dec 1, 2023 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-core-tracing-opentelemetry
com.azure:azure-core
com.azure:azure-core-metrics-opentelemetry
com.azure:azure-core-tracing-opentelemetry
com.azure:azure-messaging-eventhubs
com.azure:azure-messaging-servicebus
com.azure:azure-messaging-eventhubs-checkpointstore-blob

@lmolkova lmolkova force-pushed the tracing-update-semconv branch 3 times, most recently from 5be8c12 to 86b1fe5 Compare December 11, 2023 00:32
@lmolkova
Copy link
Member Author

@alzimmermsft @trask could you please take another look?

alzimmermsft
alzimmermsft approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@alzimmermsft alzimmermsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from a non-telemetry perspective

trask
trask reviewed Dec 14, 2023
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we won't have support for stable semconv in Application Insights Java agent until mid-Jan

this isn't a problem for semconv changes in azure-core-tracing-opentelemetry since we inject specific compatible version at runtime, but it may be a problem for semconv changes in azure-core

@lmolkova
Copy link
Member Author

lmolkova commented Dec 15, 2023 •
edited
Loading

we won't have support for stable semconv in Application Insights Java agent until mid-Jan

this isn't a problem for semconv changes in azure-core-tracing-opentelemetry since we inject specific compatible version at runtime, but it may be a problem for semconv changes in azure-core

great point!

So let me change this approach to:

  • keep (for now) old attribute names in azure-core
  • add mappings to the plugin instead
  • merge this PR and release new core/plugin in Jan
  • update plugin version in otel agent
  • let it settle for a month or two then update core and remove mappings as a final cleanup before we declare HTTP tracing stable

@lmolkova lmolkova force-pushed the tracing-update-semconv branch from 86b1fe5 to 0829605 Compare January 5, 2024 23:07
@lmolkova lmolkova force-pushed the tracing-update-semconv branch from 0829605 to 8d16705 Compare January 11, 2024 22:37
@lmolkova lmolkova merged commit 43364a2 into Azure:main Jan 12, 2024
44 checks passed
@lmolkova lmolkova mentioned this pull request Apr 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@alzimmermsft alzimmermsft alzimmermsft approved these changes

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@conniey conniey Awaiting requested review from conniey conniey is a code owner

@samvaity samvaity Awaiting requested review from samvaity

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 is a code owner

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@billwert billwert Awaiting requested review from billwert billwert is a code owner

Assignees
No one assigned
Labels
Azure.Core azure-core Event Hubs Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracing: Adopt OpenTelemetry HTTP semconv 1.23.1
4 participants
@lmolkova @azure-sdk @trask @alzimmermsft