Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ServiceBus] Fix NPE in instrumentProcess #35660

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

lmolkova
Copy link
Member

When an error happens during receiving a session, we can return ServiceBusMessageContext with null message

In such case, we log an error and should not trace or record any metrics. The instrumentation code should back off if the message is null.

@lmolkova lmolkova changed the title ix npe in instrumentProcess [ServiceBus] Fix NPE in instrumentProcess Jun 28, 2023
@lmolkova lmolkova self-assigned this Jun 28, 2023
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-messaging-servicebus

Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! (just remember to fixup the todo in changelog)

@lmolkova lmolkova enabled auto-merge (squash) June 28, 2023 22:26
@lmolkova lmolkova merged commit 7bd3e59 into Azure:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants