Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE in end span #35299

Merged
merged 4 commits into from
Jun 5, 2023
Merged

Fix NPE in end span #35299

merged 4 commits into from
Jun 5, 2023

Conversation

lmolkova
Copy link
Member

@lmolkova lmolkova commented Jun 5, 2023

Fixes #35297

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

conniey
conniey approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@conniey conniey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Does this bug exist in azure-messaging-eventhubs? They share similar tracing logic.

anuchandy
anuchandy approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@lmolkova lmolkova merged commit 7395f50 into Azure:main Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conniey conniey conniey approved these changes

@anuchandy anuchandy anuchandy approved these changes

Assignees
No one assigned
Labels
Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] NullPointerException using session receiver and tracing
4 participants
@lmolkova @azure-sdk @anuchandy @conniey