Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Warning logs about client properties while using Kafka passwordless function #32235

Closed
yiliuTo opened this issue Nov 18, 2022 · 2 comments · Fixed by #32764
Closed

[BUG] Warning logs about client properties while using Kafka passwordless function #32235

yiliuTo opened this issue Nov 18, 2022 · 2 comments · Fixed by #32764
Assignees
Labels
azure-spring All azure-spring related issues azure-spring-4.0 bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.
Milestone

Comments

@yiliuTo
Copy link
Member

yiliuTo commented Nov 18, 2022

Describe the bug
When using Kafka passwordless connection function, there are warning logs of

2022-09-22 14:50:51.784  WARN 30520 --- [           main] .f.AbstractAzureHttpClientBuilderFactory : The client properties of an http-based client is of type com.azure.spring.cloud.core.properties.client.ClientProperties

To Reproduce
Follow the QuickStart to build an application and run.

Expected behavior
Warning logs should be removed without any breaking changes to users.

@yiliuTo yiliuTo added bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. azure-spring All azure-spring related issues azure-spring-4.0 labels Nov 18, 2022
@yiliuTo yiliuTo added this to the Backlog milestone Nov 18, 2022
@yiliuTo yiliuTo self-assigned this Nov 18, 2022
@yiliuTo yiliuTo moved this to Todo in Spring Cloud Azure Nov 18, 2022
@yiliuTo yiliuTo removed their assignment Dec 16, 2022
@saragluna saragluna modified the milestones: Backlog, 2023-02 Dec 30, 2022
@backwind1233 backwind1233 moved this from Todo to In Progress in Spring Cloud Azure Jan 3, 2023
@Netyyyy
Copy link
Member

Netyyyy commented Jan 4, 2023

Now we directly transport service properties to Azure properties, such as:

    protected AzureProperties getAzureProperties() {
        return this.secretClientProperties;
    }

and then resolve the token credential from the transported AzureProperties, so there might be issues where configured properties like proxy or retry are correct for the service, but might not work for the token credential, which needs to be confirmed.

@saragluna
Copy link
Member

The current implementation will only reduce the log level, a temporary workaround. This problem will be fixed when #32443 gets resolved.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Spring Cloud Azure Jan 4, 2023
@backwind1233 backwind1233 changed the title [BUG] Warning logs about client properties while using Kafka password-less function [BUG] Warning logs about client properties while using Kafka passwordless function Feb 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
azure-spring All azure-spring related issues azure-spring-4.0 bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.
Projects
Archived in project
3 participants