-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up dependencies for live / mock testing for client libraries #3208
Comments
@sima-zhu Please work with @conniey on this and help drive this. |
Started from the guideline in the description.
|
The main goal here is to no longer depend on azure-mgmt-resources in any of our client libraries. |
I will divide the task into two major parts:
|
Finished #1, #2, #4 We will implement the interceptor if there is use case we need to build up more stuff on the top of the API. Same as the ResourceManagerThrottlingInterceptor, we will add more functionalities when they are necessary in track two. I will close the issue for now. Please feel free to reopen if any other issue to address. |
At present, to enable our live / mock tests, we are using two specific versions of azure-mgmt-resources, as this particular management library provided utility classes for live/mock testing that are helpful. Depending on management libraries within the client libraries for testing feels weird, but even worse is the fact that we depend on two different versions, with one being a snapshot.
What I propose is that we isolate the set of classes we use out of azure-mgmt-resources, and add these as classes in either an azure-common-test module, or else as part of azure-common in src/test.
We need an
InterceptorManager
. There are two candidates (and we may bring them both in, for track two and track one, respectively):1.1 The 'V3' InterceptorManager
1.2 The 'original' InterceptorManager
We also require com.microsoft.azure.management.resources.core.TestBase, or an equivalent.
As well as com.microsoft.azure.management.resources.fluentcore.utils.ResourceManagerThrottlingInterceptor
We should transfer relevant test classes out of the azconfig directory into this new location.
The ideal outcome out of this would be to entirely drop out dependency on azure-mgmt-resources, and to resolve the dependency version divergence that we create.
The text was updated successfully, but these errors were encountered: