Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Keep default options consistent between Spring and Java SDK #31494

Closed
yiliuTo opened this issue Oct 14, 2022 · 1 comment · Fixed by #32897
Closed

[BUG] Keep default options consistent between Spring and Java SDK #31494

yiliuTo opened this issue Oct 14, 2022 · 1 comment · Fixed by #32897
Assignees
Labels
azure-spring All azure-spring related issues azure-spring-boot Label for spring issues related with Spring Boot Auto-configuration bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.
Milestone

Comments

@yiliuTo
Copy link
Member

yiliuTo commented Oct 14, 2022

Context

In Spring configuration properties, it's common that there is explicit default-value assignment, e.g., the load-balancing strategy. However, this can cause the default values of Spring and Java SDK become inconsistent when SDK changed their default options. Referring to #25039

Solution

Remove those default options in Spring properties and hand over to SDK.

@yiliuTo yiliuTo added Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. azure-spring All azure-spring related issues azure-spring-4.0 labels Oct 14, 2022
@yiliuTo yiliuTo added this to the 2022-12 milestone Oct 14, 2022
@yiliuTo yiliuTo moved this to Todo in Spring Cloud Azure Oct 14, 2022
@saragluna saragluna modified the milestones: 2022-12, Backlog Nov 7, 2022
@saragluna saragluna modified the milestones: Backlog, 2023-02 Dec 30, 2022
@yiliuTo yiliuTo self-assigned this Jan 6, 2023
@yiliuTo yiliuTo added azure-spring-boot Label for spring issues related with Spring Boot Auto-configuration azure-spring-zinc and removed azure-spring-boot Label for spring issues related with Spring Boot Auto-configuration labels Jan 9, 2023
@yiliuTo yiliuTo changed the title [FEATURE REQ] Keep default options consistent between Spring and Java SDK [BUG] Keep default options consistent between Spring and Java SDK Jan 9, 2023
@yiliuTo yiliuTo added bug This issue requires a change to an existing behavior in the product in order to be resolved. and removed feature-request This issue requires a new behavior in the product in order be resolved. labels Jan 9, 2023
@yiliuTo yiliuTo moved this from Todo to In Progress in Spring Cloud Azure Jan 9, 2023
@yiliuTo
Copy link
Member Author

yiliuTo commented Jan 10, 2023

All the auto-configuration components provided by Spring Cloud Azure can be devided into 3 types: auto-configuration for Azure services with Azure SDK, auto-configuration without Azure SDK and other internal modules. This issue aims to keep the consistency of the default values between auto-configuration modules with Azure SDK and Azure SDK.

Auto-configuration with Azure SDK

Service Needs aligned Property with default values Breaking changes
App Config NA NA
Cosmos & Data cosmos connection-mode No
Service Bus receive-mode
auto-complete
sub-queue
max-auto-lock-renew-duration
maxConcurrentCalls
No
Event Hubs load-balancing.strategy changed from BALANCED to GREEDY
KV Cert NA NA
KV Secret NA NA
Storage Blob NA NA
Storage File Share NA NA
Storage Queue NA NA
Resource Manager NA NA
Global - credential NA NA
Global - retry retry.mode NA
Global - proxy NA NA
Global - client transport-type No
Global - profile NA NA

Note, the default value of the profile property cloud-type cannot be removed, which is required here.

Auto-configuration without Azure SDK

  • ✖️ aad & b2c --> omit
  • ✖️ jdbc --> covered by global properties
  • ✖️ event hubs for kafka --> covered by global properties
  • ✖️ service bus for jms --> omit
  • ✖️ redis -> covered by resource manager
  • ✖️ cloud foundry --> omit

Internal modules

  • ✖️ compatibility --> omit

@github-project-automation github-project-automation bot moved this from In Progress to Done in Spring Cloud Azure Jan 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
azure-spring All azure-spring related issues azure-spring-boot Label for spring issues related with Spring Boot Auto-configuration bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants