Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set x-ms-app HTTP request header in Monitor Query library #28034

Closed
scottaddie opened this issue Apr 5, 2022 · 1 comment
Closed

Set x-ms-app HTTP request header in Monitor Query library #28034

scottaddie opened this issue Apr 5, 2022 · 1 comment
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Monitor Monitor, Monitor Ingestion, Monitor Query
Milestone

Comments

@scottaddie
Copy link
Member

scottaddie commented Apr 5, 2022

Library name

azure-monitor-query

Please describe the feature.

The Azure Monitor Log Analytics service team stores the caller information for their REST APIs. To support tracking HTTP requests from the Azure Monitor Query library, send an x-ms-app request header. The header's value should be set to AzureMonitorQuerySDK. The metrics team uses the user agent to identify the caller. Send this header ONLY for logs queries.

@scottaddie scottaddie added Client This issue points to a problem in the data-plane of the library. Monitor - Query labels Apr 5, 2022
@scottaddie scottaddie added this to the [2022] August milestone Jun 6, 2022
@scottaddie scottaddie added the Monitor Monitor, Monitor Ingestion, Monitor Query label Jun 15, 2022
@scottaddie
Copy link
Member Author

After reviewing with the arch board, a decision was made to not make this change. As a workaround, the Draft service team can run a contains operation on the user agent string to identify the caller. This workaround has been communicated to Dan Hadari.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Monitor Monitor, Monitor Ingestion, Monitor Query
Projects
None yet
Development

No branches or pull requests

2 participants