Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] Add ability to manage rules with the ServiceBusReceiver #27711

Closed
JoshLove-msft opened this issue Mar 16, 2022 · 4 comments
Closed
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. Service Bus
Milestone

Comments

@JoshLove-msft
Copy link
Member

This existed in Track 1, and allowed users with only Listen claims to manage rules on the subscription that they had listen claims for. In Track 2, this can be done using the ServiceBusAdministrationClient, but it requires Manage claims.

.NET issue - Azure/azure-sdk-for-net#25523
.NET PR - Azure/azure-sdk-for-net#27346

@JoshLove-msft JoshLove-msft added Service Bus Client This issue points to a problem in the data-plane of the library. labels Mar 16, 2022
@ki1729 ki1729 self-assigned this Apr 11, 2022
@ki1729 ki1729 added this to the [2022] May milestone Apr 11, 2022
@conniey conniey added the feature-request This issue requires a new behavior in the product in order be resolved. label Apr 26, 2022
@JoshLove-msft JoshLove-msft modified the milestones: [2022] May, [2022] June May 17, 2022
@jsquire jsquire modified the milestones: [2022] June, [2022] July Jun 13, 2022
@conniey conniey moved this from Planned to In Progress in Azure SDK for Service Bus Jun 29, 2022
@ZejiaJiang ZejiaJiang self-assigned this Jul 5, 2022
@ZejiaJiang
Copy link
Member

ZejiaJiang commented Jul 5, 2022

Hi @JoshLove-msft @jsquire I'm looking at this issue, after going through dotnet code, it feels like we just add a new client type RuleManager to manage rules if user set topic, subscription and connectionString with Listen claims. It seems like that we don't add ability to ServiceBusReceiver. Did I misunderstand?

@jsquire
Copy link
Member

jsquire commented Jul 5, 2022

That was the approach that .NET took for modeling the API. Since this functionality requires a dedicated set of AMQP links, it cannot be done directly via the Receiver's existing infrastructure and isolating that functionality in a dedicated type helps to manage that scope as well as logically group the related operations.

Personally, I'd like to see the pattern in Java align with the .NET API unless there's a good reason to deviate.

@ZejiaJiang
Copy link
Member

Thank you @jsquire .I got it. And I'd like to make it clear. Actually the sender client or other client, they both use the dedicated set of AMQP links. What I mean above is we don't just add some new API to ServiceBusReceiver. My understanding is the rule manager use AMQP link to send operations to server just like sender and receiver, different from admin client using the HTTP.

@jsquire
Copy link
Member

jsquire commented Jul 6, 2022

Correct; rule management here goes over a special set of AMQP links, not via the HTTP Atom service.

@ki1729 ki1729 closed this as completed Oct 31, 2022
Repository owner moved this from In Progress to Done in Azure SDK for Service Bus Oct 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. Service Bus
Projects
Status: Done
Development

No branches or pull requests

5 participants