Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServiceBusTemplate should not support partition id #27349

Closed
yiliuTo opened this issue Mar 1, 2022 · 1 comment
Closed

ServiceBusTemplate should not support partition id #27349

yiliuTo opened this issue Mar 1, 2022 · 1 comment
Assignees
@yiliuTo
Labels
azure-spring All azure-spring related issues azure-spring-servicebus Spring service bus related issues. bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.
Milestone
Spring Cloud Azur...

Comments

@yiliuTo
Copy link
Member

yiliuTo commented Mar 1, 2022

Due to partition id is not supported in Service Bus, referring https://docs.microsoft.com/en-gb/azure/service-bus-messaging/service-bus-partitioning#use-of-partition-keys, thus ServiceBusTemplate #sendAsync should not accept a PartitionSupplier directly which is able to configure both partition key and id.
@yiliuTo yiliuTo added bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. azure-spring All azure-spring related issues azure-spring-servicebus Spring service bus related issues. labels Mar 1, 2022
@yiliuTo yiliuTo added this to the Spring Cloud Azure 4.0 Beta4 milestone Mar 1, 2022
@yiliuTo yiliuTo self-assigned this Mar 1, 2022
@yiliuTo yiliuTo moved this to Todo in Spring Cloud Azure Mar 1, 2022
@yiliuTo yiliuTo moved this from Todo to In Progress in Spring Cloud Azure Mar 2, 2022
@yiliuTo yiliuTo mentioned this issue Mar 3, 2022
Merged
@yiliuTo yiliuTo moved this from In Progress to Done in Spring Cloud Azure Mar 4, 2022
@saragluna
Copy link
Member

Closed in #27422.

@saragluna saragluna mentioned this issue Mar 4, 2022
Closed
35 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yiliuTo yiliuTo

Labels
azure-spring All azure-spring related issues azure-spring-servicebus Spring service bus related issues. bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library.
Projects
Spring Cloud Azure
Archived in project
Milestone
Spring Cloud Azure 4.0 Beta4
Development

No branches or pull requests
2 participants
@saragluna @yiliuTo