Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tracing back to petclinic #26306

Closed
Tracked by #26166
, #27868
...
backwind1233 opened this issue Jan 6, 2022 · 3 comments
Closed
Tracked by #26166
, #27868
...

Add tracing back to petclinic #26306

backwind1233 opened this issue Jan 6, 2022 · 3 comments
Labels
azure-spring All azure-spring related issues azure-spring-samples Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone
Backlog

Comments

@backwind1233
Copy link
Contributor

backwind1233 commented Jan 6, 2022 •
edited by Netyyyy
Loading

Context

In this PR ,tracing-server, grafana-server, prometheus-server were removed from docker-compose.yml,

Goal

  • add them back to make the sample works.
  • enable the Spring Cloud Azure Trace Sleuth in this sample.
@backwind1233 backwind1233 mentioned this issue Jan 6, 2022
Closed
29 tasks
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 6, 2022
@backwind1233 backwind1233 self-assigned this Jan 6, 2022
@backwind1233 backwind1233 added the azure-spring All azure-spring related issues label Jan 6, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 6, 2022
@backwind1233 backwind1233 added this to the [2022] March milestone Jan 6, 2022
@saragluna saragluna assigned Netyyyy and unassigned backwind1233 Jan 6, 2022
@saragluna
Copy link
Member

@moarychan assign this to you.

@saragluna saragluna moved this to Todo in Spring Cloud Azure Jan 6, 2022
@saragluna saragluna changed the title Add tracing back to petclinic Add tracing back to petclinic @moary Jan 6, 2022
@backwind1233 backwind1233 mentioned this issue Jan 7, 2022
Merged
@backwind1233 backwind1233 self-assigned this Feb 10, 2022
@moarychan
Copy link
Member

moarychan commented Mar 3, 2022 •
edited
Loading

Due to the limited support of Spring Cloud Azure Trace Sleuth and no library using storage, we will not enable Sleuth support for the time being.

@backwind1233 backwind1233 mentioned this issue Mar 25, 2022
Closed
10 tasks
@stliu stliu added azure-spring-copper Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. labels Apr 2, 2022
@Netyyyy Netyyyy changed the title Add tracing back to petclinic @moary Add tracing back to petclinic May 7, 2022
@Netyyyy Netyyyy removed their assignment Dec 9, 2022
@stliu
Copy link
Member

stliu commented Dec 10, 2022

closing it for now, no customer ask, reopen if anyone need it

@stliu stliu closed this as completed Dec 10, 2022
Repository owner moved this from Todo to Done in Spring Cloud Azure Dec 10, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
azure-spring All azure-spring related issues azure-spring-samples Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
Spring Cloud Azure
Archived in project
Milestone
Backlog
Development

No branches or pull requests
6 participants
@stliu @backwind1233 @moarychan @saragluna @yiliuTo @Netyyyy