Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor petclinic samples #26234

Closed
Tracked by #26166
backwind1233 opened this issue Jan 4, 2022 · 2 comments
Closed
Tracked by #26166

Refactor petclinic samples #26234

backwind1233 opened this issue Jan 4, 2022 · 2 comments
Assignees
@hui1110
Labels
azure-spring All azure-spring related issues azure-spring-samples Client This issue points to a problem in the data-plane of the library.
Milestone
Spring Cloud Azur...

Comments

@backwind1233
Copy link
Contributor

backwind1233 commented Jan 4, 2022 •
edited
Loading

Need some more detail:

  1. Refactor petclinic samples using spring-cloud-azure-starter-data-cosmos instead of azure-spring-data-cosmos
  2. Refactored with terraform:
  • for now, to run the sample, users need to configure several properties.
  • since we have refactored many of our samples with terraform and defaultcredential, it's better to refactor this to provide our users with the same experience.
  1. Make the dependency of petclinic samples clean, remove duplicated and unused dependencies.
  2. Format the dependency of petclinic samples with the same indent.
  3. Delete testing code and dependency.
  4. use bom Linked in this PR
    image
@backwind1233 backwind1233 mentioned this issue Jan 4, 2022
Closed
1 task
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 4, 2022
@chenrujun chenrujun added azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library. labels Jan 5, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 5, 2022
@chenrujun chenrujun moved this to Todo in Spring Cloud Azure Jan 5, 2022
@chenrujun chenrujun added this to the Backlog milestone Jan 5, 2022
@backwind1233 backwind1233 mentioned this issue Jan 6, 2022
Closed
29 tasks
@saragluna saragluna assigned hui1110 and unassigned backwind1233 Jan 6, 2022
This was referenced Jan 7, 2022
Merged
Merged
@hui1110 hui1110 moved this from Todo to In Progress in Spring Cloud Azure Jan 16, 2022
This was referenced Jan 19, 2022
Closed
Closed
@saragluna saragluna moved this from In Progress to Pending Review in Spring Cloud Azure Jan 29, 2022
@saragluna saragluna moved this from Pending Review to In Progress in Spring Cloud Azure Jan 29, 2022
@saragluna saragluna moved this from In Progress to Need Help in Spring Cloud Azure Jan 29, 2022
@backwind1233 backwind1233 self-assigned this Feb 10, 2022
@yiliuTo yiliuTo removed this from the [2022] March milestone Feb 10, 2022
@yiliuTo yiliuTo added this to the Spring Cloud Azure 4.0 Beta4 milestone Feb 10, 2022
@hui1110 hui1110 mentioned this issue Feb 11, 2022
Closed
@hui1110
Copy link
Contributor

hui1110 commented Feb 14, 2022

Azure-Samples/azure-spring-boot-samples#186

@hui1110
Copy link
Contributor

hui1110 commented Feb 23, 2022

The corresponding pr has been merged.

@hui1110 hui1110 closed this as completed Feb 23, 2022
Repository owner moved this from Need Help to Done in Spring Cloud Azure Feb 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hui1110 hui1110

Labels
azure-spring All azure-spring related issues azure-spring-samples Client This issue points to a problem in the data-plane of the library.
Projects
Spring Cloud Azure
Archived in project
Milestone
Spring Cloud Azure 4.0 Beta4
Development

No branches or pull requests
5 participants
@backwind1233 @chenrujun @saragluna @hui1110 @yiliuTo