Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Invalid message order in batch sending #25599

Closed
grzegorzkalisz opened this issue Nov 22, 2021 · 4 comments · Fixed by #27366
Closed

[BUG] Invalid message order in batch sending #25599

grzegorzkalisz opened this issue Nov 22, 2021 · 4 comments · Fixed by #27366
Assignees
@ki1729
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Bus

Comments

@grzegorzkalisz
Copy link

After upgrading azure-messaging-servicebus lib from 7.0.1 to 7.3.0, I noticed that batch sending is reordering messages in Service Bus. I suppose this is due to the use of parallelStream() in the ServiceBusMessageBatch.sendInternal() method. This has been changed in the commit: a9b28ec#diff-bfbb3d6ac91c080eaa27ee29c12058246337099dcd205dc86a625dee08bfa17e.
I expect the order of the messages in the list for batch should be the same as in Service Bus.
@ghost ghost added customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Nov 22, 2021
@alzimmermsft alzimmermsft added Client This issue points to a problem in the data-plane of the library. Service Bus labels Nov 22, 2021
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Nov 22, 2021
@alzimmermsft
Copy link
Member

@ki1729 could you take a look into this?

@grzegorzkalisz
Copy link
Author

@ki1729 could you take a look into this?

Are there any news in this case?

@conniey conniey mentioned this issue Mar 1, 2022
Merged
6 tasks
@ki1729
Copy link
Contributor

ki1729 commented Mar 1, 2022

@grzegorzkalisz Changes are merged, and should be part of the March release

@grzegorzkalisz
Copy link
Author

@grzegorzkalisz Changes are merged, and should be part of the March release

Thanks for your support!

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ki1729 ki1729

Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing ordering problem when sending messages in a batch ki1729/azure-sdk-for-java
3 participants
@grzegorzkalisz @alzimmermsft @ki1729