Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] azure.core.credential.AzureSasCredential Sanitize SAS for URIs #20561

Closed
jaschrep-msft opened this issue Apr 12, 2021 · 0 comments · Fixed by #23033
Closed

[FEATURE REQ] azure.core.credential.AzureSasCredential Sanitize SAS for URIs #20561

jaschrep-msft opened this issue Apr 12, 2021 · 0 comments · Fixed by #23033
Assignees
Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Milestone

Comments

@jaschrep-msft
Copy link
Member

Customers currently have a mechanism to get a SAS that doesn't properly encode some things in the signature. Notably, spaces in Storage's si parameter value. Storage has three APIs to ingest a SAS but only sanitizes those illegal characters for two of them. The third is AzureSasCredential, which leaves the illegal characters in and causes URISyntaxExceptions to be thrown in the web stack.

AzureSasCredential should sanitize their inputs the same way Storage code currently does. It should support this on both construction and update.

While Storage code could conceivably do this sanitation upon receiving the credential, it cannot help the customer when they wish to rotate a SAS in said credential object. The problem is just put off until rotation rather than initial setup.

@jaschrep-msft jaschrep-msft added Storage Storage Service (Queues, Blobs, Files) Client This issue points to a problem in the data-plane of the library. labels Apr 12, 2021
@alzimmermsft alzimmermsft added the Azure.Core azure-core label Apr 12, 2021
@alzimmermsft alzimmermsft added this to the [2021] August milestone May 27, 2021
@srnagar srnagar self-assigned this Jun 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants