Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Can't change userNameAttributeName for azure sso #20209

Closed
3 tasks done
j0nathan33 opened this issue Mar 29, 2021 · 2 comments · Fixed by #20340
Closed
3 tasks done

[BUG] Can't change userNameAttributeName for azure sso #20209

j0nathan33 opened this issue Mar 29, 2021 · 2 comments · Fixed by #20340
Assignees
@chenrujun
Labels
azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues. bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization.
Milestone
[2021] May

Comments

@j0nathan33
Copy link

Describe the bug
I try to change value of userNameAttributeName in my application.yml and value is not updated.

In AADWebAppConfiguration (line 165), value is not set. For value is set, you need to call fonction with ClientRegistration in parameter.
In AADOAuth2UserService (Line 81), value is always null and It take default value.

To Reproduce
Try to change default value and It don't working.

Code Snippet
My application.yml

spring:
  security:
    oauth2:
      client:
        provider:
          azure:
            user-name-attribute: upn

Expected behavior
userNameAttributeName don't have default value when my user is connected

Setup (please complete the following information):

  • spring 5.4.3
  • azure-spring-boot-starter-active-directory 3.2.0

Additional context
I migrate from old version of azure-spring-boot. All other feature in my application is working.

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • Bug Description Added
  • Repro Steps Added
  • Setup information Added
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Mar 29, 2021
@joshfree joshfree added azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues. Client This issue points to a problem in the data-plane of the library. labels Mar 30, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 30, 2021
@joshfree
Copy link
Member

@stliu could you please take a look?

@joshfree joshfree added this to the [2021] May milestone Mar 30, 2021
@stliu stliu assigned chenrujun and unassigned stliu Mar 31, 2021
@chenrujun chenrujun added bug This issue requires a change to an existing behavior in the product in order to be resolved. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Apr 2, 2021
@chenrujun
Copy link

@j0nathan33

Thank you for reaching out.
It's a bug, we will fix it.

@chenrujun chenrujun linked a pull request Apr 2, 2021 that will close this issue
Fix bug: Can't change userNameAttributeName for azure sso. #20340
Merged
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this issue Aug 17, 2022
CodeGen from PR 20209 in Azure/azure-rest-api-specs
16d9c59 
[Hub Generated] Review request for Microsoft.SqlVirtualMachine to add version preview/2022-07-01-preview (Azure#20209)

* Adds base for updating Microsoft.SqlVirtualMachine from version preview/2022-02-01-preview to version 2022-07-01-preview

* Updates readme

* Updates API version in new specs and examples

* Updating swagger to latest api
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chenrujun chenrujun

Labels
azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues. bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
[2021] May
Development

Successfully merging a pull request may close this issue.

Fix bug: Can't change userNameAttributeName for azure sso. chenrujun/azure-sdk-for-java
4 participants
@stliu @j0nathan33 @joshfree @chenrujun