Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos GoneAndRetryWithRetryPolicy bad log message #17038

Closed
moderakh opened this issue Oct 30, 2020 · 4 comments
Closed

Cosmos GoneAndRetryWithRetryPolicy bad log message #17038

moderakh opened this issue Oct 30, 2020 · 4 comments
Labels
Client This issue points to a problem in the data-plane of the library. cosmos:v4-item Indicates this feature will be shipped as part of V4 release train Cosmos

Comments

@moderakh
Copy link
Contributor

GoneAndRetryWithPolicy logs failure for 404, Logging in warn level is incorrect and will cause confusion to end users:

2020-10-30 14:27:28,946       [cosmos-rntbd-nio-2-2] WARN  com.azure.cosmos.implementation.directconnectivity.GoneAndRetryWithRetryPolicy - Operation will NOT be retried. Current attempt 1, Exception: 
com.azure.cosmos.implementation.NotFoundException: ["Resource Not Found"]
	at com.azure.cosmos.implementation.directconnectivity.rntbd.RntbdRequestManager.messageReceived(RntbdRequestManager.java:812) [classes/:?]
	at com.azure.cosmos.implementation.directconnectivity.rntbd.RntbdRequestManager.channelRead(RntbdRequestManager.java:181) [classes/:?]

The log level for any failure (e.g. 404) which is not related to GoneAndRetryWithRetryPolicy should be debug not warn. This will be confusing the customers.

@moderakh moderakh added Cosmos Client This issue points to a problem in the data-plane of the library. cosmos:v4-item Indicates this feature will be shipped as part of V4 release train labels Oct 30, 2020
@ghost
Copy link

ghost commented Oct 30, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @kushagraThapar, @anfeldma-ms

@moderakh moderakh changed the title Cosmos bad log message Cosmos GoneAndRetryWithRetryPolicy bad log message Oct 30, 2020
@kushagraThapar
Copy link
Member

This has been fixed, closing it.

@moderakh
Copy link
Contributor Author

moderakh commented Mar 9, 2021

@kushagraThapar I am not sure if it is fixed.
Which PR fixed this?

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. cosmos:v4-item Indicates this feature will be shipped as part of V4 release train Cosmos
Projects
None yet
Development

No branches or pull requests

2 participants