Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] Remove the SendVia option on sender in favor of upcoming implicit transactional via sender and receiver #17017

Closed
ramya-rao-a opened this issue Oct 30, 2020 · 0 comments · Fixed by #17018
Assignees
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Service Bus

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Oct 30, 2020

The current azure-servicebus library has this SendVia option that one can set on the sender in order to use the transactions across entities. As seen in #16942, we are moving to an implicit transactional via sender model where the user does not have to provide the SendVia option anymore.

This issue is to remove this option from the newer azure-messaging-servicebus library so that in a future update, we can add the implicit transactional via sender model without needing to deprecate the SendVia option.

Please note, in the newer azure-messaging-servicebus library, this option was split to viaQueueName and viaTopicName

This issue is to track

  • removal of viaQueueName and viaTopicName from the sender sub builder
  • removal of viaQueueName and viaTopicName properties on the sender client

cc @hemanttanwar, @conniey, @YijunXieMS

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 30, 2020
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Service Bus labels Oct 30, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 30, 2020
@ramya-rao-a ramya-rao-a added blocking-release Blocks release needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Oct 30, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 30, 2020
@ramya-rao-a ramya-rao-a added this to the [2020] November milestone Oct 30, 2020
@ramya-rao-a ramya-rao-a self-assigned this Oct 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant