-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmos Client Builder overrides direct connection config idleConnectionTimeout with gateway connection config #12971
Comments
Excellent! Thanks @kushagraThapar |
This is done and will be released in 4.2.0 release tentatively next week. |
@kushagraThapar It seems that the requestTimeout suffers the same fate. |
@allenhumphreys Not really, as requestTimeout is not public API and it is hardcoded internally at 5 second for both direct and gateway connection configs. |
I see. I didn't realize it wasn't public. Spring properties binding has no problem setting the values 😬. So public or private, I have set the value to 2 seconds. Is that inadvisable? |
Hahaha, not really, I think that should be fine - although you are already aware of the fact that requestTimeout only indicates the I/O timeout - so I think 2 seconds should be fine. I don't see a problem with that. @moderakh - do you see any issue with Allen setting the requestTimeout to 2 seconds ? |
our P99 latency for items of size 1KB is < 10ms however for some corner case scenario (query payload being huge, etc), the server side contract is to respond in 5 seconds, this is the reason the SDK default is 5 seconds. I don't think this will be hit on the normal path though. You can set it to 2 seconds provided that you are aware of the above. |
Testing automations on build pipeline (#12971) * blank file * Add dummy text
Testing automations on build pipeline (#12971) * blank file * Add dummy text
This is a bug which popped up in this ICM: https://portal.microsofticm.com/imp/v3/incidents/details/194516399/home
In the below code ->
If both
directConnectionConfig
andgatewayConnectionConfig
are present, then idleConnectionTimeout will always be overriden bygatewayConnectionConfig
The text was updated successfully, but these errors were encountered: