Cosmos Samples issues

[Melanie-Ma]

Section Link:

Reason:

Suggestion:
Update the code:
CosmosAsyncClient cosmosAsyncClient = new CosmosClientBuilder().buildAsyncClient();
to:
CosmosAsyncClient cosmosAsyncClient = new CosmosClientBuilder() .endpoint(TestConfigurations.HOST) .key(TestConfigurations.MASTER_KEY) .buildAsyncClient();

[Melanie-Ma]

@jongio ， for notification.

[kushagraThapar]

@Melanie-Ma - these are not samples - but rather just the code snippets used in documentation.
They are not designed to run, but just designed to tag in the code documentation.
For samples, please refer to : https://github.com/Azure-Samples/azure-cosmos-java-sql-api-samples

[Melanie-Ma]

@kushagraThapar - I agree that the code snippets are used in documentation. However, I think that the code documentation also need right example for users ′ reference. Therefore, I think the issue need to be fixed.

[kushagraThapar]

@Melanie-Ma - For your #1 issue -> The reason we cannot use endpoints and keys in code snippets is because we cannot have real endpoints in the documentation.
Also, the documentation only refers to the tagged code not the overall code - see below :

Regarding #2 -> @moderakh - please take a look at the analytical storage issue.

[jongio]

Howdy - Sample code should be copy and paste-able. We aren't suggesting an actual endpoint, just code that will work if the user tries to use it.

@Melanie-Ma - Would be great to see a PR for your suggestions. For the first issue.

Can you open another issue for the second issue you found so we can track that separately?

Thanks,
Jon

@tzhanl

[kushagraThapar]

@jongio - I think the argument is incorrect here. At first place, this is not sample code, this is code snippet.
Samples are here: https://github.com/Azure-Samples/azure-cosmos-java-sql-api-samples

To treat code snippets as samples is incorrect in my opinion. Because the relative part of the code snippet that is present in the docs works correctly.

We don't want users to look at these code snippets directly through source code, but rather through documentation. I think the directory structure is making it a wrong impression, because it says samples.

@srnagar @alzimmermsft - thoughts ?

[Melanie-Ma]

@jongio - I have opened another issue for the second issue. Please review.

[moderakh]

2 is not an issue in the SDK. you need to enable the feature on the service side before attempting to use it.
@srchi is the PM who can help on enabling analytical store in the account.