Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core Samples issues #12486

Closed
Melanie-Ma opened this issue Jun 24, 2020 · 2 comments · Fixed by #13393
Closed

Core Samples issues #12486

Melanie-Ma opened this issue Jun 24, 2020 · 2 comments · Fixed by #13393
Assignees
@alzimmermsft
Labels
Azure.Core azure-core blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Docs needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team test-manual-pass
Milestone
[2020] August

Comments

@Melanie-Ma
Copy link
Contributor

Melanie-Ma commented Jun 24, 2020 •
edited
Loading

Section Link:
image
image
Question:
The type PagedFluxBase<T,P> is deprecated, so whether the method byTSnippet() of the sample still needs?
2.
Section Link:
image
image
Question:
The method createCustomInstance() returns null which caused null point exception for the method iterableByPageWhileSnippet() . So what kind of results do you want for this sample?
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jun 24, 2020
@Melanie-Ma
Copy link
Contributor Author

@jongio , for notification.

@joshfree joshfree added Azure.Core azure-core Client This issue points to a problem in the data-plane of the library. Docs labels Jun 24, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 24, 2020
@joshfree joshfree removed customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jun 24, 2020
@tzhanl tzhanl added blocking-release Blocks release manual-test-pass needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team labels Jul 15, 2020
@tzhanl tzhanl added this to the [2020] August milestone Jul 15, 2020
@alzimmermsft
Copy link
Member

Given this is a codesnippet for the deprecated class it is fine that it warns about deprecation. I'll update the example to use a more real world scenario to resolve the NullPointerException.

@alzimmermsft alzimmermsft mentioned this issue Jul 21, 2020
Merged
@Melanie-Ma Melanie-Ma mentioned this issue Aug 25, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alzimmermsft alzimmermsft

Labels
Azure.Core azure-core blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Docs needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team test-manual-pass
Projects
None yet
Milestone
[2020] August
Development

Successfully merging a pull request may close this issue.

Update PagedFluxCore Javadoc Code Snippets alzimmermsft/azure-sdk-for-java
4 participants
@joshfree @tzhanl @alzimmermsft @Melanie-Ma