Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DirectConnectionConfig / GatewayConnectionConfig APIs / docs #11531

Closed
kushagraThapar opened this issue May 28, 2020 · 3 comments
Closed

DirectConnectionConfig / GatewayConnectionConfig APIs / docs #11531

kushagraThapar opened this issue May 28, 2020 · 3 comments
Assignees
Labels
cosmos:v4-item Indicates this feature will be shipped as part of V4 release train Cosmos

Comments

@kushagraThapar
Copy link
Member

kushagraThapar commented May 28, 2020

DirectConnectionConfig -
2. getConnectionTimeout() - change it to -> connectTimeout

requestTimeout -> This incorporates - consistency layer and I/O operations.
It does not include retry timeouts, serialization / deserialization timeouts.

To change the behavior ->

  1. Initialize TimeoutHelper in ReplicatedResourceClient - with some constant value - 30 seconds or more ?
  2. Keep using requestTimeout for I/O operations.
  3. Hide requestTimeout API from DirectConnectionConfig & GatewayConnectionConfig
@kushagraThapar
Copy link
Member Author

This is done.

@kushagraThapar
Copy link
Member Author

This is still in progress, closed by mistake.

@kushagraThapar
Copy link
Member Author

This is done now.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cosmos:v4-item Indicates this feature will be shipped as part of V4 release train Cosmos
Projects
None yet
Development

No branches or pull requests

3 participants