Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getRequestCharge() / Properties types / getResourceId() APIs #11483

Closed
kushagraThapar opened this issue May 27, 2020 · 2 comments
Closed

getRequestCharge() / Properties types / getResourceId() APIs #11483

kushagraThapar opened this issue May 27, 2020 · 2 comments
Assignees
@milismsft
Labels
cosmos:v4-item Indicates this feature will be shipped as part of V4 release train Cosmos

Comments

@kushagraThapar
Copy link
Member

kushagraThapar commented May 27, 2020 •
edited
Loading

  1. getRequestCharge() API - update docs for this API across SDK
  2. Remove no-arg constructors across properties types across SDK.
  3. Add constructors with id and body where necessary (CosmosTriggerProperties, CosmosUserProperties, CosmosStoredProcedureProperties, etc.)
  4. Remove getResourceId() API - package private across SDK
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 27, 2020
@kushagraThapar kushagraThapar added Cosmos cosmos:v4-item Indicates this feature will be shipped as part of V4 release train labels May 27, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 27, 2020
@kushagraThapar kushagraThapar mentioned this issue May 27, 2020
Closed
35 tasks
@milismsft
Copy link
Contributor

milismsft commented May 28, 2020 •
edited
Loading

@kushagraThapar 2. and 3. cannot be implemented because there's a constructor that takes a JSON payload which is used to create the resource object underneath.

Never mind, ignore the above; I think I got the changes to be made...

@milismsft milismsft mentioned this issue May 28, 2020
Merged
@kushagraThapar
Copy link
Member Author

This is done.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@milismsft milismsft

Labels
cosmos:v4-item Indicates this feature will be shipped as part of V4 release train Cosmos
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kushagraThapar @milismsft