Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CosmosClientException APIs and Docs #11220

Closed
kushagraThapar opened this issue May 15, 2020 · 1 comment
Closed

CosmosClientException APIs and Docs #11220

kushagraThapar opened this issue May 15, 2020 · 1 comment
Assignees
@xinlian12
Labels
cosmos:v4-item Indicates this feature will be shipped as part of V4 release train Cosmos

Comments

@kushagraThapar
Copy link
Member

kushagraThapar commented May 15, 2020 •
edited
Loading

CosmosClientException -

  1. Rename it to CosmosException
  2. Remove throws CosmosClientException from public APIs.
  3. return HttpHeaders - getResponseHeaders ? (Covered Return HttpHeaders instead of Map<String, String> getResponseHeaders() #11222)

CosmosError - should not be exposed, move to implementation.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 15, 2020
@kushagraThapar kushagraThapar self-assigned this May 15, 2020
@kushagraThapar kushagraThapar added Cosmos cosmos:v4-item Indicates this feature will be shipped as part of V4 release train labels May 15, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 15, 2020
This was referenced May 15, 2020
Closed
Closed
@xinlian12
Copy link
Member

code merged.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@xinlian12 xinlian12

Labels
cosmos:v4-item Indicates this feature will be shipped as part of V4 release train Cosmos
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kushagraThapar @xinlian12