From 652424c90ca692885f85b7b64102a6e5d2439db9 Mon Sep 17 00:00:00 2001 From: Gauri Prasad <51212198+gapra-msft@users.noreply.github.com> Date: Wed, 16 Sep 2020 16:22:25 -0700 Subject: [PATCH] Fixed simple renames and doc issues from 74 (#15297) Co-authored-by: Gauri Prasad --- .../com/azure/storage/blob/models/BlobQueryArrowField.java | 6 ++++-- .../storage/blob/sas/BlobServiceSasSignatureValues.java | 3 ++- .../storage/file/datalake/DataLakePathAsyncClient.java | 6 +++--- .../com/azure/storage/file/datalake/DataLakePathClient.java | 6 +++--- .../storage/file/datalake/models/FileQueryArrowField.java | 6 ++++-- .../options/PathRemoveAccessControlRecursiveOptions.java | 2 +- .../options/PathSetAccessControlRecursiveOptions.java | 2 +- .../options/PathUpdateAccessControlRecursiveOptions.java | 2 +- .../datalake/sas/DataLakeServiceSasSignatureValues.java | 3 ++- 9 files changed, 21 insertions(+), 15 deletions(-) diff --git a/sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/models/BlobQueryArrowField.java b/sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/models/BlobQueryArrowField.java index 5607c56cbcead..300d3c111ca18 100644 --- a/sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/models/BlobQueryArrowField.java +++ b/sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/models/BlobQueryArrowField.java @@ -3,11 +3,13 @@ package com.azure.storage.blob.models; +import com.azure.core.annotation.Fluent; import com.azure.storage.common.implementation.StorageImplUtils; /** * Defines an arrow field for a blob quick query request. */ +@Fluent public class BlobQueryArrowField { private String name; @@ -36,7 +38,7 @@ public BlobQueryArrowField setName(String name) { * @param precision The precision of the field. Required if type is {@link BlobQueryArrowFieldType#DECIMAL} * @return The updated options. */ - public BlobQueryArrowField setPrecision(int precision) { + public BlobQueryArrowField setPrecision(Integer precision) { this.precision = precision; return this; } @@ -45,7 +47,7 @@ public BlobQueryArrowField setPrecision(int precision) { * @param scale The scale of the field. Required if type is {@link BlobQueryArrowFieldType#DECIMAL} * @return The updated options. */ - public BlobQueryArrowField setScale(int scale) { + public BlobQueryArrowField setScale(Integer scale) { this.scale = scale; return this; } diff --git a/sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/sas/BlobServiceSasSignatureValues.java b/sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/sas/BlobServiceSasSignatureValues.java index 00ad361e78cf6..fd561a92e2bae 100644 --- a/sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/sas/BlobServiceSasSignatureValues.java +++ b/sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/sas/BlobServiceSasSignatureValues.java @@ -177,7 +177,8 @@ public String getVersion() { * * @param version Version to target * @return the updated BlobServiceSASSignatureValues object - * @deprecated The version is set to the latest version of sas. + * @deprecated The version is set to the latest version of sas. Users should stop calling this API as it is now + * treated as a no-op. */ @Deprecated public BlobServiceSasSignatureValues setVersion(String version) { diff --git a/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakePathAsyncClient.java b/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakePathAsyncClient.java index 496c46439f5f8..6953326b20adf 100644 --- a/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakePathAsyncClient.java +++ b/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakePathAsyncClient.java @@ -696,7 +696,7 @@ public Mono> setAccessControlRecursiveWithRe return withContext(context -> setAccessControlRecursiveWithResponse( PathAccessControlEntry.serializeList(options.getAccessControlList()), options.getProgressHandler(), PathSetAccessControlRecursiveMode.SET, options.getBatchSize(), options.getMaxBatches(), - options.isContinuingOnFailure(), options.getContinuationToken(), context)); + options.isContinueOnFailure(), options.getContinuationToken(), context)); } catch (RuntimeException ex) { return monoError(logger, ex); } @@ -746,7 +746,7 @@ public Mono> updateAccessControlRecursiveWit return withContext(context -> setAccessControlRecursiveWithResponse( PathAccessControlEntry.serializeList(options.getAccessControlList()), options.getProgressHandler(), PathSetAccessControlRecursiveMode.MODIFY, options.getBatchSize(), options.getMaxBatches(), - options.isContinuingOnFailure(), options.getContinuationToken(), context)); + options.isContinueOnFailure(), options.getContinuationToken(), context)); } catch (RuntimeException ex) { return monoError(logger, ex); } @@ -796,7 +796,7 @@ public Mono> removeAccessControlRecursiveWit return withContext(context -> setAccessControlRecursiveWithResponse( PathRemoveAccessControlEntry.serializeList(options.getAccessControlList()), options.getProgressHandler(), PathSetAccessControlRecursiveMode.REMOVE, options.getBatchSize(), - options.getMaxBatches(), options.isContinuingOnFailure(), options.getContinuationToken(), context)); + options.getMaxBatches(), options.isContinueOnFailure(), options.getContinuationToken(), context)); } catch (RuntimeException ex) { return monoError(logger, ex); } diff --git a/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakePathClient.java b/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakePathClient.java index f8d50134b238d..425bbae656665 100644 --- a/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakePathClient.java +++ b/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakePathClient.java @@ -399,7 +399,7 @@ public Response setAccessControlRecursiveWithResponse dataLakePathAsyncClient.setAccessControlRecursiveWithResponse( PathAccessControlEntry.serializeList(options.getAccessControlList()), options.getProgressHandler(), PathSetAccessControlRecursiveMode.SET, options.getBatchSize(), options.getMaxBatches(), - options.isContinuingOnFailure(), options.getContinuationToken(), context); + options.isContinueOnFailure(), options.getContinuationToken(), context); return StorageImplUtils.blockWithOptionalTimeout(response, timeout); } @@ -443,7 +443,7 @@ public Response updateAccessControlRecursiveWithRespo dataLakePathAsyncClient.setAccessControlRecursiveWithResponse( PathAccessControlEntry.serializeList(options.getAccessControlList()), options.getProgressHandler(), PathSetAccessControlRecursiveMode.MODIFY, options.getBatchSize(), options.getMaxBatches(), - options.isContinuingOnFailure(), options.getContinuationToken(), context); + options.isContinueOnFailure(), options.getContinuationToken(), context); return StorageImplUtils.blockWithOptionalTimeout(response, timeout); } @@ -488,7 +488,7 @@ public Response removeAccessControlRecursiveWithRespo dataLakePathAsyncClient.setAccessControlRecursiveWithResponse( PathRemoveAccessControlEntry.serializeList(options.getAccessControlList()), options.getProgressHandler(), PathSetAccessControlRecursiveMode.REMOVE, options.getBatchSize(), - options.getMaxBatches(), options.isContinuingOnFailure(), options.getContinuationToken(), context); + options.getMaxBatches(), options.isContinueOnFailure(), options.getContinuationToken(), context); return StorageImplUtils.blockWithOptionalTimeout(response, timeout); } diff --git a/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/models/FileQueryArrowField.java b/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/models/FileQueryArrowField.java index 105e6ca947a8e..119c08a0184bf 100644 --- a/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/models/FileQueryArrowField.java +++ b/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/models/FileQueryArrowField.java @@ -3,11 +3,13 @@ package com.azure.storage.file.datalake.models; +import com.azure.core.annotation.Fluent; import com.azure.storage.common.implementation.StorageImplUtils; /** * Defines an arrow field for a file quick query request. */ +@Fluent public class FileQueryArrowField { private String name; @@ -36,7 +38,7 @@ public FileQueryArrowField setName(String name) { * @param precision The precision of the field. Required if type is {@link FileQueryArrowFieldType#DECIMAL} * @return The updated options. */ - public FileQueryArrowField setPrecision(int precision) { + public FileQueryArrowField setPrecision(Integer precision) { this.precision = precision; return this; } @@ -45,7 +47,7 @@ public FileQueryArrowField setPrecision(int precision) { * @param scale The scale of the field. Required if type is {@link FileQueryArrowFieldType#DECIMAL} * @return The updated options. */ - public FileQueryArrowField setScale(int scale) { + public FileQueryArrowField setScale(Integer scale) { this.scale = scale; return this; } diff --git a/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/options/PathRemoveAccessControlRecursiveOptions.java b/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/options/PathRemoveAccessControlRecursiveOptions.java index 462dcc30bfb7a..d8361c20a93b8 100644 --- a/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/options/PathRemoveAccessControlRecursiveOptions.java +++ b/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/options/PathRemoveAccessControlRecursiveOptions.java @@ -145,7 +145,7 @@ public PathRemoveAccessControlRecursiveOptions setContinuationToken(String conti * * @return If the operation should continue on user failure. */ - public boolean isContinuingOnFailure() { + public boolean isContinueOnFailure() { return continueOnFailure; } diff --git a/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/options/PathSetAccessControlRecursiveOptions.java b/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/options/PathSetAccessControlRecursiveOptions.java index 2b075f6f03169..d96bfc85a9699 100644 --- a/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/options/PathSetAccessControlRecursiveOptions.java +++ b/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/options/PathSetAccessControlRecursiveOptions.java @@ -145,7 +145,7 @@ public PathSetAccessControlRecursiveOptions setContinuationToken(String continua * * @return If the operation should continue on user failure. */ - public boolean isContinuingOnFailure() { + public boolean isContinueOnFailure() { return continueOnFailure; } diff --git a/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/options/PathUpdateAccessControlRecursiveOptions.java b/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/options/PathUpdateAccessControlRecursiveOptions.java index 709328596b8aa..b1f41dfe06b16 100644 --- a/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/options/PathUpdateAccessControlRecursiveOptions.java +++ b/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/options/PathUpdateAccessControlRecursiveOptions.java @@ -145,7 +145,7 @@ public PathUpdateAccessControlRecursiveOptions setContinuationToken(String conti * * @return If the operation should continue on user failure. */ - public boolean isContinuingOnFailure() { + public boolean isContinueOnFailure() { return continueOnFailure; } diff --git a/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/sas/DataLakeServiceSasSignatureValues.java b/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/sas/DataLakeServiceSasSignatureValues.java index bc1bc0b155c5d..2d6da2bf1699a 100644 --- a/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/sas/DataLakeServiceSasSignatureValues.java +++ b/sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/sas/DataLakeServiceSasSignatureValues.java @@ -106,7 +106,8 @@ public String getVersion() { * * @param version Version to target * @return the updated DataLakeServiceSasSignatureValues object - * @deprecated The version is set to the latest version of sas. + * @deprecated The version is set to the latest version of sas. Users should stop calling this API as it is now + * treated as a no-op. */ @Deprecated public DataLakeServiceSasSignatureValues setVersion(String version) {