Fixed simple renames and doc issues from 74 (#15297)

Co-authored-by: Gauri Prasad <[email protected]>
Azure · Sep 16, 2020 · 652424c · 652424c
1 parent 70bd409
commit 652424c
Show file tree

Hide file tree

Showing 9 changed files with 21 additions and 15 deletions.
diff --git a/...e/azure-storage-blob/src/main/java/com/azure/storage/blob/models/BlobQueryArrowField.java b/...e/azure-storage-blob/src/main/java/com/azure/storage/blob/models/BlobQueryArrowField.java
@@ -3,11 +3,13 @@
 
 package com.azure.storage.blob.models;
 
+import com.azure.core.annotation.Fluent;
 import com.azure.storage.common.implementation.StorageImplUtils;
 
 /**
  * Defines an arrow field for a blob quick query request.
  */
+@Fluent
 public class BlobQueryArrowField {
 
     private String name;
@@ -36,7 +38,7 @@ public BlobQueryArrowField setName(String name) {
      * @param precision The precision of the field. Required if type is {@link BlobQueryArrowFieldType#DECIMAL}
      * @return The updated options.
      */
-    public BlobQueryArrowField setPrecision(int precision) {
+    public BlobQueryArrowField setPrecision(Integer precision) {
         this.precision = precision;
         return this;
     }
@@ -45,7 +47,7 @@ public BlobQueryArrowField setPrecision(int precision) {
      * @param scale The scale of the field. Required if type is {@link BlobQueryArrowFieldType#DECIMAL}
      * @return The updated options.
      */
-    public BlobQueryArrowField setScale(int scale) {
+    public BlobQueryArrowField setScale(Integer scale) {
         this.scale = scale;
         return this;
     }

diff --git a/...-storage-blob/src/main/java/com/azure/storage/blob/sas/BlobServiceSasSignatureValues.java b/...-storage-blob/src/main/java/com/azure/storage/blob/sas/BlobServiceSasSignatureValues.java
@@ -177,7 +177,8 @@ public String getVersion() {
      *
      * @param version Version to target
      * @return the updated BlobServiceSASSignatureValues object
-     * @deprecated The version is set to the latest version of sas.
+     * @deprecated The version is set to the latest version of sas. Users should stop calling this API as it is now
+     * treated as a no-op.
      */
     @Deprecated
     public BlobServiceSasSignatureValues setVersion(String version) {

diff --git a/...-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakePathAsyncClient.java b/...-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakePathAsyncClient.java
@@ -696,7 +696,7 @@ public Mono<Response<AccessControlChangeResult>> setAccessControlRecursiveWithRe
             return withContext(context -> setAccessControlRecursiveWithResponse(
                 PathAccessControlEntry.serializeList(options.getAccessControlList()), options.getProgressHandler(),
                 PathSetAccessControlRecursiveMode.SET, options.getBatchSize(), options.getMaxBatches(),
-                options.isContinuingOnFailure(), options.getContinuationToken(), context));
+                options.isContinueOnFailure(), options.getContinuationToken(), context));
         } catch (RuntimeException ex) {
             return monoError(logger, ex);
         }
@@ -746,7 +746,7 @@ public Mono<Response<AccessControlChangeResult>> updateAccessControlRecursiveWit
             return withContext(context -> setAccessControlRecursiveWithResponse(
                 PathAccessControlEntry.serializeList(options.getAccessControlList()), options.getProgressHandler(),
                 PathSetAccessControlRecursiveMode.MODIFY, options.getBatchSize(), options.getMaxBatches(),
-                options.isContinuingOnFailure(), options.getContinuationToken(), context));
+                options.isContinueOnFailure(), options.getContinuationToken(), context));
         } catch (RuntimeException ex) {
             return monoError(logger, ex);
         }
@@ -796,7 +796,7 @@ public Mono<Response<AccessControlChangeResult>> removeAccessControlRecursiveWit
             return withContext(context -> setAccessControlRecursiveWithResponse(
                 PathRemoveAccessControlEntry.serializeList(options.getAccessControlList()),
                 options.getProgressHandler(), PathSetAccessControlRecursiveMode.REMOVE, options.getBatchSize(),
-                options.getMaxBatches(), options.isContinuingOnFailure(), options.getContinuationToken(), context));
+                options.getMaxBatches(), options.isContinueOnFailure(), options.getContinuationToken(), context));
         } catch (RuntimeException ex) {
             return monoError(logger, ex);
         }

diff --git a/...orage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakePathClient.java b/...orage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakePathClient.java
@@ -399,7 +399,7 @@ public Response<AccessControlChangeResult> setAccessControlRecursiveWithResponse
             dataLakePathAsyncClient.setAccessControlRecursiveWithResponse(
                 PathAccessControlEntry.serializeList(options.getAccessControlList()), options.getProgressHandler(),
                 PathSetAccessControlRecursiveMode.SET, options.getBatchSize(), options.getMaxBatches(),
-                options.isContinuingOnFailure(), options.getContinuationToken(), context);
+                options.isContinueOnFailure(), options.getContinuationToken(), context);
 
         return StorageImplUtils.blockWithOptionalTimeout(response, timeout);
     }
@@ -443,7 +443,7 @@ public Response<AccessControlChangeResult> updateAccessControlRecursiveWithRespo
             dataLakePathAsyncClient.setAccessControlRecursiveWithResponse(
                 PathAccessControlEntry.serializeList(options.getAccessControlList()), options.getProgressHandler(),
                 PathSetAccessControlRecursiveMode.MODIFY, options.getBatchSize(), options.getMaxBatches(),
-                options.isContinuingOnFailure(), options.getContinuationToken(), context);
+                options.isContinueOnFailure(), options.getContinuationToken(), context);
 
         return StorageImplUtils.blockWithOptionalTimeout(response, timeout);
     }
@@ -488,7 +488,7 @@ public Response<AccessControlChangeResult> removeAccessControlRecursiveWithRespo
             dataLakePathAsyncClient.setAccessControlRecursiveWithResponse(
                 PathRemoveAccessControlEntry.serializeList(options.getAccessControlList()),
                 options.getProgressHandler(), PathSetAccessControlRecursiveMode.REMOVE, options.getBatchSize(),
-                options.getMaxBatches(), options.isContinuingOnFailure(), options.getContinuationToken(), context);
+                options.getMaxBatches(), options.isContinueOnFailure(), options.getContinuationToken(), context);
 
         return StorageImplUtils.blockWithOptionalTimeout(response, timeout);
     }

diff --git a/...le-datalake/src/main/java/com/azure/storage/file/datalake/models/FileQueryArrowField.java b/...le-datalake/src/main/java/com/azure/storage/file/datalake/models/FileQueryArrowField.java
@@ -3,11 +3,13 @@
 
 package com.azure.storage.file.datalake.models;
 
+import com.azure.core.annotation.Fluent;
 import com.azure.storage.common.implementation.StorageImplUtils;
 
 /**
  * Defines an arrow field for a file quick query request.
  */
+@Fluent
 public class FileQueryArrowField {
 
     private String name;
@@ -36,7 +38,7 @@ public FileQueryArrowField setName(String name) {
      * @param precision The precision of the field. Required if type is {@link FileQueryArrowFieldType#DECIMAL}
      * @return The updated options.
      */
-    public FileQueryArrowField setPrecision(int precision) {
+    public FileQueryArrowField setPrecision(Integer precision) {
         this.precision = precision;
         return this;
     }
@@ -45,7 +47,7 @@ public FileQueryArrowField setPrecision(int precision) {
      * @param scale The scale of the field. Required if type is {@link FileQueryArrowFieldType#DECIMAL}
      * @return The updated options.
      */
-    public FileQueryArrowField setScale(int scale) {
+    public FileQueryArrowField setScale(Integer scale) {
         this.scale = scale;
         return this;
     }

diff --git a/...java/com/azure/storage/file/datalake/options/PathRemoveAccessControlRecursiveOptions.java b/...java/com/azure/storage/file/datalake/options/PathRemoveAccessControlRecursiveOptions.java
@@ -145,7 +145,7 @@ public PathRemoveAccessControlRecursiveOptions setContinuationToken(String conti
      *
      * @return If the operation should continue on user failure.
      */
-    public boolean isContinuingOnFailure() {
+    public boolean isContinueOnFailure() {
         return continueOnFailure;
     }
 

diff --git a/...in/java/com/azure/storage/file/datalake/options/PathSetAccessControlRecursiveOptions.java b/...in/java/com/azure/storage/file/datalake/options/PathSetAccessControlRecursiveOptions.java
@@ -145,7 +145,7 @@ public PathSetAccessControlRecursiveOptions setContinuationToken(String continua
      *
      * @return If the operation should continue on user failure.
      */
-    public boolean isContinuingOnFailure() {
+    public boolean isContinueOnFailure() {
         return continueOnFailure;
     }
 

diff --git a/...java/com/azure/storage/file/datalake/options/PathUpdateAccessControlRecursiveOptions.java b/...java/com/azure/storage/file/datalake/options/PathUpdateAccessControlRecursiveOptions.java
@@ -145,7 +145,7 @@ public PathUpdateAccessControlRecursiveOptions setContinuationToken(String conti
      *
      * @return If the operation should continue on user failure.
      */
-    public boolean isContinuingOnFailure() {
+    public boolean isContinueOnFailure() {
         return continueOnFailure;
     }
 

diff --git a/.../src/main/java/com/azure/storage/file/datalake/sas/DataLakeServiceSasSignatureValues.java b/.../src/main/java/com/azure/storage/file/datalake/sas/DataLakeServiceSasSignatureValues.java
@@ -106,7 +106,8 @@ public String getVersion() {
      *
      * @param version Version to target
      * @return the updated DataLakeServiceSasSignatureValues object
-     * @deprecated The version is set to the latest version of sas.
+     * @deprecated The version is set to the latest version of sas. Users should stop calling this API as it is now
+     * treated as a no-op.
      */
     @Deprecated
     public DataLakeServiceSasSignatureValues setVersion(String version) {