Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update custom_client.go to enable insecure credential with HTTP #23188

Merged
merged 2 commits into from
Jul 16, 2024
Merged

chore: Update custom_client.go to enable insecure credential with HTTP #23188

merged 2 commits into from
Jul 16, 2024

Conversation

ukrocks007
Copy link
Contributor

@ukrocks007 ukrocks007 commented Jul 15, 2024 •
edited
Loading

This PR enables InsecureAllowCredentialWithHTTP option for ai sdk custom_client

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to module CHANGELOG.md are included.
  • MIT license headers are included in each file.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Jul 15, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution @ukrocks007! We will review the pull request and get back to you soon.

@ukrocks007
Copy link
Contributor Author

ukrocks007 commented Jul 15, 2024 •
edited
Loading

@microsoft-github-policy-service agree company="BoxyHQ"

1 similar comment
@ukrocks007
Copy link
Contributor Author

@microsoft-github-policy-service agree company="BoxyHQ"

@ukrocks007 ukrocks007 marked this pull request as ready for review July 15, 2024 15:05
@richardpark-msft
Copy link
Member

/check-enforcer override

@richardpark-msft richardpark-msft merged commit 5df73f9 into Azure:main Jul 16, 2024
20 checks passed
@richardpark-msft
Copy link
Member

@ukrocks007, thank you for your contribution! I am interested - when do you disable the secure auth? The cases I'm aware of - using a proxy, using some form of "emulator/pass through" (usually homegrown).

@ukrocks007
Copy link
Contributor Author

@ukrocks007, thank you for your contribution! I am interested - when do you disable the secure auth? The cases I'm aware of - using a proxy, using some form of "emulator/pass through" (usually homegrown).

It is for a proxy solution, and the endpoint is open ended so it is possible that endpoint can be http.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardpark-msft richardpark-msft richardpark-msft approved these changes

@jhendrixMSFT jhendrixMSFT Awaiting requested review from jhendrixMSFT jhendrixMSFT is a code owner

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner

Assignees
No one assigned
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ukrocks007 @richardpark-msft