Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Container Registry SDK #6971

Closed
juliusl opened this issue Jan 16, 2020 · 6 comments
Closed

Update Container Registry SDK #6971

juliusl opened this issue Jan 16, 2020 · 6 comments

Comments

@juliusl
Copy link
Member

juliusl commented Jan 16, 2020

Service Package Request

Hi I'm from ACR. I need to update our Container Registry SDK with the latest Swagger spec.

Creating this issue for tracking and discussion.

Is there an automated pipeline to get the new generated files or do I need to do this manually and submit a PR?

@ArcturusZhang
Copy link
Member

Hi @juliusl thanks for this issue!
There is a automated pipeline for the SDK generation now.
For service package request from microsoft employees, please go to the open api hub to submit a package request.
I notice that this api-version does not have a tag in the readme.go.md, therefore i will first submit a PR to add that missing tag for the 2019-08-15 api-version, then you can fill the release request on open api hub and targeting to that PR.
Meanwhile, go SDK has a routine monthly major release, which will generate and release all valid swagger in the spec repo. Therefore wait for the major release (which will happen by the end of this month) is also an option for you.

@ArcturusZhang
Copy link
Member

Hi @juliusl I have submitted a PR for this.
Please submit the release request after this PR get merged.
Or wait for the end of month's major release also works.

@juliusl
Copy link
Member Author

juliusl commented Jan 16, 2020

@ArcturusZhang Thanks!

@juliusl juliusl closed this as completed Jan 16, 2020
@juliusl juliusl reopened this Jan 16, 2020
@juliusl
Copy link
Member Author

juliusl commented Jan 16, 2020

(@ArcturusZhang the open api hub link you have in your comment is broken)

@ArcturusZhang
Copy link
Member

(@ArcturusZhang the open api hub link you have in your comment is broken)

My bad. It should be https://aka.ms/openapihub

@ArcturusZhang ArcturusZhang mentioned this issue Jan 17, 2020
6 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants