Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyVault - Bad data types used for ints #587

Closed
khenidak opened this issue Apr 12, 2017 · 3 comments
Closed

KeyVault - Bad data types used for ints #587

khenidak opened this issue Apr 12, 2017 · 3 comments
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved.
Milestone

Comments

@khenidak
Copy link

khenidak commented Apr 12, 2017

the values for NotBefore, Created and Updates are incorrect and cause unmarshmaling errors here. They should be json.Number

Edit: This apply on SecretBundle:SecretAttributes & KeyBundle:KeyAttributes
Edit #2: also applies on CertificateBundle

@marstr marstr self-assigned this Apr 14, 2017
@marstr marstr added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Apr 14, 2017
@marstr
Copy link
Member

marstr commented Apr 18, 2017

At the moment, it looks like our generator doesn't support "unixtime" format when it is seen in Swagger. (The defintions in question can be found here: Azure/azure-rest-api-specs/keyvault/2015-06-01/swagger/keyvault.json) When that happens, we bomb out into strings to support the broadest set of data types. As you point out, that can cause marshaling issues.

To get around these issues, I'm adding support into Azure/go-autorest for the UnixTime. Once that PR is accepted, I'll replace this line in the generator with the newly created type.

@marstr marstr added this to the v10.0.0-beta milestone Apr 18, 2017
@marstr
Copy link
Member

marstr commented May 4, 2017

This is fixed in #602

@marstr
Copy link
Member

marstr commented May 4, 2017

Thanks for bringing this to our attention @khenidak! I believe I have it fixed.

@marstr marstr closed this as completed May 4, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved.
Projects
None yet
Development

No branches or pull requests

2 participants