Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azeventgrid] CloudEvent v2 design - ease of use, confusion of types #21289

Closed
richardpark-msft opened this issue Jul 29, 2023 · 1 comment
Closed

[azeventgrid] CloudEvent v2 design - ease of use, confusion of types #21289

richardpark-msft opened this issue Jul 29, 2023 · 1 comment
Assignees
@richardpark-msft
Labels
Client This issue points to a problem in the data-plane of the library. design-discussion An area of design currently under discussion and open to team and community feedback. Event Grid Event Hubs
Milestone
2023-10

Comments

@richardpark-msft
Copy link
Member

@jhendrixMSFT brought this up in #21282, and it sparks some other conversations about the type that I think are worth talking about.

Some things I want to look at:

  1. Can we make it so CloudEvent validity checking is done later so you don't have to have to have error handling code just to generate a CloudEvent? Right now the constructor for CloudEvent can return an error because uuid.New can return an error - not the greatest experience.
  2. Do we need to hide DataBase64? Currently Data is doing double-duty because of it - we're allowing you to pass a []byte (to signal 'binary encoding') and also any other struct/JSON-serializable value.
@richardpark-msft richardpark-msft self-assigned this Jul 29, 2023
@richardpark-msft richardpark-msft added Event Grid Client This issue points to a problem in the data-plane of the library. labels Jul 29, 2023
@richardpark-msft richardpark-msft added this to the 2023-08 milestone Jul 29, 2023
@github-actions github-actions bot added Event Hubs needs-team-triage Workflow: This issue needs the team to triage. labels Jul 29, 2023
@richardpark-msft richardpark-msft mentioned this issue Jul 29, 2023
Merged
@jhendrixMSFT jhendrixMSFT added design-discussion An area of design currently under discussion and open to team and community feedback. and removed needs-team-triage Workflow: This issue needs the team to triage. labels Jul 31, 2023
@RickWinter RickWinter modified the milestones: 2023-08, 2023-10 Aug 29, 2023
@richardpark-msft
Copy link
Member Author

We've shipped this type officially.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@richardpark-msft richardpark-msft

Labels
Client This issue points to a problem in the data-plane of the library. design-discussion An area of design currently under discussion and open to team and community feedback. Event Grid Event Hubs
Projects
None yet
Milestone
2023-10
Development

No branches or pull requests
3 participants
@RickWinter @jhendrixMSFT @richardpark-msft