Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service-bus] MessageID is required to be set (internal investigation only) #15563

Closed
richardpark-msft opened this issue Sep 15, 2021 · 4 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus

Comments

@richardpark-msft
Copy link
Member

richardpark-msft commented Sep 15, 2021

This is just a running list of small things that we should look into.

Some fields appear to be required in our stack, that are optional (from what I can tell) in others:

  • MessageID is required to be set (not sure where in the stack this is failing). I believe this field is supposed to be optional - currently we fill this out on behalf of the user if they do not.
@richardpark-msft richardpark-msft added Service Bus Client This issue points to a problem in the data-plane of the library. labels Sep 15, 2021
@richardpark-msft richardpark-msft added this to the [2021] November milestone Sep 15, 2021
@richardpark-msft richardpark-msft self-assigned this Sep 15, 2021
@richardpark-msft
Copy link
Member Author

Draft PR in the go-amqp repo showing what the underlying change would be for an empty session ID (among other optional fields): Azure/go-amqp#93

@richardpark-msft
Copy link
Member Author

Draft PR went in! PR incorporating that into azservicebus here: #16530

@richardpark-msft richardpark-msft changed the title [service-bus] Minor investigations [service-bus] MessageID is required to be set (internal investigation only) Jan 27, 2022
@richardpark-msft
Copy link
Member Author

Moving to backlog. The key issue here was the session ID, which should have been allowed to be the empty string. That fix has been rolled into go-amqp and having to specify a MessageID, while interesting, is not customer affecting.

@richardpark-msft
Copy link
Member Author

Closing, this isn't a question we need to answer.

@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2023
@RickWinter RickWinter removed this from the Backlog milestone Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Development

No branches or pull requests

2 participants