Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

containerservice.ManagedClusterPropertiesAutoScalerProfile (AKS) does not accept some duration values which are otherwise valid #14311

Closed
krishna-birla opened this issue Feb 16, 2021 · 5 comments
Closed

containerservice.ManagedClusterPropertiesAutoScalerProfile (AKS) does not accept some duration values which are otherwise valid #14311

krishna-birla opened this issue Feb 16, 2021 · 5 comments
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Container Service customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team. Service This issue points to a problem in the service.

Comments

@krishna-birla
Copy link

krishna-birla commented Feb 16, 2021 •
edited
Loading

Bug Report

  • github.com/Azure/azure-sdk-for-go/profiles/latest/containerservice/mgmt/containerservice
  • [email protected]+incompatible
    • Specify the exact commit if possible; one way to get this is the REVISION
      column output by dep status "github.com/Azure/azure-sdk-for-go.
  • go version go1.15.6 darwin/amd64
  • What is the error? -> containerservice.ManagedClusterPropertiesAutoScalerProfile.ScanInterval = &("1m") throws an error: "containerservice.ManagedClustersClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="InvalidParameter" Message="Invalid value specified for the cluster-autoscaler parameter 'scan-interval'. Please refer to https://aka.ms/cluster-autoscaler for more details."
  • What is expected? -> Cluster creation should pass.
  • How to reproduce? -> Create AKS cluster with containerservice.ManagedClusterPropertiesAutoScalerProfile.ScanInterval = &("1m")

Extra observations

containerservice.ManagedClusterPropertiesAutoScalerProfile.ScanInterval = &("1m") fails but containerservice.ManagedClusterPropertiesAutoScalerProfile.ScanInterval = &("60s") passes.

Similar issues exist with other fields, for example:

containerservice.ManagedClusterPropertiesAutoScalerProfile.ScaleDownDelayAfterFailure = &("3m30s") throws an error: "containerservice.ManagedClustersClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="InvalidParameter" Message="Invalid value specified for the cluster-autoscaler parameter 'scale-down-delay-after-failure'. Please refer to https://aka.ms/cluster-autoscaler for more details." even though it is a valid value.

Similarly:

containerservice.ManagedClusterPropertiesAutoScalerProfile.ScaleDownDelayAfterFailure = &("180s") throws an error: "containerservice.ManagedClustersClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="InvalidParameter" Message="Invalid value specified for the cluster-autoscaler parameter 'scale-down-delay-after-failure'. Please refer to https://aka.ms/cluster-autoscaler for more details."

but

containerservice.ManagedClusterPropertiesAutoScalerProfile.ScaleDownDelayAfterFailure = &("3m") passes.
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Feb 16, 2021
@ArcturusZhang
Copy link
Member

Hi @krishna-birla thanks for this issue!

This sounds like an API issue rather than the SDK itself. Therefore I have tagged this issue so that the corresponding service team could have a look at this.

@ArcturusZhang ArcturusZhang added bug This issue requires a change to an existing behavior in the product in order to be resolved. Container Service Service Attention Workflow: This issue is responsible by Azure service team. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Feb 22, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 22, 2021
@ghost
Copy link

ghost commented Feb 22, 2021

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @qike-ms, @jwilder, @thomas1206, @seanmck.

Issue Details

Bug Report

  • github.com/Azure/azure-sdk-for-go/profiles/latest/containerservice/mgmt/containerservice
  • [email protected]+incompatible
    • Specify the exact commit if possible; one way to get this is the REVISION
      column output by dep status "github.com/Azure/azure-sdk-for-go.
  • go version go1.15.6 darwin/amd64
  • What is the error? -> containerservice.ManagedClusterPropertiesAutoScalerProfile.ScanInterval = &("1m") throws an error: "containerservice.ManagedClustersClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="InvalidParameter" Message="Invalid value specified for the cluster-autoscaler parameter 'scan-interval'. Please refer to https://aka.ms/cluster-autoscaler for more details."
  • What is expected? -> Cluster creation should pass.
  • How to reproduce? -> Create AKS cluster with containerservice.ManagedClusterPropertiesAutoScalerProfile.ScanInterval = &("1m")

Extra observations

containerservice.ManagedClusterPropertiesAutoScalerProfile.ScanInterval = &("1m") fails but containerservice.ManagedClusterPropertiesAutoScalerProfile.ScanInterval = &("60s") passes.

Similar issues exist with other fields, for example:

containerservice.ManagedClusterPropertiesAutoScalerProfile.ScaleDownDelayAfterFailure = &("3m30s") throws an error: "containerservice.ManagedClustersClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="InvalidParameter" Message="Invalid value specified for the cluster-autoscaler parameter 'scale-down-delay-after-failure'. Please refer to https://aka.ms/cluster-autoscaler for more details." even though it is a valid value.

Similarly:

containerservice.ManagedClusterPropertiesAutoScalerProfile.ScaleDownDelayAfterFailure = &("180s") throws an error: "containerservice.ManagedClustersClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="InvalidParameter" Message="Invalid value specified for the cluster-autoscaler parameter 'scale-down-delay-after-failure'. Please refer to https://aka.ms/cluster-autoscaler for more details."

but

containerservice.ManagedClusterPropertiesAutoScalerProfile.ScaleDownDelayAfterFailure = &("3m") passes.

Author: krishna-birla
Assignees: -
Labels:

Container Service, Service Attention, bug, customer-reported, needs-triage
Milestone: -

@krishna-birla
Copy link
Author

krishna-birla commented Feb 23, 2021 •
edited
Loading

Thanks @ArcturusZhang

Yes, this is an API issue where wrong validations are taking place. I did not know where to raise API bugs, so I created an issue in SDK repo.

@RickWinter RickWinter added the Service This issue points to a problem in the service. label Sep 13, 2021
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Sep 13, 2021
@RickWinter
Copy link
Member

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @qike-ms, @jwilder, @thomas1206, @seanmck.

Issue Details

Any update?

@RickWinter RickWinter added this to the 2022-10 milestone Sep 1, 2022
@RickWinter RickWinter modified the milestones: 2022-10, 2023-04 Jan 10, 2023
@RickWinter RickWinter removed this from the 2023-04 milestone Aug 29, 2023
@github-actions GitHub Actions
Copy link

Hi @krishna-birla, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Container Service customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team. Service This issue points to a problem in the service.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RickWinter @ArcturusZhang @krishna-birla