From 8b31b0bf4adef82bd4f8daa588be8463680923a5 Mon Sep 17 00:00:00 2001 From: sima-zhu Date: Thu, 15 Dec 2022 16:21:23 -0800 Subject: [PATCH 1/8] Give the csv flexibility to onboard not new package to Docs.Ms --- eng/common/scripts/Update-DocsMsPackages.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/common/scripts/Update-DocsMsPackages.ps1 b/eng/common/scripts/Update-DocsMsPackages.ps1 index ab7f54dcea..ccd531d3bd 100644 --- a/eng/common/scripts/Update-DocsMsPackages.ps1 +++ b/eng/common/scripts/Update-DocsMsPackages.ps1 @@ -80,7 +80,7 @@ function GetDocsMetadataForMoniker($moniker) { } function GetDocsMetadata() { # Read metadata from CSV - $csvMetadata = (Get-CSVMetadata).Where({ $_.New -eq 'true' -and $_.Hide -ne 'true' }) + $csvMetadata = (Get-CSVMetadata).Where({ ($_.New -eq 'true' -or $_.MSDocService -ne '') -and $_.Hide -ne 'true'}) # Read metadata from docs repo $metadataByPackage = @{} From a79f10697739887e9bd887aa42c80830e3662fd9 Mon Sep 17 00:00:00 2001 From: sima-zhu Date: Fri, 16 Dec 2022 10:41:39 -0800 Subject: [PATCH 2/8] Use placeholder if the accurate msservice not decided yet --- eng/common/scripts/Update-DocsMsMetadata.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/common/scripts/Update-DocsMsMetadata.ps1 b/eng/common/scripts/Update-DocsMsMetadata.ps1 index b6b696758a..c51dc11851 100644 --- a/eng/common/scripts/Update-DocsMsMetadata.ps1 +++ b/eng/common/scripts/Update-DocsMsMetadata.ps1 @@ -81,7 +81,7 @@ function GetAdjustedReadmeContent($ReadmeContent, $PackageInfo, $PackageMetadata # The $PackageMetadata could be $null if there is no associated metadata entry # based on how the metadata CSV is filtered $service = $PackageInfo.ServiceDirectory.ToLower() - if ($PackageMetadata -and $PackageMetadata.MSDocService) { + if ($PackageMetadata -and $PackageMetadata.MSDocService -and 'placeholder' -ine $PackageMetadata.MSDocService) { # Use MSDocService in csv metadata to override the service directory # TODO: Use taxonomy for service name -- https://github.com/Azure/azure-sdk-tools/issues/1442 $service = $PackageMetadata.MSDocService From 4c41b3eb0b95acc0c57d25cd19066b01d5b4f520 Mon Sep 17 00:00:00 2001 From: sima-zhu Date: Fri, 16 Dec 2022 11:12:42 -0800 Subject: [PATCH 3/8] add deprecated message to display name --- eng/common/scripts/Helpers/Package-Helpers.ps1 | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/eng/common/scripts/Helpers/Package-Helpers.ps1 b/eng/common/scripts/Helpers/Package-Helpers.ps1 index 15a1f2ea8d..dc467a0ad9 100644 --- a/eng/common/scripts/Helpers/Package-Helpers.ps1 +++ b/eng/common/scripts/Helpers/Package-Helpers.ps1 @@ -35,3 +35,12 @@ function GetPackageKey($pkg) { } return $packageLookup } + + fucntion GetDocsTocDisplayName($pkg) { + $displayName = $pkg.DisplayName + if ('deprecated' -eq $pkg.Support) { + LogWarning "The pkg $($pkg.Package) is deprecated. Add 'deprecated' besides of display name." + $diaplayName += " (deprecated)" + } + return $displayName + } \ No newline at end of file From c2f54085dad3bf177cc64c991bd4d5645d41ffbf Mon Sep 17 00:00:00 2001 From: sima-zhu Date: Fri, 16 Dec 2022 11:14:02 -0800 Subject: [PATCH 4/8] reformat --- .../scripts/Helpers/Package-Helpers.ps1 | 79 ++++++++++--------- 1 file changed, 40 insertions(+), 39 deletions(-) diff --git a/eng/common/scripts/Helpers/Package-Helpers.ps1 b/eng/common/scripts/Helpers/Package-Helpers.ps1 index dc467a0ad9..5a734c67d5 100644 --- a/eng/common/scripts/Helpers/Package-Helpers.ps1 +++ b/eng/common/scripts/Helpers/Package-Helpers.ps1 @@ -1,46 +1,47 @@ function GetPackageKey($pkg) { - $pkgKey = $pkg.Package - $groupId = $null - - if ($pkg.PSObject.Members.Name -contains "GroupId") { - $groupId = $pkg.GroupId - } - - if ($groupId) { - $pkgKey = "${groupId}:${pkgKey}" - } - - return $pkgKey + $pkgKey = $pkg.Package + $groupId = $null + + if ($pkg.PSObject.Members.Name -contains "GroupId") { + $groupId = $pkg.GroupId } + + if ($groupId) { + $pkgKey = "${groupId}:${pkgKey}" + } + + return $pkgKey +} - # Different language needs a different way to index the package. Build a map in convienice to lookup the package. - # E.g. : is the package key in java. - function GetPackageLookup($packageList) { - $packageLookup = @{} - - foreach ($pkg in $packageList) { - $pkgKey = GetPackageKey $pkg - - # We want to prefer updating non-hidden packages but if there is only - # a hidden entry then we will return that - if (!$packageLookup.ContainsKey($pkgKey) -or $packageLookup[$pkgKey].Hide -eq "true") { - $packageLookup[$pkgKey] = $pkg - } - else { - # Warn if there are more then one non-hidden package - if ($pkg.Hide -ne "true") { - Write-Host "Found more than one package entry for $($pkg.Package) selecting the first non-hidden one." - } +# Different language needs a different way to index the package. Build a map in convienice to lookup the package. +# E.g. : is the package key in java. +function GetPackageLookup($packageList) { + $packageLookup = @{} + + foreach ($pkg in $packageList) { + $pkgKey = GetPackageKey $pkg + + # We want to prefer updating non-hidden packages but if there is only + # a hidden entry then we will return that + if (!$packageLookup.ContainsKey($pkgKey) -or $packageLookup[$pkgKey].Hide -eq "true") { + $packageLookup[$pkgKey] = $pkg + } + else { + # Warn if there are more then one non-hidden package + if ($pkg.Hide -ne "true") { + Write-Host "Found more than one package entry for $($pkg.Package) selecting the first non-hidden one." } } - return $packageLookup } + return $packageLookup +} - fucntion GetDocsTocDisplayName($pkg) { - $displayName = $pkg.DisplayName - if ('deprecated' -eq $pkg.Support) { - LogWarning "The pkg $($pkg.Package) is deprecated. Add 'deprecated' besides of display name." - $diaplayName += " (deprecated)" - } - return $displayName - } \ No newline at end of file +# For deprecated packages, add "(deprecated)" besides of display name. +fucntion GetDocsTocDisplayName($pkg) { + $displayName = $pkg.DisplayName + if ('deprecated' -eq $pkg.Support) { + LogWarning "The pkg $($pkg.Package) is deprecated. Add 'deprecated' besides of display name." + $diaplayName += " (deprecated)" + } + return $displayName +} \ No newline at end of file From 85397988c6b7fa4be315f5d88a57be6660892253 Mon Sep 17 00:00:00 2001 From: sima-zhu Date: Fri, 16 Dec 2022 11:59:20 -0800 Subject: [PATCH 5/8] typo --- eng/common/scripts/Helpers/Package-Helpers.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/common/scripts/Helpers/Package-Helpers.ps1 b/eng/common/scripts/Helpers/Package-Helpers.ps1 index 5a734c67d5..325dc4e482 100644 --- a/eng/common/scripts/Helpers/Package-Helpers.ps1 +++ b/eng/common/scripts/Helpers/Package-Helpers.ps1 @@ -37,7 +37,7 @@ function GetPackageLookup($packageList) { } # For deprecated packages, add "(deprecated)" besides of display name. -fucntion GetDocsTocDisplayName($pkg) { +function GetDocsTocDisplayName($pkg) { $displayName = $pkg.DisplayName if ('deprecated' -eq $pkg.Support) { LogWarning "The pkg $($pkg.Package) is deprecated. Add 'deprecated' besides of display name." From 1395588e452df9dddee303bdfe633fe567a92fab Mon Sep 17 00:00:00 2001 From: sima-zhu Date: Fri, 16 Dec 2022 12:22:31 -0800 Subject: [PATCH 6/8] Add package helper to common --- eng/common/scripts/common.ps1 | 1 + 1 file changed, 1 insertion(+) diff --git a/eng/common/scripts/common.ps1 b/eng/common/scripts/common.ps1 index 1b77491fd3..c78b1cfc2f 100644 --- a/eng/common/scripts/common.ps1 +++ b/eng/common/scripts/common.ps1 @@ -15,6 +15,7 @@ $EngScriptsDir = Join-Path $EngDir "scripts" . (Join-Path $EngCommonScriptsDir Invoke-DevOpsAPI.ps1) . (Join-Path $EngCommonScriptsDir artifact-metadata-parsing.ps1) . (Join-Path $EngCommonScriptsDir "Helpers" git-helpers.ps1) +. (Join-Path $EngCommonScriptsDir "Helpers" Package-Helpers.ps1) # Setting expected from common languages settings $Language = "Unknown" From f17472800e3151644284040e3cd6c414f8f1c43e Mon Sep 17 00:00:00 2001 From: sima-zhu Date: Fri, 16 Dec 2022 14:45:30 -0800 Subject: [PATCH 7/8] typo again --- eng/common/scripts/Helpers/Package-Helpers.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/common/scripts/Helpers/Package-Helpers.ps1 b/eng/common/scripts/Helpers/Package-Helpers.ps1 index 325dc4e482..19bfe45c3c 100644 --- a/eng/common/scripts/Helpers/Package-Helpers.ps1 +++ b/eng/common/scripts/Helpers/Package-Helpers.ps1 @@ -41,7 +41,7 @@ function GetDocsTocDisplayName($pkg) { $displayName = $pkg.DisplayName if ('deprecated' -eq $pkg.Support) { LogWarning "The pkg $($pkg.Package) is deprecated. Add 'deprecated' besides of display name." - $diaplayName += " (deprecated)" + $displayName += " (deprecated)" } return $displayName } \ No newline at end of file From 15a6bfc4d1322c7ccbf4bdba423f9301596dc723 Mon Sep 17 00:00:00 2001 From: Sima Zhu <48036328+sima-zhu@users.noreply.github.com> Date: Wed, 21 Dec 2022 09:09:18 -0800 Subject: [PATCH 8/8] Update eng/common/scripts/Helpers/Package-Helpers.ps1 Co-authored-by: Ben Broderick Phillips --- eng/common/scripts/Helpers/Package-Helpers.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/common/scripts/Helpers/Package-Helpers.ps1 b/eng/common/scripts/Helpers/Package-Helpers.ps1 index 19bfe45c3c..3cc8adbb7e 100644 --- a/eng/common/scripts/Helpers/Package-Helpers.ps1 +++ b/eng/common/scripts/Helpers/Package-Helpers.ps1 @@ -40,7 +40,7 @@ function GetPackageLookup($packageList) { function GetDocsTocDisplayName($pkg) { $displayName = $pkg.DisplayName if ('deprecated' -eq $pkg.Support) { - LogWarning "The pkg $($pkg.Package) is deprecated. Add 'deprecated' besides of display name." + LogWarning "The pkg $($pkg.Package) is deprecated. Adding 'deprecated' beside the display name." $displayName += " (deprecated)" } return $displayName