Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GTest warning results in build break #4463

Closed
RickWinter opened this issue Mar 21, 2023 · 0 comments · Fixed by #4464
Closed

GTest warning results in build break #4463

RickWinter opened this issue Mar 21, 2023 · 0 comments · Fixed by #4464
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. KeyVault test-reliability Issue that causes tests to be unreliable

Comments

@RickWinter
Copy link
Member

googletest-src/googletest/include\gtest/gtest.h(1444,1): warning C4018: '>': signed/unsigned mismatch

sdk\keyvault\azure-security-keyvault-keys\test\ut\azure-security-keyvault-keys-test.vcxproj
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 21, 2023
@RickWinter RickWinter added bug This issue requires a change to an existing behavior in the product in order to be resolved. Azure.Core Client This issue points to a problem in the data-plane of the library. test-reliability Issue that causes tests to be unreliable KeyVault and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. Azure.Core labels Mar 21, 2023
@RickWinter RickWinter linked a pull request Mar 21, 2023 that will close this issue
Ensure the comparison is unsigned to unsigned #4464
Merged
@RickWinter RickWinter mentioned this issue Mar 21, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. KeyVault test-reliability Issue that causes tests to be unreliable
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure the comparison is unsigned to unsigned RickWinter/azure-sdk-for-cpp
1 participant
@RickWinter