Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVEONLY tests in Storage #4147

Closed
gearama opened this issue Dec 1, 2022 · 5 comments · Fixed by #4241
Closed

LIVEONLY tests in Storage #4147

gearama opened this issue Dec 1, 2022 · 5 comments · Fixed by #4241
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. test-enhancement

Comments

@gearama
Copy link
Member

gearama commented Dec 1, 2022

There are some issues with test proxy behavior and some of the storage tests in a few cases there are errors around json deserialization "expected string received null", which suggest that the deserailization of the incoming json might not handle nulls properly.
The followin g tests i swiched to LIVEONLY

 37 - azure-storage-blobs.BlobContainerClientTest.Lease (Failed)
 
114 - azure-storage-blobs.PageBlobClientTest.Lease (Failed)

420 - azure-storage-files-shares.FileShareClientTest.Lease (Failed)
421 - azure-storage-files-shares.FileShareClientTest.SnapshotLease (Failed)

447 - azure-storage-files-shares.FileShareFileClientTest.LeaseRelated (Failed)

TEST_F(BlobBatchClientTest, DISABLED_SubmitDeleteBatch)
TEST_F(BlobBatchClientTest, DISABLED_SnapshotVersion
TEST_F(BlobBatchClientTest, DISABLED_TokenAuthorization)
TEST_F(QueueClientTest, PeekMessage_LIVEONLY_)

testlogs.zip
AppendBlobClientTest.ContentHash.zip

@gearama gearama self-assigned this Dec 1, 2022
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 1, 2022
@gearama
Copy link
Member Author

gearama commented Dec 1, 2022

@Jinming-Hu
Copy link
Member

@gearama

Do you want storage team to look into this or you want to assign this to yourself just for tracking?

@RickWinter RickWinter added Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. test-enhancement labels Dec 6, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 6, 2022
@gearama
Copy link
Member Author

gearama commented Dec 8, 2022

@Jinming-Hu the help of your team would be greatly appreciated.
Once the PR gets merged we can investigate.
, the lease tests have an issue around the fact that every time they regenerate the lease id , thus the recording always gets confused, we might need an extra sanitizer for this case. the others might need a bit more investigating. on my machine some of the tests would not fail , only online , with the same layout and configs

@Jinming-Hu
Copy link
Member

Jinming-Hu commented Jan 12, 2023

Hi @gearama ,

I found some secrets were not properly redacted when fetching tokens.
In the below recorded request, tenant ID, client ID, client secret were in plaintext. Not sure if the cookie should be redacted.

image

Can you update the sanitizer rule?

@Jinming-Hu
Copy link
Member

Jinming-Hu commented Jan 13, 2023

Hi @gearama , have you got a chance to look at the above issue?

What is the correct way to record/playback token-fetching/refreshing requests anyway? Is it by-design to not record such requests?

@gearama gearama removed their assignment Feb 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. test-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants