Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty file created if blob not found #3847

Closed
mmarko1010 opened this issue Jul 25, 2022 · 1 comment · Fixed by #3910
Closed

Empty file created if blob not found #3847

mmarko1010 opened this issue Jul 25, 2022 · 1 comment · Fixed by #3910
Assignees
@Jinming-Hu
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Storage Storage Service (Queues, Blobs, Files)
Milestone
2022-09

Comments

@mmarko1010
Copy link

azure-sdk-for-cpp/sdk/storage/azure-storage-blobs/src/blob_client.cpp

Line 422 in 6c74e57

_internal::FileWriter fileWriter(fileName);

shouldn't we [try to] download firstChunk before creating fileWriter?
The current implementation leaves behind an empty file (created in FileWriter) if the blob doesn't exist.
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jul 25, 2022
@RickWinter RickWinter added the Storage Storage Service (Queues, Blobs, Files) label Jul 25, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 25, 2022
@RickWinter RickWinter added the Client This issue points to a problem in the data-plane of the library. label Jul 25, 2022
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Jul 25, 2022
@Jinming-Hu
Copy link
Member

This makes sense, will fix it sometime.

@RickWinter RickWinter added bug This issue requires a change to an existing behavior in the product in order to be resolved. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Aug 22, 2022
@RickWinter RickWinter added this to the 2022-10 milestone Aug 22, 2022
@Jinming-Hu Jinming-Hu mentioned this issue Aug 29, 2022
Merged
14 tasks
@RickWinter RickWinter modified the milestones: 2022-10, 2022-09 Sep 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Jinming-Hu Jinming-Hu

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
2022-09
4 participants
@RickWinter @vinjiang @Jinming-Hu @mmarko1010