Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operator<<(std::ostream&, AzSdkType) #1773

Closed
antkmsft opened this issue Mar 4, 2021 · 8 comments
Closed

Add operator<<(std::ostream&, AzSdkType) #1773

antkmsft opened this issue Mar 4, 2021 · 8 comments
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone

Comments

@antkmsft
Copy link
Member

antkmsft commented Mar 4, 2021

This came up during usability studies / manually putting ourselves into customer shoes.

  • There should be an overload for HttpStatusCode (casts to int)
  • For DateTime (I suggest Rfc3339 with all digits, as it has fractional seconds, and gives maximum precision)
  • Review if anything else needs it.
  • Extensible enums probably don't, because they are strings.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 4, 2021
@antkmsft
Copy link
Member Author

antkmsft commented Mar 4, 2021

cc @ahsonkhan

@antkmsft antkmsft changed the title Add operator<<(std::ofstream&, AzSdkType) Add operator<<(std::ostream&, AzSdkType) Mar 4, 2021
@ahsonkhan ahsonkhan added Azure.Core design-discussion An area of design currently under discussion and open to team and community feedback. feature-request This issue requires a new behavior in the product in order be resolved. labels Mar 4, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 4, 2021
@ahsonkhan
Copy link
Member

We might want to include other types too like RawResponse, Url, Response<T>, Uuid, etc. It's almost equivalent to .NET's ToString() methods on types and DebuggerDisplay for ease of diagnosability while using the SDK types so users can quickly output useful string representation of such types to std::cout.

Any others come to mind @vhvb1989 and @RickWinter that could benefit from this?

@vhvb1989
Copy link
Member

vhvb1989 commented Mar 4, 2021

I remember sometime ago @JeffreyRichter mentioned something about why these operators are better not to have.

I am adding all team to the assigner list to comment and work the designing.

@antkmsft
Copy link
Member Author

antkmsft commented Mar 4, 2021

JFYI, #1752 adds it for DateTime.

@ahsonkhan
Copy link
Member

JFYI, #1752 adds it for DateTime.

Please do that in a separate PR.

@ahsonkhan ahsonkhan added this to the [2021] April milestone Mar 9, 2021
@RickWinter RickWinter added the Client This issue points to a problem in the data-plane of the library. label Mar 16, 2021
@RickWinter
Copy link
Member

@ahsonkhan @antkmsft This seems like a reasonable feature to add in the future. Is there any class that wouldn't work with this feature in the future.

@antkmsft
Copy link
Member Author

We can add it later, if we don't do it today, it will not prevent us from adding it in the future.

@antkmsft antkmsft modified the milestones: [2021] April, Backlog Mar 26, 2021
@RickWinter RickWinter removed the design-discussion An area of design currently under discussion and open to team and community feedback. label Apr 5, 2021
Copy link

Hi @antkmsft, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Development

No branches or pull requests

5 participants