From ee0b8fbf014532320422f3f19875a2d224ff34cd Mon Sep 17 00:00:00 2001 From: Sima Zhu Date: Thu, 17 Sep 2020 14:56:43 -0700 Subject: [PATCH 1/2] Replaced relative link with absolute links and remove locale --- README.md | 6 +++--- eng/common/pipelines/templates/steps/verify-links.yml | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 14314b42cc..d4be50ceea 100644 --- a/README.md +++ b/README.md @@ -16,10 +16,10 @@ For your convenience, each service has a separate set of libraries that you can ### Libraries available -Currently, the client libraries are in **preview**. These libraries follow the [Azure SDK Design Guidelines for Android](https://azure.github.io/azure-sdk/android_introduction.html) and share a number of core features such as HTTP retries, logging, transport protocols, authentication protocols, etc., so that once you learn how to use these features in one client library, you will know how to use them in other client libraries. You can learn about these shared features in [azure-core](sdk/core/azure-core/README.md). +Currently, the client libraries are in **preview**. These libraries follow the [Azure SDK Design Guidelines for Android](https://azure.github.io/azure-sdk/android_introduction.html) and share a number of core features such as HTTP retries, logging, transport protocols, authentication protocols, etc., so that once you learn how to use these features in one client library, you will know how to use them in other client libraries. You can learn about these shared features in [azure-core](https://github.com/Azure/azure-sdk-for-android/blob/master/sdk/core/azure-core/README.md). The following libraries are currently in **preview**: -- [azure-storage-blob](sdk/storage/azure-storage-blob) +- [azure-storage-blob](https://github.com/Azure/azure-sdk-for-android/blob/master/sdk/storage/azure-storage-blob) > Note: The SDK is currently in **preview**. The API surface and feature sets are subject to change at any time before **GA**. We do not currently recommend them for production use. @@ -64,7 +64,7 @@ If you plan to use the [Microsoft Authentication Library (MSAL) for Android](htt Security issues and bugs should be reported privately, via email, to the Microsoft Security Response Center (MSRC) . You should receive a response within 24 hours. If for some reason you do not, please follow up via email to ensure we received your original message. Further information, including the MSRC PGP key, can be found in the [Security TechCenter](https://www.microsoft.com/msrc/faqs-report-an-issue). ## Contributing -For details on contributing to this repository, see the [contributing guide](CONTRIBUTING.md). +For details on contributing to this repository, see the [contributing guide](https://github.com/Azure/azure-sdk-for-android/blob/master/CONTRIBUTING.md). This project welcomes contributions and suggestions. Most contributions require you to agree to a Contributor License Agreement (CLA) declaring that you have the right to, and actually do, grant us the rights to use your contribution. For details, visit https://cla.microsoft.com. diff --git a/eng/common/pipelines/templates/steps/verify-links.yml b/eng/common/pipelines/templates/steps/verify-links.yml index eaa2dd1426..b23a266cca 100644 --- a/eng/common/pipelines/templates/steps/verify-links.yml +++ b/eng/common/pipelines/templates/steps/verify-links.yml @@ -4,7 +4,7 @@ parameters: WorkingDirectory: '$(System.DefaultWorkingDirectory)' ScriptDirectory: 'eng/common/scripts' Recursive: $false - CheckLinkGuidance: $false + CheckLinkGuidance: $true Urls: '(Get-ChildItem -Path ./ -Recurse -Include *.md)' BranchReplaceRegex: "^(${env:SYSTEM_PULLREQUEST_SOURCEREPOSITORYURI}.*/(?:blob|tree)/)master(/.*)$" BranchReplacementName: "${env:SYSTEM_PULLREQUEST_SOURCECOMMITID}" From 826287d0e0262e6177453b5398c73261b381bf5c Mon Sep 17 00:00:00 2001 From: Sima Zhu Date: Thu, 17 Sep 2020 18:23:29 -0700 Subject: [PATCH 2/2] Enable the feature on client yml --- eng/common/pipelines/templates/steps/verify-links.yml | 2 +- eng/pipelines/templates/jobs/archetype-sdk-client.yml | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/eng/common/pipelines/templates/steps/verify-links.yml b/eng/common/pipelines/templates/steps/verify-links.yml index b23a266cca..eaa2dd1426 100644 --- a/eng/common/pipelines/templates/steps/verify-links.yml +++ b/eng/common/pipelines/templates/steps/verify-links.yml @@ -4,7 +4,7 @@ parameters: WorkingDirectory: '$(System.DefaultWorkingDirectory)' ScriptDirectory: 'eng/common/scripts' Recursive: $false - CheckLinkGuidance: $true + CheckLinkGuidance: $false Urls: '(Get-ChildItem -Path ./ -Recurse -Include *.md)' BranchReplaceRegex: "^(${env:SYSTEM_PULLREQUEST_SOURCEREPOSITORYURI}.*/(?:blob|tree)/)master(/.*)$" BranchReplacementName: "${env:SYSTEM_PULLREQUEST_SOURCECOMMITID}" diff --git a/eng/pipelines/templates/jobs/archetype-sdk-client.yml b/eng/pipelines/templates/jobs/archetype-sdk-client.yml index 9dbf839e84..08adc519ff 100644 --- a/eng/pipelines/templates/jobs/archetype-sdk-client.yml +++ b/eng/pipelines/templates/jobs/archetype-sdk-client.yml @@ -40,6 +40,7 @@ jobs: - template: ../../../common/pipelines/templates/steps/verify-links.yml parameters: Directory: '' + CheckLinkGuidance: $true - script: | ./gradlew sdk:${{parameters.ServiceDirectory}}:lintDebug