From 0a49ca4665d14623a876ee0a8048583785a86fc1 Mon Sep 17 00:00:00 2001 From: Sam Kreter Date: Thu, 14 Jun 2018 09:38:13 -0500 Subject: [PATCH 1/3] Updating Exec Command Naming for better to understand documentation. --- .../stable/2018-06-01/containerInstance.json | 12 ++++++------ .../{ContainerExecStart.json => ContainerExec.json} | 0 2 files changed, 6 insertions(+), 6 deletions(-) rename specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2018-06-01/examples/{ContainerExecStart.json => ContainerExec.json} (100%) diff --git a/specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2018-06-01/containerInstance.json b/specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2018-06-01/containerInstance.json index 8afa1628cfca..fab915292d45 100644 --- a/specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2018-06-01/containerInstance.json +++ b/specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2018-06-01/containerInstance.json @@ -365,14 +365,14 @@ }, "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerInstance/containerGroups/{containerGroupName}/containers/{containerName}/exec": { "post": { - "operationId": "StartContainer_LaunchExec", + "operationId": "Container_Exec", "x-ms-examples": { - "ContainerExecStart": { - "$ref": "./examples/ContainerExecStart.json" + "ContainerExec": { + "$ref": "./examples/ContainerExec.json" } }, - "summary": "Starts the exec command for a specific container instance.", - "description": "Starts the exec command for a specified container instance in a specified resource group and container group.", + "summary": "Executes a command in a specific container instance.", + "description": "Executes a command for a specific container instance in a specified resource group and container group.", "parameters": [ { "$ref": "#/parameters/SubscriptionIdParameter" @@ -1231,7 +1231,7 @@ } }, "ContainerExecRequest": { - "description": "The start container exec request.", + "description": "The container exec request.", "type": "object", "properties": { "command": { diff --git a/specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2018-06-01/examples/ContainerExecStart.json b/specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2018-06-01/examples/ContainerExec.json similarity index 100% rename from specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2018-06-01/examples/ContainerExecStart.json rename to specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2018-06-01/examples/ContainerExec.json From a58ad31ca0f190c08d519f0e57f0251b719de4c3 Mon Sep 17 00:00:00 2001 From: Sam Kreter Date: Thu, 14 Jun 2018 13:53:56 -0500 Subject: [PATCH 2/3] Udpating other fields to have better documentation --- .../stable/2018-06-01/containerInstance.json | 6 +++--- .../{ContainerLogsList.json => ContainerListLogs.json} | 0 2 files changed, 3 insertions(+), 3 deletions(-) rename specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2018-06-01/examples/{ContainerLogsList.json => ContainerListLogs.json} (100%) diff --git a/specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2018-06-01/containerInstance.json b/specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2018-06-01/containerInstance.json index fab915292d45..0c2769af2614 100644 --- a/specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2018-06-01/containerInstance.json +++ b/specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2018-06-01/containerInstance.json @@ -318,10 +318,10 @@ }, "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerInstance/containerGroups/{containerGroupName}/containers/{containerName}/logs": { "get": { - "operationId": "ContainerLogs_List", + "operationId": "Container_ListLogs", "x-ms-examples": { - "ContainerLogsList": { - "$ref": "./examples/ContainerLogsList.json" + "ContainerListLogs": { + "$ref": "./examples/ContainerListLogs.json" } }, "summary": "Get the logs for a specified container instance.", diff --git a/specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2018-06-01/examples/ContainerLogsList.json b/specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2018-06-01/examples/ContainerListLogs.json similarity index 100% rename from specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2018-06-01/examples/ContainerLogsList.json rename to specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2018-06-01/examples/ContainerListLogs.json From 57c26f8ddc6cce63febe8113dcf5a0c4e638c1ea Mon Sep 17 00:00:00 2001 From: Sam Kreter Date: Thu, 14 Jun 2018 14:58:44 -0500 Subject: [PATCH 3/3] Changing Container_Exec -> Conatiner_ExecuteCommand for better understanding --- .../stable/2018-06-01/containerInstance.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2018-06-01/containerInstance.json b/specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2018-06-01/containerInstance.json index 0c2769af2614..5f3b86bffe07 100644 --- a/specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2018-06-01/containerInstance.json +++ b/specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2018-06-01/containerInstance.json @@ -365,7 +365,7 @@ }, "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerInstance/containerGroups/{containerGroupName}/containers/{containerName}/exec": { "post": { - "operationId": "Container_Exec", + "operationId": "Container_ExecuteCommand", "x-ms-examples": { "ContainerExec": { "$ref": "./examples/ContainerExec.json"