Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EG] working @examples #31828

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

[EG] working @examples #31828

wants to merge 15 commits into from

Conversation

l0lawrence
Copy link
Member

Adding all example files that are accurate to the current models we have

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 11, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named Swagger BreakingChange has failed. To unblock this PR, follow the process at aka.ms/brch.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 11, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
.Net Azure.Messaging.EventGrid.SystemEvents https://apiview.dev/Assemblies/Review/3e102a891e5445af8be8cde833dbb702?revisionId=f7ec5e66ab3148e8acf939ab7af6131a

@AzureRestAPISpecReview AzureRestAPISpecReview added the TypeSpec Authored with TypeSpec label Dec 11, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.ApiCenter

@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane labels Dec 11, 2024
This was referenced Dec 11, 2024
Draft
Draft
l0lawrence
l0lawrence commented Dec 11, 2024
View reviewed changes
...ification/eventgrid/Azure.Messaging.EventGrid.SystemEvents/Microsoft.EventGrid/EventGrid.tsp Outdated
@@ -122,21 +132,34 @@ long, and supports UTF-8 characters.
clientAuthenticationName: string;

/** Name of the client resource in the Event Grid namespace. */
clientName: string;
clientName?: string;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asked about this

l0lawrence
l0lawrence commented Dec 11, 2024
View reviewed changes
...ification/eventgrid/Azure.Messaging.EventGrid.SystemEvents/Microsoft.EventGrid/EventGrid.tsp Outdated
@@ -62,7 +62,7 @@ model SubscriptionValidationEventData {
/** The validation URL sent by Azure Event Grid (available starting version 2018-05-01-preview).
* To complete the validation handshake, the subscriber must either respond with the validationCode as part of the validation response,
* or perform a GET request on the validationUrl (available starting version 2018-05-01-preview). */
validationUrl: string;
validationUrl?: string;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this

l0lawrence
l0lawrence commented Dec 11, 2024
View reviewed changes
specification/eventgrid/Azure.Messaging.EventGrid.SystemEvents/script.py Outdated
@@ -0,0 +1,110 @@
# Go into the SystemEvents.json file and find the definitions section
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel will be requested when the pull request is marked ready for review lmazuel is a code owner

@jsquire jsquire Awaiting requested review from jsquire jsquire will be requested when the pull request is marked ready for review jsquire is a code owner

@JoshLove-msft JoshLove-msft Awaiting requested review from JoshLove-msft JoshLove-msft will be requested when the pull request is marked ready for review JoshLove-msft is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane Event Grid TypeSpec Authored with TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@l0lawrence @azure-sdk @AzureRestAPISpecReview