From 98b386f2f25e18b0e58cfce06d117e8e2793ba7a Mon Sep 17 00:00:00 2001 From: Dylan Martinez Date: Wed, 17 Apr 2024 09:03:46 -0700 Subject: [PATCH 01/14] update securityPostureRef properties in VMScaleSet spec --- .../2024-03-01/virtualMachineScaleSet.json | 38 +++++++++++++++++-- 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json index 579d93d9d08f..bcfcdc04c06a 100644 --- a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json +++ b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json @@ -5181,7 +5181,7 @@ }, "securityPostureReference": { "$ref": "#/definitions/SecurityPostureReference", - "description": "Specifies the security posture to be used for all virtual machines in the scale set. Minimum api-version: 2023-03-01" + "description": "Specifies the security posture to be used in the scale set. Minimum api-version: 2024-03-01" }, "timeCreated": { "readOnly": true, @@ -6341,12 +6341,42 @@ "excludeExtensions": { "type": "array", "items": { - "$ref": "./virtualMachine.json#/definitions/VirtualMachineExtension" + "type": "string" + }, + "description": "The list of virtual machine extension names to exclude when applying the security posture." + }, + "extensionsSettings": { + "type": "array", + "items": { + "type": "object", + "properties": { + "name": { + "type": "string", + "description": "The name of the virtual machine extension included in the security posture." + }, + "settings": { + "type": "object", + "description": "Json formatted public settings for the extension." + }, + "protectedSettings": { + "type": "object", + "description": "The extension can contain either protectedSettings or protectedSettingsFromKeyVault or no protected settings at all." + }, + "protectedSettingsFromKeyVault": { + "$ref": "./computeRPCommon.json#/definitions/KeyVaultSecretReference", + "description": "The extensions protected settings that are passed by reference, and consumed from key vault" + } + }, + "description": "Specifies the virtual machine extension settings to include in the security posture." }, - "description": "List of virtual machine extensions to exclude when applying the Security Posture." + "description": "The list of settings to include for the virtual machine extensions in the security posture." + }, + "isOverridable": { + "type": "boolean", + "description": "Whether the security posture can be overridden by the user." } }, - "description": "Specifies the security posture to be used for all virtual machines in the scale set. Minimum api-version: 2023-03-01" + "description": "Specifies the security posture to be used in the scale set. Minimum api-version: 2023-03-01" } } } From 75ee1fe45b32af19ab166c6eb816e96e2af2a4a0 Mon Sep 17 00:00:00 2001 From: Dylan Martinez Date: Mon, 6 May 2024 08:59:07 -0700 Subject: [PATCH 02/14] add securityPostureReference to UpdateVMProfile definition and fix min version --- .../ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json index bcfcdc04c06a..cea47452fa2c 100644 --- a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json +++ b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json @@ -5206,6 +5206,10 @@ "$ref": "#/definitions/VirtualMachineScaleSetUpdateNetworkProfile", "description": "The virtual machine scale set network profile." }, + "securityPostureReference": { + "$ref": "#/definitions/SecurityPostureReference", + "description": "The virtual machine scale set security posture reference." + }, "securityProfile": { "$ref": "./computeRPCommon.json#/definitions/SecurityProfile", "description": "The virtual machine scale set Security profile" @@ -6376,7 +6380,7 @@ "description": "Whether the security posture can be overridden by the user." } }, - "description": "Specifies the security posture to be used in the scale set. Minimum api-version: 2023-03-01" + "description": "Specifies the security posture to be used in the scale set. Minimum api-version: 2024-03-01" } } } From 2ca7291fb90d5d2508c49948a289cde39ac31a79 Mon Sep 17 00:00:00 2001 From: Dylan Martinez Date: Mon, 6 May 2024 11:10:01 -0700 Subject: [PATCH 03/14] add prettier changes --- .../ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json index cea47452fa2c..339ff35ec2b8 100644 --- a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json +++ b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json @@ -5208,7 +5208,7 @@ }, "securityPostureReference": { "$ref": "#/definitions/SecurityPostureReference", - "description": "The virtual machine scale set security posture reference." + "description": "The virtual machine scale set security posture reference." }, "securityProfile": { "$ref": "./computeRPCommon.json#/definitions/SecurityProfile", From 198f2d10600d1f77c742d827dc5cdaf49c7baeaf Mon Sep 17 00:00:00 2001 From: Dylan Martinez Date: Wed, 8 May 2024 11:02:12 -0700 Subject: [PATCH 04/14] remove unsupported 'major.*' from spec --- ...MachineScaleSet_Create_WithSecurityPostureReference.json | 6 +++--- .../ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/examples/virtualMachineScaleSetExamples/VirtualMachineScaleSet_Create_WithSecurityPostureReference.json b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/examples/virtualMachineScaleSetExamples/VirtualMachineScaleSet_Create_WithSecurityPostureReference.json index 516e1f660510..a22a41a2635d 100644 --- a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/examples/virtualMachineScaleSetExamples/VirtualMachineScaleSet_Create_WithSecurityPostureReference.json +++ b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/examples/virtualMachineScaleSetExamples/VirtualMachineScaleSet_Create_WithSecurityPostureReference.json @@ -15,7 +15,7 @@ "overprovision": true, "virtualMachineProfile": { "securityPostureReference": { - "id": "/CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|{major.*}|latest" + "id": "/CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|latest" }, "storageProfile": { "imageReference": { @@ -81,7 +81,7 @@ "uniqueId": "d12ccb3d-ab15-4794-9836-c4196392e9f2", "virtualMachineProfile": { "securityPostureReference": { - "id": "/CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|{major.*}|latest" + "id": "/CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|latest" }, "storageProfile": { "imageReference": { @@ -159,7 +159,7 @@ "uniqueId": "d12ccb3d-ab15-4794-9836-c4196392e9f2", "virtualMachineProfile": { "securityPostureReference": { - "id": "/CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|{major.*}|latest" + "id": "/CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|latest" }, "storageProfile": { "imageReference": { diff --git a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json index 339ff35ec2b8..c3250b9bad5b 100644 --- a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json +++ b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json @@ -6340,7 +6340,7 @@ "properties": { "id": { "type": "string", - "description": "The security posture reference id in the form of /CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|{major.*}|latest" + "description": "The security posture reference id in the form of /CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|latest" }, "excludeExtensions": { "type": "array", From f742eeaf23d9335420135c14b364f1082c16a2d4 Mon Sep 17 00:00:00 2001 From: Dylan Martinez Date: Wed, 8 May 2024 11:06:37 -0700 Subject: [PATCH 05/14] add optional fields in security posture example --- ...ScaleSet_Create_WithSecurityPostureReference.json | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/examples/virtualMachineScaleSetExamples/VirtualMachineScaleSet_Create_WithSecurityPostureReference.json b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/examples/virtualMachineScaleSetExamples/VirtualMachineScaleSet_Create_WithSecurityPostureReference.json index a22a41a2635d..ee34ed975ef0 100644 --- a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/examples/virtualMachineScaleSetExamples/VirtualMachineScaleSet_Create_WithSecurityPostureReference.json +++ b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/examples/virtualMachineScaleSetExamples/VirtualMachineScaleSet_Create_WithSecurityPostureReference.json @@ -15,7 +15,9 @@ "overprovision": true, "virtualMachineProfile": { "securityPostureReference": { - "id": "/CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|latest" + "id": "/CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|latest", + "excludeExtensions": ["{securityPostureVMExtensionName}"], + "isOverridable": true }, "storageProfile": { "imageReference": { @@ -81,7 +83,9 @@ "uniqueId": "d12ccb3d-ab15-4794-9836-c4196392e9f2", "virtualMachineProfile": { "securityPostureReference": { - "id": "/CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|latest" + "id": "/CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|latest", + "excludeExtensions": ["{securityPostureVMExtensionName}"], + "isOverridable": true }, "storageProfile": { "imageReference": { @@ -159,7 +163,9 @@ "uniqueId": "d12ccb3d-ab15-4794-9836-c4196392e9f2", "virtualMachineProfile": { "securityPostureReference": { - "id": "/CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|latest" + "id": "/CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|latest", + "excludeExtensions": ["{securityPostureVMExtensionName}"], + "isOverridable": true }, "storageProfile": { "imageReference": { From 0f8032d8952e83715ef5960da006eba021fc6558 Mon Sep 17 00:00:00 2001 From: Dylan Martinez Date: Mon, 13 May 2024 08:30:00 -0700 Subject: [PATCH 06/14] add required fields --- .../ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json index c3250b9bad5b..7d09c8a2502c 100644 --- a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json +++ b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json @@ -6380,7 +6380,10 @@ "description": "Whether the security posture can be overridden by the user." } }, - "description": "Specifies the security posture to be used in the scale set. Minimum api-version: 2024-03-01" + "description": "Specifies the security posture to be used in the scale set. Minimum api-version: 2024-03-01", + "required": [ + "id" + ] } } } From c8a369e222489e4e891234c2731682735577a67d Mon Sep 17 00:00:00 2001 From: Dylan Martinez Date: Wed, 15 May 2024 09:06:22 -0700 Subject: [PATCH 07/14] correct minimum api version --- .../ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json index 7d09c8a2502c..a137d3b4c59b 100644 --- a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json +++ b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json @@ -5181,7 +5181,7 @@ }, "securityPostureReference": { "$ref": "#/definitions/SecurityPostureReference", - "description": "Specifies the security posture to be used in the scale set. Minimum api-version: 2024-03-01" + "description": "Specifies the security posture to be used in the scale set. Minimum api-version: 2023-03-01" }, "timeCreated": { "readOnly": true, @@ -6380,7 +6380,7 @@ "description": "Whether the security posture can be overridden by the user." } }, - "description": "Specifies the security posture to be used in the scale set. Minimum api-version: 2024-03-01", + "description": "Specifies the security posture to be used in the scale set. Minimum api-version: 2023-03-01", "required": [ "id" ] From 283d7e333c38026334cc902cf5dfb1346e4f24d4 Mon Sep 17 00:00:00 2001 From: Dylan Martinez Date: Wed, 15 May 2024 09:10:00 -0700 Subject: [PATCH 08/14] add prettier fixes --- ...ScaleSet_Create_WithSecurityPostureReference.json | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/examples/virtualMachineScaleSetExamples/VirtualMachineScaleSet_Create_WithSecurityPostureReference.json b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/examples/virtualMachineScaleSetExamples/VirtualMachineScaleSet_Create_WithSecurityPostureReference.json index ee34ed975ef0..8c7a40646ad6 100644 --- a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/examples/virtualMachineScaleSetExamples/VirtualMachineScaleSet_Create_WithSecurityPostureReference.json +++ b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/examples/virtualMachineScaleSetExamples/VirtualMachineScaleSet_Create_WithSecurityPostureReference.json @@ -16,7 +16,9 @@ "virtualMachineProfile": { "securityPostureReference": { "id": "/CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|latest", - "excludeExtensions": ["{securityPostureVMExtensionName}"], + "excludeExtensions": [ + "{securityPostureVMExtensionName}" + ], "isOverridable": true }, "storageProfile": { @@ -84,7 +86,9 @@ "virtualMachineProfile": { "securityPostureReference": { "id": "/CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|latest", - "excludeExtensions": ["{securityPostureVMExtensionName}"], + "excludeExtensions": [ + "{securityPostureVMExtensionName}" + ], "isOverridable": true }, "storageProfile": { @@ -164,7 +168,9 @@ "virtualMachineProfile": { "securityPostureReference": { "id": "/CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|latest", - "excludeExtensions": ["{securityPostureVMExtensionName}"], + "excludeExtensions": [ + "{securityPostureVMExtensionName}" + ], "isOverridable": true }, "storageProfile": { From 2431064ba103a1bd4c090b0acb49b0ca9e3245f0 Mon Sep 17 00:00:00 2001 From: Dylan Martinez Date: Wed, 22 May 2024 07:11:39 -0700 Subject: [PATCH 09/14] remove extensionsSettings property --- .../2024-03-01/virtualMachineScaleSet.json | 26 ------------------- 1 file changed, 26 deletions(-) diff --git a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json index a137d3b4c59b..dae0330bbe13 100644 --- a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json +++ b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json @@ -6349,32 +6349,6 @@ }, "description": "The list of virtual machine extension names to exclude when applying the security posture." }, - "extensionsSettings": { - "type": "array", - "items": { - "type": "object", - "properties": { - "name": { - "type": "string", - "description": "The name of the virtual machine extension included in the security posture." - }, - "settings": { - "type": "object", - "description": "Json formatted public settings for the extension." - }, - "protectedSettings": { - "type": "object", - "description": "The extension can contain either protectedSettings or protectedSettingsFromKeyVault or no protected settings at all." - }, - "protectedSettingsFromKeyVault": { - "$ref": "./computeRPCommon.json#/definitions/KeyVaultSecretReference", - "description": "The extensions protected settings that are passed by reference, and consumed from key vault" - } - }, - "description": "Specifies the virtual machine extension settings to include in the security posture." - }, - "description": "The list of settings to include for the virtual machine extensions in the security posture." - }, "isOverridable": { "type": "boolean", "description": "Whether the security posture can be overridden by the user." From fbd440fc8cf9172cbb59eaa173eb9c7b366babeb Mon Sep 17 00:00:00 2001 From: Dylan Martinez Date: Fri, 24 May 2024 12:48:39 -0700 Subject: [PATCH 10/14] create new Update model for security posture reference & update --- .../2024-03-01/virtualMachineScaleSet.json | 23 ++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json index dae0330bbe13..4db04b736c3d 100644 --- a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json +++ b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json @@ -5207,7 +5207,7 @@ "description": "The virtual machine scale set network profile." }, "securityPostureReference": { - "$ref": "#/definitions/SecurityPostureReference", + "$ref": "#/definitions/SecurityPostureReferenceUpdate", "description": "The virtual machine scale set security posture reference." }, "securityProfile": { @@ -6358,6 +6358,27 @@ "required": [ "id" ] + }, + "SecurityPostureReferenceUpdate": { + "type": "object", + "properties": { + "id": { + "type": "string", + "description": "The security posture reference id in the form of /CommunityGalleries/{communityGalleryName}/securityPostures/{securityPostureName}/versions/{major.minor.patch}|latest" + }, + "excludeExtensions": { + "type": "array", + "items": { + "type": "string" + }, + "description": "The list of virtual machine extension names to exclude when applying the security posture." + }, + "isOverridable": { + "type": "boolean", + "description": "Whether the security posture can be overridden by the user." + } + }, + "description": "Specifies the security posture to be used in the scale set. Minimum api-version: 2023-03-01", } } } From 19c12c80ed3232849b3ce18f2460dc2577dce3a5 Mon Sep 17 00:00:00 2001 From: Dylan Martinez Date: Tue, 28 May 2024 08:43:52 -0700 Subject: [PATCH 11/14] fix validation issue --- .../ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json index 4db04b736c3d..40974f0e3632 100644 --- a/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json +++ b/specification/compute/resource-manager/Microsoft.Compute/ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json @@ -6378,7 +6378,7 @@ "description": "Whether the security posture can be overridden by the user." } }, - "description": "Specifies the security posture to be used in the scale set. Minimum api-version: 2023-03-01", + "description": "Specifies the security posture to be used in the scale set. Minimum api-version: 2023-03-01" } } } From e6c4fd8545146131a3be11572c89f6aecdc38369 Mon Sep 17 00:00:00 2001 From: Yuchao Yan Date: Wed, 29 May 2024 10:31:57 +0800 Subject: [PATCH 12/14] Create sdk-suppressions.yaml --- specification/compute/resource-manager/sdk-suppressions.yaml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 specification/compute/resource-manager/sdk-suppressions.yaml diff --git a/specification/compute/resource-manager/sdk-suppressions.yaml b/specification/compute/resource-manager/sdk-suppressions.yaml new file mode 100644 index 000000000000..a76bae775082 --- /dev/null +++ b/specification/compute/resource-manager/sdk-suppressions.yaml @@ -0,0 +1,5 @@ +suppressions: + azure-sdk-for-python: + - package: azure-mgmt-compute + breaking-changes: + - Parameter id of model SecurityPostureReference is now required From 3c59e229dcd0940e0f37ba6327161e9f04f0d6a7 Mon Sep 17 00:00:00 2001 From: Alancere <804873052@qq.com> Date: Wed, 29 May 2024 15:50:42 +0800 Subject: [PATCH 13/14] add azure-sdk-for-go suppression --- specification/compute/resource-manager/sdk-suppressions.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/specification/compute/resource-manager/sdk-suppressions.yaml b/specification/compute/resource-manager/sdk-suppressions.yaml index a76bae775082..ffa390efd766 100644 --- a/specification/compute/resource-manager/sdk-suppressions.yaml +++ b/specification/compute/resource-manager/sdk-suppressions.yaml @@ -3,3 +3,7 @@ suppressions: - package: azure-mgmt-compute breaking-changes: - Parameter id of model SecurityPostureReference is now required + azure-sdk-for-go: + - package: sdk/resourcemanager/compute/armcompute + breaking-changes: + - Type of `SecurityPostureReference.ExcludeExtensions` has been changed from `[]*VirtualMachineExtension` to `[]*string` \ No newline at end of file From 8434bfb83053393b166b24da5170017f3591785d Mon Sep 17 00:00:00 2001 From: kazrael2119 <98569699+kazrael2119@users.noreply.github.com> Date: Thu, 30 May 2024 14:57:09 +0800 Subject: [PATCH 14/14] Update sdk-suppressions.yaml --- .../compute/resource-manager/sdk-suppressions.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/specification/compute/resource-manager/sdk-suppressions.yaml b/specification/compute/resource-manager/sdk-suppressions.yaml index ffa390efd766..4591cd0aac17 100644 --- a/specification/compute/resource-manager/sdk-suppressions.yaml +++ b/specification/compute/resource-manager/sdk-suppressions.yaml @@ -6,4 +6,9 @@ suppressions: azure-sdk-for-go: - package: sdk/resourcemanager/compute/armcompute breaking-changes: - - Type of `SecurityPostureReference.ExcludeExtensions` has been changed from `[]*VirtualMachineExtension` to `[]*string` \ No newline at end of file + - Type of `SecurityPostureReference.ExcludeExtensions` has been changed from `[]*VirtualMachineExtension` to `[]*string` + azure-sdk-for-js: + - package: "@azure/arm-compute" + breaking-changes: + - Parameter id of interface SecurityPostureReference is now required + - Type of parameter excludeExtensions of interface SecurityPostureReference is changed from VirtualMachineExtension[] to string[] \ No newline at end of file