Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow-bot comment.yml: update guidance for publishing to public repo; add support for new breaking changes labels #27987

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Update workflow-bot comment.yml: update guidance for publishing to public repo; add support for new breaking changes labels #27987

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf48d3c
Update workflow-bot comment.yml: update guidance for publishing to pu…
Feb 29, 2024
a1d0324
Update comment.yml
Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions .github/comment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@
If this PR is targeting `main` branch, then it cannot be merged, as `azure-rest-api-specs-pr` repo `main` branch
is mirrored from `azure-rest-api-specs` `main`` branch. <br/>
If you want to publish the PR to the public repo (`Azure/azure-rest-api-specs`) `main` branch,
please use [OpenAPIHub Publish PR](${openapiHub}/tools/publishpullrequest?pr=${owner}/${repo}/${PRNumber}&to=${to}).
</li><li>
For further guidance see [Spec Repos](https://eng.ms/docs/products/azure-developer-experience/design/api-specs-pr/api-repos).
follow the guidance given in the [spec repos article](https://eng.ms/docs/products/azure-developer-experience/design/api-specs-pr/api-repos).
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maririos @JonathanCrd I removed mention of OpenAPI Hub here. Does this look right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we still have this functionality and we still let people use it. Looking at the docs provided, there is no information there about Push to public so I would recommend to keep the comment information and once @JonathanCrd looks into this feature and where/how we are going to port it, we can update the guidance here

Copy link
Author

@konrad-jamrozik konrad-jamrozik Feb 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maririos @JonathanCrd

</li>

- rule:
Expand Down Expand Up @@ -82,7 +80,21 @@
- rule:
type: label
label: Approved-BreakingChange
booleanFilterExpression: "!(ARMSignedOff||ARMChangesRequested||Approved-OkToMerge||WaitForARMRevisit)&&ARMReview"
booleanFilterExpression: "!(ARMSignedOff||WaitForARMFeedback||ARMChangesRequested||Approved-OkToMerge||WaitForARMRevisit||)&&ARMReview"
onLabeledAddLabels:
- WaitForARMFeedback

- rule:
type: label
label: BreakingChange-Approved-*
booleanFilterExpression: "!(ARMSignedOff||WaitForARMFeedback||ARMChangesRequested||Approved-OkToMerge||WaitForARMRevisit)&&ARMReview"
onLabeledAddLabels:
- WaitForARMFeedback

- rule:
type: label
label: Versioning-Approved-*
booleanFilterExpression: "!(ARMSignedOff||WaitForARMFeedback||ARMChangesRequested||Approved-OkToMerge||WaitForARMRevisit)&&ARMReview"
onLabeledAddLabels:
- WaitForARMFeedback

Expand Down