From eaf213e6557ff9e34fe472b743897d0c44c2b060 Mon Sep 17 00:00:00 2001 From: Ahmed ElSayed Date: Fri, 6 Oct 2023 11:39:12 -0700 Subject: [PATCH 1/3] Update serviceBinds with clientType and customizedKeys --- .../2023-08-01-preview/CommonDefinitions.json | 12 +++++++++++- .../examples/ContainerApps_CreateOrUpdate.json | 6 +++++- .../examples/ContainerApps_Get.json | 6 +++++- .../examples/ContainerApps_ListBySubscription.json | 6 +++++- .../examples/ContainerApps_Patch.json | 6 +++++- 5 files changed, 31 insertions(+), 5 deletions(-) diff --git a/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json b/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json index 2ff567d14e3f..fa7b0127b9c9 100644 --- a/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json +++ b/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json @@ -1352,7 +1352,17 @@ "name": { "description": "Name of the service bind", "type": "string" - } + }, + "clientType": { + "description": "Type of the client to be used to connect to the service", + "type": "string" + }, + "customizedKeys": { + "description": "Customized keys for customizing injected values to the app", + "type": "object", + "additionalProperties": { + "type": "string" + } } } }, diff --git a/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/examples/ContainerApps_CreateOrUpdate.json b/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/examples/ContainerApps_CreateOrUpdate.json index 712eb72f93fa..968532b8c538 100644 --- a/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/examples/ContainerApps_CreateOrUpdate.json +++ b/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/examples/ContainerApps_CreateOrUpdate.json @@ -155,7 +155,11 @@ "serviceBinds": [ { "serviceId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/rg/providers/Microsoft.App/containerApps/redisService", - "name": "redisService" + "name": "redisService", + "clientType": "dotnet", + "customizedKeys": { + "DesiredKey": "defaultKey" + } } ] } diff --git a/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/examples/ContainerApps_Get.json b/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/examples/ContainerApps_Get.json index e81f0640af07..34fb614112f5 100644 --- a/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/examples/ContainerApps_Get.json +++ b/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/examples/ContainerApps_Get.json @@ -118,7 +118,11 @@ "serviceBinds": [ { "serviceId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/rg/providers/Microsoft.App/containerApps/service", - "name": "service" + "name": "service", + "clientType": "dotnet", + "customizedKeys": { + "DesiredKey": "defaultKey" + } } ] }, diff --git a/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/examples/ContainerApps_ListBySubscription.json b/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/examples/ContainerApps_ListBySubscription.json index 646956f7f765..567cfb6cbb43 100644 --- a/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/examples/ContainerApps_ListBySubscription.json +++ b/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/examples/ContainerApps_ListBySubscription.json @@ -118,7 +118,11 @@ "serviceBinds": [ { "serviceId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/rg/providers/Microsoft.App/containerApps/service", - "name": "service" + "name": "service", + "clientType": "dotnet", + "customizedKeys": { + "DesiredKey": "defaultKey" + } } ] }, diff --git a/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/examples/ContainerApps_Patch.json b/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/examples/ContainerApps_Patch.json index 685022e581ae..49559100a717 100644 --- a/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/examples/ContainerApps_Patch.json +++ b/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/examples/ContainerApps_Patch.json @@ -118,7 +118,11 @@ "serviceBinds": [ { "serviceId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/rg/providers/Microsoft.App/containerApps/service", - "name": "service" + "name": "service", + "clientType": "dotnet", + "customizedKeys": { + "DesiredKey": "defaultKey" + } } ] } From c58ce8d3c585d7c8162e6f1d49595dabd4a2cf6d Mon Sep 17 00:00:00 2001 From: Ahmed ElSayed Date: Mon, 9 Oct 2023 13:09:48 -0700 Subject: [PATCH 2/3] force ci From 6a51aac32b0cdbdeb71d629fe6e366805fca0a1c Mon Sep 17 00:00:00 2001 From: Ahmed ElSayed Date: Mon, 9 Oct 2023 13:18:53 -0700 Subject: [PATCH 3/3] fix missing } --- .../preview/2023-08-01-preview/CommonDefinitions.json | 1 + 1 file changed, 1 insertion(+) diff --git a/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json b/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json index fa7b0127b9c9..286ba736339d 100644 --- a/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json +++ b/specification/app/resource-manager/Microsoft.App/preview/2023-08-01-preview/CommonDefinitions.json @@ -1363,6 +1363,7 @@ "additionalProperties": { "type": "string" } + } } } },