[Hub Generated] Review request for Microsoft.BotService to add version stable/2022-09-15 #25441

ssss141414 · 2023-08-22T13:05:34Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2023-08-22T13:05:38Z

Next Steps to Merge

⌛ Please wait, next steps to merge this PR are being evaluated by automation. ⌛

openapi-pipeline-app · 2023-08-22T13:05:38Z

Swagger Validation Report

️🔄BreakingChange inProgress [Detail]

️⌛Breaking Change(Cross-Version) pending [Detail]

️⌛CredScan pending [Detail]

️🔄LintDiff inProgress [Detail]

️🔄Avocado inProgress [Detail]

️⌛SwaggerAPIView pending [Detail]

️⌛TypeSpecAPIView pending [Detail]

️⌛ModelValidation pending [Detail]

️⌛SemanticValidation pending [Detail]

️⌛PoliCheck pending [Detail]

️⌛PrettierCheck pending [Detail]

️⌛SpellCheck pending [Detail]

️⌛Lint(RPaaS) pending [Detail]

️⌛PR Summary pending [Detail]

️⌛Automated merging requirements met pending [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-08-22T13:05:39Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-js - @azure/arm-botservice - Approved - 5.0.0-beta.1

+	Class AzureBotService has a new signature

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 4e7b46a. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.BotService [View full logs] [Release SDK Changes]
- Azure.ResourceManager.BotService.1.1.0-alpha.20231010.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 4e7b46a. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-botservice [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation group NetworkSecurityPerimeterConfigurationsOperations
info	[Changelog]   - Model BotProperties has a new parameter network_security_perimeter_configurations
info	[Changelog]   - Model ConnectionSettingProperties has a new parameter id
info	[Changelog]   - Model ConnectionSettingProperties has a new parameter name

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 4e7b46a. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]  notice
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-botservice [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation group NetworkSecurityPerimeterConfigurationsOperations
info	[Changelog]   - Model BotProperties has a new parameter network_security_perimeter_configurations
info	[Changelog]   - Model ConnectionSettingProperties has a new parameter id
info	[Changelog]   - Model ConnectionSettingProperties has a new parameter name

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 4e7b46a. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/botservice/armbotservice [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `PublicNetworkAccessSecuredByPerimeter` added to enum type `PublicNetworkAccess`
info	[Changelog] - New enum type `AccessMode` with values `AccessModeAudit`, `AccessModeEnforced`, `AccessModeLearning`
info	[Changelog] - New enum type `NspAccessRuleDirection` with values `NspAccessRuleDirectionInbound`, `NspAccessRuleDirectionOutbound`
info	[Changelog] - New enum type `ProvisioningState` with values `ProvisioningStateAccepted`, `ProvisioningStateCreating`, `ProvisioningStateDeleting`, `ProvisioningStateFailed`, `ProvisioningStateSucceeded`, `ProvisioningStateUpdating`
info	[Changelog] - New enum type `Severity` with values `SeverityError`, `SeverityWarning`
info	[Changelog] - New function `*ClientFactory.NewNetworkSecurityPerimeterConfigurationsClient() *NetworkSecurityPerimeterConfigurationsClient`
info	[Changelog] - New function `NewNetworkSecurityPerimeterConfigurationsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*NetworkSecurityPerimeterConfigurationsClient, error)`
info	[Changelog] - New function `*NetworkSecurityPerimeterConfigurationsClient.Get(context.Context, string, string, string, *NetworkSecurityPerimeterConfigurationsClientGetOptions) (NetworkSecurityPerimeterConfigurationsClientGetResponse, error)`
info	[Changelog] - New function `*NetworkSecurityPerimeterConfigurationsClient.NewListPager(string, string, *NetworkSecurityPerimeterConfigurationsClientListOptions) *runtime.Pager[NetworkSecurityPerimeterConfigurationsClientListResponse]`
info	[Changelog] - New function `*NetworkSecurityPerimeterConfigurationsClient.BeginReconcile(context.Context, string, string, string, *NetworkSecurityPerimeterConfigurationsClientBeginReconcileOptions) (*runtime.Poller[NetworkSecurityPerimeterConfigurationsClientReconcileResponse], error)`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog] - New struct `NetworkSecurityPerimeter`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfiguration`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationList`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationProperties`
info	[Changelog] - New struct `NspAccessRule`
info	[Changelog] - New struct `NspAccessRuleProperties`
info	[Changelog] - New struct `NspAccessRulePropertiesSubscriptionsItem`
info	[Changelog] - New struct `Profile`
info	[Changelog] - New struct `ProvisioningIssue`
info	[Changelog] - New struct `ProvisioningIssueProperties`
info	[Changelog] - New struct `ResourceAssociation`
info	[Changelog] - New field `NetworkSecurityPerimeterConfigurations` in struct `BotProperties`
info	[Changelog] - New field `ID`, `Name` in struct `ConnectionSettingProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 53 additive change(s).

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 4e7b46a. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0>
cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️botservice [View full logs] [Release Schema Changes]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 4e7b46a. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-botservice [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-botservice-5.0.0-beta.1.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group NetworkSecurityPerimeterConfigurations
info	[Changelog]   - Added Interface ErrorAdditionalInfo
info	[Changelog]   - Added Interface ErrorDetail
info	[Changelog]   - Added Interface ErrorResponse
info	[Changelog]   - Added Interface NetworkSecurityPerimeter
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfiguration
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationList
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationProperties
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationsGetOptionalParams
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationsListNextOptionalParams
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationsListOptionalParams
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationsReconcileHeaders
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationsReconcileOptionalParams
info	[Changelog]   - Added Interface NspAccessRule
info	[Changelog]   - Added Interface NspAccessRuleProperties
info	[Changelog]   - Added Interface NspAccessRulePropertiesSubscriptionsItem
info	[Changelog]   - Added Interface Profile
info	[Changelog]   - Added Interface ProvisioningIssue
info	[Changelog]   - Added Interface ProvisioningIssueProperties
info	[Changelog]   - Added Interface ResourceAssociation
info	[Changelog]   - Added Type Alias AccessMode
info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationsGetResponse
info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationsListNextResponse
info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationsListResponse
info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationsReconcileResponse
info	[Changelog]   - Added Type Alias NspAccessRuleDirection
info	[Changelog]   - Added Type Alias ProvisioningState
info	[Changelog]   - Added Type Alias Severity
info	[Changelog]   - Interface BotProperties has a new optional parameter networkSecurityPerimeterConfigurations
info	[Changelog]   - Interface ConnectionSettingProperties has a new optional parameter id
info	[Changelog]   - Interface ConnectionSettingProperties has a new optional parameter name
info	[Changelog]   - Added Enum KnownAccessMode
info	[Changelog]   - Added Enum KnownNspAccessRuleDirection
info	[Changelog]   - Added Enum KnownProvisioningState
info	[Changelog]   - Added Enum KnownSeverity
info	[Changelog]   - Enum KnownPublicNetworkAccess has a new value SecuredByPerimeter
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Class AzureBotService has a new signature

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from 4e7b46a. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

⚠️Az.botservice.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.botservice.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-08-22T13:05:40Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/botservice/armbotservice	https://apiview.dev/Assemblies/Review/0014d6a6774d4d119bf5c93002b4a4a7
.Net	Azure.ResourceManager.BotService	https://apiview.dev/Assemblies/Review/abcf13b5fd214b0db1734b19789abe65
JavaScript	@azure/arm-botservice	Create ApiView timeout. Package is too large and we cannot create ApiView for it.

...source-manager/Microsoft.BotService/preview/2023-09-15-preview/networksecurityperimeter.json

openapi-workflow-bot · 2023-09-01T19:09:13Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

rkmanda · 2023-09-12T18:58:45Z

You are at step 2. If u have addressed the review comments, pl remove the ARMChangesRequested label as indicated in the PR workflow diagram. Pl request a merge again once u get to step 4

raosuhas · 2023-09-26T00:08:10Z

The first commit needs to be an exact copy of the previous api version. All new changes should only be added in the subsequent commits.
This is explained in detail here (If using Open API which is recommended) https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/208/OpenAPI-Hub-Adding-new-API-version or here(For manual process) : https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/83/Manual-Process-Adding-new-API-version . Please remove the "ARMChangesRequested" label once you have fixed this issue.

...source-manager/Microsoft.BotService/preview/2023-09-15-preview/networksecurityperimeter.json

openapi-pipeline-app · 2023-10-09T08:22:10Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️Breaking Change(Cross-Version): 1 Warnings warning [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
botservice.json	2023-09-15-preview(81be8fe)	2022-09-15(main)
botservice.json	2023-09-15-preview(81be8fe)	2022-06-15-preview(main)
privatelinks.json	2023-09-15-preview(81be8fe)	2022-09-15(main)
privatelinks.json	2023-09-15-preview(81be8fe)	2022-06-15-preview(main)

The following breaking changes are detected by comparison with the latest preview version:

Rule	Message
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'true' to 'false'. New: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L2747:9 Old: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L2591:9

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 10 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.6)	new version	base version
package-preview-2023-09	package-preview-2023-09(81be8fe)	default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1523
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1523
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1523
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1572
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1572
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1572
⚠️ LongRunningOperationsOptionsValidator	A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1603	RPC-Async-V1-05
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1615
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1615
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1615

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` PutRequestResponseSchemeArm	A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Bots_Create' Request Model: 'parameters[2].schema' Response Model: 'responses[200].schema' Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L31
`❌` PatchResponseCodes	Synchronous PATCH operations must have responses with 200 and default return codes. They also must not have other response codes. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L86
`❌` UnSupportedPatchProperties	Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. These properties are not patchable. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L104
`❌` ResourceNameRestriction	The resource name parameter 'channelName' should be defined with a 'pattern' restriction. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L304
`❌` RepeatedPathInfo	The 'channelName' already appears in the path, please don't repeat it in the request body. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L335
`❌` PatchResponseCodes	Synchronous PATCH operations must have responses with 200 and default return codes. They also must not have other response codes. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L375
`❌` UnSupportedPatchProperties	Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. These properties are not patchable. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L405
`❌` ResourceNameRestriction	The resource name parameter 'channelName' should be defined with a 'pattern' restriction. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L556
`❌` ResourceNameRestriction	The resource name parameter 'channelName' should be defined with a 'pattern' restriction. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L646
`❌` OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.BotService/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L807
`❌` OperationsApiSchemaUsesCommonTypes	Operations API path must follow the schema provided in the common types. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L808
`❌` PatchResponseCodes	Synchronous PATCH operations must have responses with 200 and default return codes. They also must not have other response codes. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1009
`❌` UnSupportedPatchProperties	Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. These properties are not patchable. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1030
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1222
`❌` GetOperation200	The get operation should only return 200. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1265
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1265
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1272
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1308
`❌` ResourceNameRestriction	The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1325
`❌` PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1370
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1497
`❌` MissingTypeObject	The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1660
`❌` MissingTypeObject	The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1713
`❌` MissingTypeObject	The schema 'BotProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1784
`❌` MissingTypeObject	The schema 'BotResponseList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L2005
`❌` ArmResourcePropertiesBag	Top level property names should not be repeated inside the properties bag for ARM resource 'BotChannel'. Properties [properties.location] conflict with ARM top level properties. Please rename these. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L2082
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L2111
`❌` MissingTypeObject	The schema 'AlexaChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L2198
`❌` MissingTypeObject	The schema 'FacebookChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L2241
`❌` MissingTypeObject	The schema 'FacebookPage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L2281

️❌Avocado: 6 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` MISSING_APIS_IN_DEFAULT_TAG	The default tag should contain all APIs. The API path `/providers/Microsoft.BotService/botServices/checkNameAvailability` is not in the default tag. Please make sure the missing API swaggers are in the default tag. readme: specification/botservice/resource-manager/readme.md json: Microsoft.BotService/preview/2017-12-01/botservice.json
`❌` MISSING_APIS_IN_DEFAULT_TAG	The default tag should contain all APIs. The API path `/subscriptions/{}/resourceGroups/{}/providers/Microsoft.BotService/botServices/{}/Connections/{}/listWithSecrets` is not in the default tag. Please make sure the missing API swaggers are in the default tag. readme: specification/botservice/resource-manager/readme.md json: Microsoft.BotService/preview/2018-07-12/botservice.json
`❌` MISSING_APIS_IN_DEFAULT_TAG	The default tag should contain all APIs. The API path `/subscriptions/{}/resourceGroups/{}/providers/Microsoft.BotService/botServices/{}/Connections/{}` is not in the default tag. Please make sure the missing API swaggers are in the default tag. readme: specification/botservice/resource-manager/readme.md json: Microsoft.BotService/preview/2018-07-12/botservice.json
`❌` MISSING_APIS_IN_DEFAULT_TAG	The default tag should contain all APIs. The API path `/providers/Microsoft.BotService/checkEnterpriseChannelNameAvailability` is not in the default tag. Please make sure the missing API swaggers are in the default tag. readme: specification/botservice/resource-manager/readme.md json: Microsoft.BotService/preview/2018-07-12/botservice.json
`❌` MISSING_APIS_IN_DEFAULT_TAG	The default tag should contain all APIs. The API path `/subscriptions/{}/resourceGroups/{}/providers/Microsoft.BotService/enterpriseChannels` is not in the default tag. Please make sure the missing API swaggers are in the default tag. readme: specification/botservice/resource-manager/readme.md json: Microsoft.BotService/preview/2018-07-12/botservice.json
`❌` MISSING_APIS_IN_DEFAULT_TAG	The default tag should contain all APIs. The API path `/subscriptions/{}/resourceGroups/{}/providers/Microsoft.BotService/enterpriseChannels/{}` is not in the default tag. Please make sure the missing API swaggers are in the default tag. readme: specification/botservice/resource-manager/readme.md json: Microsoft.BotService/preview/2018-07-12/botservice.json

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-10-09T08:22:10Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-10-09T08:22:19Z

Swagger Validation Report

️🔄BreakingChange inProgress [Detail]

️⌛Breaking Change(Cross-Version) pending [Detail]

️⌛CredScan pending [Detail]

️🔄LintDiff inProgress [Detail]

️🔄Avocado inProgress [Detail]

️⌛SwaggerAPIView pending [Detail]

️⌛TypeSpecAPIView pending [Detail]

️🔄ModelValidation inProgress [Detail]

️⌛SemanticValidation pending [Detail]

️⌛PoliCheck pending [Detail]

️⌛PrettierCheck pending [Detail]

️⌛SpellCheck pending [Detail]

️🔄Lint(RPaaS) inProgress [Detail]

️⌛PR Summary pending [Detail]

️⌛Automated merging requirements met pending [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

ssss141414 · 2023-10-09T09:35:37Z

/pr RequestMerge

ms-zhenhua · 2023-10-10T00:32:17Z

/azp run

azure-pipelines · 2023-10-10T00:32:34Z

Azure Pipelines successfully started running 3 pipeline(s).

openapi-pipeline-app · 2023-10-10T00:49:20Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

…n stable/2022-09-15 (#25441) * exactly copy * new version * fix validation * fix swagger lint * fix comments * fix comments * fix refer error * fix swagger modal validation * change common-types from v1 to v5 * remove duplicate schema * fix new lint error * fix lint error * fix example * prettier * fix comments

azure-sdk mentioned this pull request Aug 22, 2023

[AutoPR botservice] [Hub Generated] Review request for Microsoft.BotService to add version stable/2022-09-15 azure-sdk/azure-resource-manager-schemas#3125

Closed

AzureRestAPISpecReview added new-api-version resource-manager labels Aug 22, 2023

ssss141414 marked this pull request as ready for review August 24, 2023 16:54

openapi-assignment-bot bot assigned rkmanda Aug 24, 2023

AzureRestAPISpecReview added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 24, 2023

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Aug 24, 2023

sjanamma reviewed Sep 1, 2023

View reviewed changes

...source-manager/Microsoft.BotService/preview/2023-09-15-preview/networksecurityperimeter.json Outdated Show resolved Hide resolved

sjanamma added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 1, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 1, 2023

github-actions bot added the MergeRequested label Sep 10, 2023

rkmanda removed the MergeRequested label Sep 12, 2023

ssss141414 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 13, 2023

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 13, 2023

ssss141414 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 13, 2023

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 13, 2023

ssss141414 removed the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 13, 2023

AzureRestAPISpecReview added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 25, 2023

openapi-workflow-bot bot removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Oct 9, 2023

ms-zhenhua added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 9, 2023

kazrael2119 added the Approved-SdkBreakingChange-JavaScript label Oct 9, 2023

Alancere reviewed Oct 9, 2023

View reviewed changes

...source-manager/Microsoft.BotService/preview/2023-09-15-preview/networksecurityperimeter.json Show resolved Hide resolved

fix comments

81be8fe

AzureRestAPISpecReview added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 9, 2023

openapi-workflow-bot bot removed the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 9, 2023

Alancere added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Oct 9, 2023

ms-zhenhua added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 9, 2023

github-actions bot added the MergeRequested label Oct 9, 2023

AzureRestAPISpecReview added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 10, 2023

openapi-workflow-bot bot removed the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 10, 2023

ms-zhenhua approved these changes Oct 10, 2023

View reviewed changes

ms-zhenhua merged commit 4e7b46a into main Oct 10, 2023
28 of 31 checks passed

ms-zhenhua deleted the ssss141414-botservice-Microsoft.BotService-2022-09-15 branch October 10, 2023 00:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.BotService to add version stable/2022-09-15 #25441

[Hub Generated] Review request for Microsoft.BotService to add version stable/2022-09-15 #25441

ssss141414 commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

openapi-workflow-bot bot commented Sep 1, 2023

rkmanda commented Sep 12, 2023

raosuhas commented Sep 26, 2023

openapi-pipeline-app bot commented Oct 9, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 9, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 9, 2023

ssss141414 commented Oct 9, 2023

ms-zhenhua commented Oct 10, 2023

azure-pipelines bot commented Oct 10, 2023

openapi-pipeline-app bot commented Oct 10, 2023

[Hub Generated] Review request for Microsoft.BotService to add version stable/2022-09-15 #25441

[Hub Generated] Review request for Microsoft.BotService to add version stable/2022-09-15 #25441

Conversation

ssss141414 commented Aug 22, 2023 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

openapi-pipeline-app bot commented Aug 22, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Aug 22, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Aug 22, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 22, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Sep 1, 2023

rkmanda commented Sep 12, 2023

raosuhas commented Sep 26, 2023

openapi-pipeline-app bot commented Oct 9, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Oct 9, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Oct 9, 2023

Swagger Validation Report

ssss141414 commented Oct 9, 2023

ms-zhenhua commented Oct 10, 2023

azure-pipelines bot commented Oct 10, 2023

openapi-pipeline-app bot commented Oct 10, 2023

ssss141414 commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 22, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 9, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 9, 2023 •

edited

Loading