From d09847481005a8d77cfd91a71762e404e27ccaff Mon Sep 17 00:00:00 2001 From: Chris Jiang Date: Tue, 11 Jul 2023 15:09:25 -0700 Subject: [PATCH 1/5] Add properties for os patching --- .../machineLearningServices.json | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json index 3cea273d7dad..f78572d53c0f 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json @@ -2175,6 +2175,10 @@ "description": "ComputeInstance version.", "$ref": "#/definitions/ComputeInstanceVersion", "readOnly": true + }, + "autoRestartAfterUpdates": { + "type": "boolean", + "description": "Indicates whether this compute instance allow auto reboot when reboot is required after os patching." } } }, @@ -2875,6 +2879,18 @@ "isLatestOsImageVersion": { "type": "boolean", "description": "Specifies whether this compute instance is running on the latest operating system image." + }, + "rebootPending": { + "type": "boolean", + "description": "Specifies whether this compute instance is pending for reboot to finish os patching." + }, + "patchStatus": { + "type": "string", + "description": "The os patching status." + }, + "latestUpdateTime": { + "type": "string", + "description": "Time of the lastest os patching." } } }, From e5e6d2da717462b6458988013debd47295b2bbb0 Mon Sep 17 00:00:00 2001 From: Chris Jiang Date: Mon, 17 Jul 2023 17:50:17 -0700 Subject: [PATCH 2/5] resolve comments --- .../machineLearningServices.json | 29 +++++++++++++------ 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json index 82f49be6264c..267cfd664064 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json @@ -2189,10 +2189,6 @@ "description": "ComputeInstance version.", "$ref": "#/definitions/ComputeInstanceVersion", "readOnly": true - }, - "autoRestartAfterUpdates": { - "type": "boolean", - "description": "Indicates whether this compute instance allow auto reboot when reboot is required after os patching." } } }, @@ -2894,15 +2890,30 @@ "type": "boolean", "description": "Specifies whether this compute instance is running on the latest operating system image." }, - "rebootPending": { - "type": "boolean", - "description": "Specifies whether this compute instance is pending for reboot to finish os patching." - }, + "osPatchingStatus": { + "readOnly": true, + "description": "Metadata about the os patching.", + "$ref": "#/definitions/osPatchingStatus" + } + } + }, + "osPatchingStatus": { + "type": "object", + "description": "Returns metadata about the os patching.", + "properties": { "patchStatus": { "type": "string", "description": "The os patching status." }, - "latestUpdateTime": { + "latestPatchTime": { + "type": "string", + "description": "Time of the lastest os patching." + }, + "rebootPending": { + "type": "boolean", + "description": "Specifies whether this compute instance is pending for reboot to finish os patching." + }, + "rebootRequiredTime": { "type": "string", "description": "Time of the lastest os patching." } From 7876859787e897a582a4e117d14cc842946b9d13 Mon Sep 17 00:00:00 2001 From: Chris Jiang Date: Mon, 17 Jul 2023 18:00:35 -0700 Subject: [PATCH 3/5] remove autorestartafterupdates --- .../preview/2023-08-01-preview/machineLearningServices.json | 4 ---- 1 file changed, 4 deletions(-) diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json index b39abf47011f..267cfd664064 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json @@ -2189,10 +2189,6 @@ "description": "ComputeInstance version.", "$ref": "#/definitions/ComputeInstanceVersion", "readOnly": true - }, - "autoRestartAfterUpdates": { - "type": "boolean", - "description": "Indicates whether this compute instance allow auto reboot when reboot is required after os patching." } } }, From 17cc0f7deaed69d00d3fd4cd5e4bbd7345520f8b Mon Sep 17 00:00:00 2001 From: Chris Jiang Date: Mon, 17 Jul 2023 20:18:16 -0700 Subject: [PATCH 4/5] update description --- .../preview/2023-08-01-preview/machineLearningServices.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json index 267cfd664064..3695ea5a93d9 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json @@ -2915,7 +2915,7 @@ }, "rebootRequiredTime": { "type": "string", - "description": "Time of the lastest os patching." + "description": "Ubuntu requires reboot time after os patching." } } }, From 0e5ee89dad130668ff98c20315be3a3f6f62c3c3 Mon Sep 17 00:00:00 2001 From: Chris Jiang Date: Mon, 17 Jul 2023 21:53:11 -0700 Subject: [PATCH 5/5] rename property --- .../preview/2023-08-01-preview/machineLearningServices.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json index 3695ea5a93d9..539e4a7d0a9a 100644 --- a/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json +++ b/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-08-01-preview/machineLearningServices.json @@ -2913,9 +2913,9 @@ "type": "boolean", "description": "Specifies whether this compute instance is pending for reboot to finish os patching." }, - "rebootRequiredTime": { + "scheduledRebootTime": { "type": "string", - "description": "Ubuntu requires reboot time after os patching." + "description": "Time of scheduled reboot." } } },