From 959849373578f7b866dd248c31ccc4d308c7f0ca Mon Sep 17 00:00:00 2001 From: tombuildsstuff Date: Wed, 1 Feb 2023 12:37:14 +0100 Subject: [PATCH 1/3] redis: adding the missing `notify-keyspace-events` value This can be defined via the additionalProperties in the Track1 SDK, but should be defined explicitly since it's included in the description --- .../Microsoft.Cache/stable/2021-06-01/redis.json | 4 ++++ .../Microsoft.Cache/stable/2022-05-01/redis.json | 4 ++++ .../Microsoft.Cache/stable/2022-06-01/redis.json | 4 ++++ 3 files changed, 12 insertions(+) diff --git a/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json b/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json index dab2bcce4230..81ad6773a8d9 100644 --- a/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json +++ b/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json @@ -1933,6 +1933,10 @@ "description": "The max clients config", "readOnly": true }, + "notify-keyspace-events": { + "type": "string", + "description": "The KeySpace Events which should be monitored." + }, "preferred-data-archive-auth-method": { "type": "string", "description": "Preferred auth method to communicate to storage account used for data archive, specify SAS or ManagedIdentity, default value is SAS", diff --git a/specification/redis/resource-manager/Microsoft.Cache/stable/2022-05-01/redis.json b/specification/redis/resource-manager/Microsoft.Cache/stable/2022-05-01/redis.json index 021f182cf121..944a714609e0 100644 --- a/specification/redis/resource-manager/Microsoft.Cache/stable/2022-05-01/redis.json +++ b/specification/redis/resource-manager/Microsoft.Cache/stable/2022-05-01/redis.json @@ -1947,6 +1947,10 @@ "description": "The max clients config", "readOnly": true }, + "notify-keyspace-events": { + "type": "string", + "description": "The KeySpace Events which should be monitored." + }, "preferred-data-archive-auth-method": { "type": "string", "description": "Preferred auth method to communicate to storage account used for data archive, specify SAS or ManagedIdentity, default value is SAS", diff --git a/specification/redis/resource-manager/Microsoft.Cache/stable/2022-06-01/redis.json b/specification/redis/resource-manager/Microsoft.Cache/stable/2022-06-01/redis.json index 94e5eeb9a209..1e660fdba82a 100644 --- a/specification/redis/resource-manager/Microsoft.Cache/stable/2022-06-01/redis.json +++ b/specification/redis/resource-manager/Microsoft.Cache/stable/2022-06-01/redis.json @@ -1947,6 +1947,10 @@ "description": "The max clients config", "readOnly": true }, + "notify-keyspace-events": { + "type": "string", + "description": "The KeySpace Events which should be monitored." + }, "preferred-data-archive-auth-method": { "type": "string", "description": "Preferred auth method to communicate to storage account used for data archive, specify SAS or ManagedIdentity, default value is SAS", From 919e6196aad3afcff45632634893e9fe3d178f82 Mon Sep 17 00:00:00 2001 From: tombuildsstuff Date: Fri, 3 Feb 2023 09:30:34 +0100 Subject: [PATCH 2/3] redis: updating the description per PR review --- .../Microsoft.Cache/stable/2021-06-01/redis.json | 2 +- .../Microsoft.Cache/stable/2022-05-01/redis.json | 2 +- .../Microsoft.Cache/stable/2022-06-01/redis.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json b/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json index 81ad6773a8d9..3c5ba1edf739 100644 --- a/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json +++ b/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json @@ -1935,7 +1935,7 @@ }, "notify-keyspace-events": { "type": "string", - "description": "The KeySpace Events which should be monitored." + "description": "The keyspace events which should be monitored." }, "preferred-data-archive-auth-method": { "type": "string", diff --git a/specification/redis/resource-manager/Microsoft.Cache/stable/2022-05-01/redis.json b/specification/redis/resource-manager/Microsoft.Cache/stable/2022-05-01/redis.json index 944a714609e0..b2614cdfbaa9 100644 --- a/specification/redis/resource-manager/Microsoft.Cache/stable/2022-05-01/redis.json +++ b/specification/redis/resource-manager/Microsoft.Cache/stable/2022-05-01/redis.json @@ -1949,7 +1949,7 @@ }, "notify-keyspace-events": { "type": "string", - "description": "The KeySpace Events which should be monitored." + "description": "The keyspace events which should be monitored." }, "preferred-data-archive-auth-method": { "type": "string", diff --git a/specification/redis/resource-manager/Microsoft.Cache/stable/2022-06-01/redis.json b/specification/redis/resource-manager/Microsoft.Cache/stable/2022-06-01/redis.json index 1e660fdba82a..21e0cd459449 100644 --- a/specification/redis/resource-manager/Microsoft.Cache/stable/2022-06-01/redis.json +++ b/specification/redis/resource-manager/Microsoft.Cache/stable/2022-06-01/redis.json @@ -1949,7 +1949,7 @@ }, "notify-keyspace-events": { "type": "string", - "description": "The KeySpace Events which should be monitored." + "description": "The keyspace events which should be monitored." }, "preferred-data-archive-auth-method": { "type": "string", From 159377bbe82ea0e0ba5aa208221e1646e94c1e9b Mon Sep 17 00:00:00 2001 From: tombuildsstuff Date: Mon, 13 Nov 2023 10:29:45 +0100 Subject: [PATCH 3/3] redis: adding `notify-keyspace-events` to API Versions `2023-05-01-preview` and `2023-08-01` --- .../Microsoft.Cache/preview/2023-05-01-preview/redis.json | 4 ++++ .../Microsoft.Cache/stable/2023-08-01/redis.json | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/specification/redis/resource-manager/Microsoft.Cache/preview/2023-05-01-preview/redis.json b/specification/redis/resource-manager/Microsoft.Cache/preview/2023-05-01-preview/redis.json index 64f46ff3c6f8..de4758f38ef3 100644 --- a/specification/redis/resource-manager/Microsoft.Cache/preview/2023-05-01-preview/redis.json +++ b/specification/redis/resource-manager/Microsoft.Cache/preview/2023-05-01-preview/redis.json @@ -2216,6 +2216,10 @@ "description": "The max clients config", "readOnly": true }, + "notify-keyspace-events": { + "type": "string", + "description": "The keyspace events which should be monitored." + }, "preferred-data-archive-auth-method": { "type": "string", "description": "Preferred auth method to communicate to storage account used for data archive, specify SAS or ManagedIdentity, default value is SAS", diff --git a/specification/redis/resource-manager/Microsoft.Cache/stable/2023-08-01/redis.json b/specification/redis/resource-manager/Microsoft.Cache/stable/2023-08-01/redis.json index f6e928bdb6c0..4c6dc6d5b471 100644 --- a/specification/redis/resource-manager/Microsoft.Cache/stable/2023-08-01/redis.json +++ b/specification/redis/resource-manager/Microsoft.Cache/stable/2023-08-01/redis.json @@ -2286,6 +2286,10 @@ "description": "The max clients config", "readOnly": true }, + "notify-keyspace-events": { + "type": "string", + "description": "The keyspace events which should be monitored." + }, "preferred-data-archive-auth-method": { "type": "string", "description": "Preferred auth method to communicate to storage account used for data archive, specify SAS or ManagedIdentity, default value is SAS",