Fix name and displayName issues #19538

ramoka178 · 2022-06-20T22:01:03Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2022-06-20T22:21:31Z

Swagger Validation Report

️❌BreakingChange: 4 Errors, 2 Warnings failed [Detail]

compared swaggers (via Oad v0.9.6)]	new version	base version
management.json	2020-10-01(3708f6c)	2020-10-01(main)
management.json	2021-04-01(3708f6c)	2021-04-01(main)

Rule	Message
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'name' in response that was not found in the old version. New: Microsoft.Management/stable/2020-10-01/management.json#L1585:7 Old: Microsoft.Management/stable/2020-10-01/management.json#L1570:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'displayName' in response that was not found in the old version. New: Microsoft.Management/stable/2020-10-01/management.json#L1585:7 Old: Microsoft.Management/stable/2020-10-01/management.json#L1570:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'name' in response that was not found in the old version. New: Microsoft.Management/stable/2021-04-01/management.json#L1614:7 Old: Microsoft.Management/stable/2021-04-01/management.json#L1592:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'displayName' in response that was not found in the old version. New: Microsoft.Management/stable/2021-04-01/management.json#L1614:7 Old: Microsoft.Management/stable/2021-04-01/management.json#L1592:7
⚠️ 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.Management/stable/2020-10-01/management.json#L1174:9 Old: Microsoft.Management/stable/2020-10-01/management.json#L1169:9
⚠️ 1026 - TypeChanged	The new version has a different type 'object' than the previous one ''. New: Microsoft.Management/stable/2021-04-01/management.json#L1177:9 Old: Microsoft.Management/stable/2021-04-01/management.json#L1177:9

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v1.13.0)	new version	base version
package-2021-04	package-2021-04(3708f6c)	package-2021-04(main)
package-2020-10	package-2020-10(3708f6c)	package-2020-10(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Management/stable/2020-10-01/management.json#L1336
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Management/stable/2020-10-01/management.json#L1922
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Management/stable/2020-10-01/management.json#L1983
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Management/stable/2020-10-01/management.json#L2048
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Management/stable/2020-10-01/management.json#L2123
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Management/stable/2020-10-01/management.json#L675
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Management/stable/2021-04-01/management.json#L675
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Management/stable/2020-10-01/management.json#L1610
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Management/stable/2020-10-01/management.json#L1679
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Management/stable/2020-10-01/management.json#L1684
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Management/stable/2020-10-01/management.json#L1690
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Management/stable/2020-10-01/management.json#L2091
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Management/stable/2020-10-01/management.json#L2099
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Management/stable/2021-04-01/management.json#L1639
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Management/stable/2021-04-01/management.json#L1708
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Management/stable/2021-04-01/management.json#L1713
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Management/stable/2021-04-01/management.json#L1719
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Management/stable/2021-04-01/management.json#L2146
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Management/stable/2021-04-01/management.json#L2154
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.Management/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Management/stable/2020-10-01/management.json#L693
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.Management/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Management/stable/2021-04-01/management.json#L693
`❌` R4019 - GetCollectionResponseSchema	The response in the GET collection operation 'ManagementGroupsList' does not match the response definition in the individual GET operation 'ManagementGroupsGet' . Location: Microsoft.Management/stable/2020-10-01/management.json#L51
`❌` R4019 - GetCollectionResponseSchema	The response in the GET collection operation 'ManagementGroupsList' does not match the response definition in the individual GET operation 'ManagementGroupsGet' . Location: Microsoft.Management/stable/2021-04-01/management.json#L51
`❌` R4037 - MissingTypeObject	The schema 'ErrorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Management/stable/2020-10-01/management.json#L896
`❌` R4037 - MissingTypeObject	The schema 'ErrorDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Management/stable/2020-10-01/management.json#L905
`❌` R4037 - MissingTypeObject	The schema 'OperationDisplayProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Management/stable/2020-10-01/management.json#L937
`❌` R4037 - MissingTypeObject	The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Management/stable/2020-10-01/management.json#L962
`❌` R4037 - MissingTypeObject	The schema 'CheckNameAvailabilityResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Management/stable/2020-10-01/management.json#L980
`❌` R4037 - MissingTypeObject	The schema 'TenantBackfillStatusResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Management/stable/2020-10-01/management.json#L1016
`❌` R4037 - MissingTypeObject	The schema 'ManagementGroupListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Management/stable/2020-10-01/management.json#L1063

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

The following errors/warnings are introduced by current PR:

|:speech_balloon: |"readme":"managementgroups/resource-manager/readme.md",
"tag":"package-2021-04",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0 -> 1.11.0)"|
|:speech_balloon: |"readme":"managementgroups/resource-manager/readme.md",
"tag":"package-2021-04",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0->1.11.0)"|
|:speech_balloon: |"readme":"managementgroups/resource-manager/readme.md",
"tag":"package-2021-04",
"details":"> Installing AutoRest extension '@autorest/modelerfour' (4.21.4 -> 4.21.4)"|
|:speech_balloon: |"readme":"managementgroups/resource-manager/readme.md",
"tag":"package-2021-04",
"details":"> Installed AutoRest extension '@autorest/modelerfour' (4.21.4->4.21.4)"|
|:speech_balloon: |"readme":"managementgroups/resource-manager/readme.md",
"tag":"package-2021-04",
"details":"Autorest completed in 11.34s. 0 files generated."|
|:speech_balloon: |"readme":"managementgroups/resource-manager/readme.md",
"tag":"package-2020-10",
"details":"Autorest completed in 3.51s. 0 files generated."|

The following errors/warnings exist before current PR submission:

|:speech_balloon: |"readme":"managementgroups/resource-manager/readme.md",
"tag":"package-2021-04",
"details":"AutoRest core version selected from configuration: ^3.2.0."|
|:speech_balloon: |"readme":"managementgroups/resource-manager/readme.md",
"tag":"package-2020-10",
"details":"AutoRest core version selected from configuration: ^3.2.0."|
|:speech_balloon: |"readme":"managementgroups/resource-manager/readme.md",
"tag":"package-2020-10",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0->1.11.0)"|
|:speech_balloon: |"readme":"managementgroups/resource-manager/readme.md",
"tag":"package-2020-10",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.21.4->4.21.4)"|

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-06-20T22:21:31Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - armmanagementgroups - Approved - 2.0.0

+	Type of `SubscriptionUnderManagementGroupProperties.Parent` has been changed from `*DescendantParentGroupInfo` to `*ParentGroupBagInfo`

❌azure-sdk-for-js - @azure/arm-managementgroups - Approved - 3.0.0

+	Removed Enum KnownManagementGroupChildType
+	Removed Enum KnownPermissions

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-managementgroups - 1.0.0

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from a7de71e. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/managementgroups/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from a7de71e. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.

️✔️track2_azure-mgmt-managementgroups [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added model EntitySearchType
info	[Changelog]   - Added model EntityViewParameterType
info	[Changelog]   - Added model ManagementGroupExpandType
info	[Changelog]   - Added model ParentGroupBagInfo

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from a7de71e. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-managementgroups [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from a7de71e. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armmanagementgroups [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `SubscriptionUnderManagementGroupProperties.Parent` has been changed from `*DescendantParentGroupInfo` to `*ParentGroupBagInfo`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New struct `ParentGroupBagInfo`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 2 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from a7de71e. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  deprecated @azure/[email protected]: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-managementgroups [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-managementgroups-3.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface ParentGroupBagInfo
info	[Changelog]   - Added Type Alias EntitySearchType
info	[Changelog]   - Added Type Alias EntityViewParameterType
info	[Changelog]   - Added Type Alias ManagementGroupExpandType
info	[Changelog]   - Added Enum KnownEntitySearchType
info	[Changelog]   - Added Enum KnownEntityViewParameterType
info	[Changelog]   - Added Enum KnownManagementGroupExpandType
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Removed Enum KnownEnum0
info	[Changelog]   - Removed Enum KnownEnum2
info	[Changelog]   - Removed Enum KnownEnum3
info	[Changelog]   - Removed Enum KnownManagementGroupChildType
info	[Changelog]   - Removed Enum KnownPermissions

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from a7de71e. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️managementgroups [View full logs]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from a7de71e. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.ManagementGroupsApi [View full logs] [Release SDK Changes]
- Az.ManagementGroupsApi.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-06-20T22:41:04Z

Hi, @ramoka178 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-workflow-bot · 2022-06-20T22:54:08Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

openapi-workflow-bot · 2022-06-20T22:57:23Z

Hi @ramoka178, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

msyyc · 2022-06-23T01:29:05Z

Hi @JeffreyRichter Please help to review swagger breaking change, here is the context from @ramoka178 : https://teams.microsoft.com/l/message/19:[email protected]/1655922798698?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=a5e9b41d-1b0a-471d-a170-8ce202fa30b1&parentMessageId=1655922798698&teamName=Azure%20API%20and%20Tools%20Support%20(pka.%20OpenAPI%20Hub%20Support)&channelName=General&createdTime=1655922798698

msyyc · 2022-06-23T01:30:04Z

Hi @ramoka178 Please fix ModelValidation, here is the reason and solution: https://github.com/Azure/azure-rest-api-specs/pull/19538/checks?check_run_id=6974957832

msyyc · 2022-06-23T01:51:41Z

/azp run

azure-pipelines · 2022-06-23T01:51:49Z

Azure Pipelines successfully started running 1 pipeline(s).

…into ramoka/managementgroups/swaggerFixes

ramoka178 · 2022-06-23T17:18:30Z

Hi @ramoka178 Please fix ModelValidation, here is the reason and solution: https://github.com/Azure/azure-rest-api-specs/pull/19538/checks?check_run_id=6974957832

Fixed this issue

…into ramoka/managementgroups/swaggerFixes

msyyc · 2022-06-28T00:58:54Z

Hi @qiaozha @tadelesh please help confirm sdk breaking change.

tadelesh · 2022-06-28T02:00:06Z

Hi @qiaozha @tadelesh please help confirm sdk breaking change.

Approved for Go. @ramoka178 FYI, property change will cause SDK breaking.

ramoka178 added 2 commits June 20, 2022 14:52

fix name displayName

9d5ee07

fix enum issue

15e4066

openapi-assignment-bot bot assigned msyyc Jun 20, 2022

azure-sdk mentioned this pull request Jun 20, 2022

[AutoPR armmanagementgroups] Fix name and displayName issues azure-sdk/azure-sdk-for-go#1512

Closed

openapi-workflow-bot bot added the FixS360 label Jun 20, 2022

openapi-pipeline-app bot added CI-FixRequiredOnFailure NewApiVersionRequired labels Jun 20, 2022

openapi-pipeline-app bot added CI-BreakingChange-Go CI-BreakingChange-JavaScript labels Jun 20, 2022

msyyc mentioned this pull request Jun 23, 2022

[ManagementGroups] Update readme.python.md #19562

Merged

25 tasks

azure-sdk mentioned this pull request Jun 23, 2022

[AutoPR track2_azure-mgmt-managementgroups] Fix name and displayName issues azure-sdk/azure-sdk-for-python#659

Closed

ramoka178 added 2 commits June 23, 2022 09:20

Swagger ModelValidation fixes

9d7f8e2

Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs …

ec66046

…into ramoka/managementgroups/swaggerFixes

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Jun 23, 2022

ramoka178 added 2 commits June 24, 2022 13:51

fixes

7f9af20

Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs …

b4ce106

…into ramoka/managementgroups/swaggerFixes

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Jun 24, 2022

ramoka178 added 4 commits June 24, 2022 15:13

fix enum

c026449

parsing

0bd0be7

json fix

876bfd5

dummy commit

f9d8025

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Jun 27, 2022

ramoka178 added 2 commits June 27, 2022 09:48

adding type

62361d3

json fix

9dd7f27

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Jun 27, 2022

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jun 27, 2022

nextlink fix

716f55c

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Jun 27, 2022

ramoka178 added 2 commits June 27, 2022 16:02

remove @ from mgmt

9b0cba0

nextlink revert

3708f6c

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Jun 27, 2022

tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Jun 28, 2022

qiaozha added the Approved-SdkBreakingChange-JavaScript label Jun 28, 2022

msyyc approved these changes Jun 28, 2022

View reviewed changes

msyyc merged commit a7de71e into main Jun 28, 2022

msyyc deleted the ramoka/managementgroups/swaggerFixes branch June 28, 2022 02:12

ramoka178 mentioned this pull request Feb 28, 2023

MGRP S360 Vuln #22832

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix name and displayName issues #19538

Fix name and displayName issues #19538

ramoka178 commented Jun 20, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jun 20, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jun 20, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Jun 20, 2022

openapi-workflow-bot bot commented Jun 20, 2022

openapi-workflow-bot bot commented Jun 20, 2022

msyyc commented Jun 23, 2022

msyyc commented Jun 23, 2022

msyyc commented Jun 23, 2022

azure-pipelines bot commented Jun 23, 2022

ramoka178 commented Jun 23, 2022

msyyc commented Jun 28, 2022

tadelesh commented Jun 28, 2022

Fix name and displayName issues #19538

Fix name and displayName issues #19538

Conversation

ramoka178 commented Jun 20, 2022 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Jun 20, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jun 20, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Jun 20, 2022

openapi-workflow-bot bot commented Jun 20, 2022

openapi-workflow-bot bot commented Jun 20, 2022

msyyc commented Jun 23, 2022

msyyc commented Jun 23, 2022

msyyc commented Jun 23, 2022

azure-pipelines bot commented Jun 23, 2022

ramoka178 commented Jun 23, 2022

msyyc commented Jun 28, 2022

tadelesh commented Jun 28, 2022

ramoka178 commented Jun 20, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jun 20, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jun 20, 2022 •

edited

Loading