Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.AlertsManagement to add version preview/2019-03-01-preview #17366

Conversation

inballeibovitch
Copy link
Contributor

@inballeibovitch inballeibovitch commented Jan 16, 2022

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @inballeibovitch Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 16, 2022

    Swagger Validation Report

    ️❌BreakingChange: 11 Errors, 0 Warnings failed [Detail]
    Rule Message
    1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'alertRule' in response that was not found in the old version.
    New: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L909:7
    Old: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L899:7
    1041 - AddedPropertyInResponse The new version has a new property 'actionStatus' in response that was not found in the old version.
    New: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L909:7
    Old: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L899:7
    1041 - AddedPropertyInResponse The new version has a new property 'description' in response that was not found in the old version.
    New: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L909:7
    Old: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L899:7
    1041 - AddedPropertyInResponse The new version has a new property 'actionStatus' in response that was not found in the old version.
    New: Microsoft.AlertsManagement/preview/2019-03-01-preview/AlertsManagement.json#L1044:7
    Old: Microsoft.AlertsManagement/preview/2019-03-01-preview/AlertsManagement.json#L1034:7
    1041 - AddedPropertyInResponse The new version has a new property 'description' in response that was not found in the old version.
    New: Microsoft.AlertsManagement/preview/2019-03-01-preview/AlertsManagement.json#L1044:7
    Old: Microsoft.AlertsManagement/preview/2019-03-01-preview/AlertsManagement.json#L1034:7
    1041 - AddedPropertyInResponse The new version has a new property 'actionStatus' in response that was not found in the old version.
    New: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L856:7
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L846:7
    1041 - AddedPropertyInResponse The new version has a new property 'description' in response that was not found in the old version.
    New: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L856:7
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L846:7
    1041 - AddedPropertyInResponse The new version has a new property 'actionStatus' in response that was not found in the old version.
    New: Microsoft.AlertsManagement/stable/2018-05-05/AlertsManagement.json#L1036:7
    Old: Microsoft.AlertsManagement/stable/2018-05-05/AlertsManagement.json#L1026:7
    1041 - AddedPropertyInResponse The new version has a new property 'description' in response that was not found in the old version.
    New: Microsoft.AlertsManagement/stable/2018-05-05/AlertsManagement.json#L1036:7
    Old: Microsoft.AlertsManagement/stable/2018-05-05/AlertsManagement.json#L1026:7
    1041 - AddedPropertyInResponse The new version has a new property 'actionStatus' in response that was not found in the old version.
    New: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L898:7
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L888:7
    1041 - AddedPropertyInResponse The new version has a new property 'description' in response that was not found in the old version.
    New: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L898:7
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L888:7
    ️⚠️LintDiff: 8 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isSuppressed
    Location: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L900
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isSuppressed
    Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L847
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isSuppressed
    Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L847
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isSuppressed
    Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L847
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isSuppressed
    Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L847
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isSuppressed
    Location: Microsoft.AlertsManagement/stable/2018-05-05/AlertsManagement.json#L1027
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isSuppressed
    Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L889
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isSuppressed
    Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L889


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L852
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L873
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L852
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L873
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'application Insights', for definition: 'alertsSummaryByMonitorService' must follow camelCase style. Example: 'application Insights'.
    Location: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L1403
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'log Analytics', for definition: 'alertsSummaryByMonitorService' must follow camelCase style. Example: 'log Analytics'.
    Location: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L1407
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'infrastructure Insights', for definition: 'alertsSummaryByMonitorService' must follow camelCase style. Example: 'infrastructure Insights'.
    Location: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L1423
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'activityLog Administrative', for definition: 'alertsSummaryByMonitorService' must follow camelCase style. Example: 'activityLog Administrative'.
    Location: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L1427
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'activityLog Security', for definition: 'alertsSummaryByMonitorService' must follow camelCase style. Example: 'activityLog Security'.
    Location: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L1431
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'activityLog Recommendation', for definition: 'alertsSummaryByMonitorService' must follow camelCase style. Example: 'activityLog Recommendation'.
    Location: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L1435
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'activityLog Policy', for definition: 'alertsSummaryByMonitorService' must follow camelCase style. Example: 'activityLog Policy'.
    Location: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L1439
    R3016 - DefinitionsPropertiesNamesCamelCase Property named: 'activityLog Autoscale', for definition: 'alertsSummaryByMonitorService' must follow camelCase style. Example: 'activityLog Autoscale'.
    Location: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L1443
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/microsoft.alertsManagement/smartDetectorAlertRules'
    Location: Microsoft.AlertsManagement/stable/2019-06-01/SmartDetectorAlertRulesApi.json#L37
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.alertsManagement/smartDetectorAlertRules'
    Location: Microsoft.AlertsManagement/stable/2019-06-01/SmartDetectorAlertRulesApi.json#L79
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.alertsManagement/smartDetectorAlertRules/{alertRuleName}'
    Location: Microsoft.AlertsManagement/stable/2019-06-01/SmartDetectorAlertRulesApi.json#L124
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/microsoft.alertsManagement/smartDetectorAlertRules'
    Location: Microsoft.AlertsManagement/stable/2019-03-01/SmartDetectorAlertRulesApi.json#L37
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.alertsManagement/smartDetectorAlertRules'
    Location: Microsoft.AlertsManagement/stable/2019-03-01/SmartDetectorAlertRulesApi.json#L76
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.alertsManagement/smartDetectorAlertRules/{alertRuleName}'
    Location: Microsoft.AlertsManagement/stable/2019-03-01/SmartDetectorAlertRulesApi.json#L118
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/microsoft.alertsManagement/smartDetectorAlertRules'
    Location: Microsoft.AlertsManagement/stable/2021-04-01/SmartDetectorAlertRulesApi.json#L37
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.alertsManagement/smartDetectorAlertRules'
    Location: Microsoft.AlertsManagement/stable/2021-04-01/SmartDetectorAlertRulesApi.json#L79
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.alertsManagement/smartDetectorAlertRules/{alertRuleName}'
    Location: Microsoft.AlertsManagement/stable/2021-04-01/SmartDetectorAlertRulesApi.json#L124
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.alertsManagement' doesn't match the namespace.
    Location: Microsoft.AlertsManagement/stable/2019-06-01/SmartDetectorAlertRulesApi.json#L37
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.alertsManagement' doesn't match the namespace.
    Location: Microsoft.AlertsManagement/stable/2019-06-01/SmartDetectorAlertRulesApi.json#L79
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.alertsManagement' doesn't match the namespace.
    Location: Microsoft.AlertsManagement/stable/2019-06-01/SmartDetectorAlertRulesApi.json#L124
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.alertsManagement' doesn't match the namespace.
    Location: Microsoft.AlertsManagement/stable/2019-03-01/SmartDetectorAlertRulesApi.json#L37
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.alertsManagement' doesn't match the namespace.
    Location: Microsoft.AlertsManagement/stable/2019-03-01/SmartDetectorAlertRulesApi.json#L76
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.alertsManagement' doesn't match the namespace.
    Location: Microsoft.AlertsManagement/stable/2019-03-01/SmartDetectorAlertRulesApi.json#L118
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.alertsManagement' doesn't match the namespace.
    Location: Microsoft.AlertsManagement/stable/2021-04-01/SmartDetectorAlertRulesApi.json#L37
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.alertsManagement' doesn't match the namespace.
    Location: Microsoft.AlertsManagement/stable/2021-04-01/SmartDetectorAlertRulesApi.json#L79
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'microsoft.alertsManagement' doesn't match the namespace.
    Location: Microsoft.AlertsManagement/stable/2021-04-01/SmartDetectorAlertRulesApi.json#L124
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/alertsmanagement/resource-manager/readme.md
    tag: specification/alertsmanagement/resource-manager/readme.md#tag-package-2021-08
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 16, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go-track2 - armalertsmanagement - 0.4.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-alertsmanagement - Approved - 1.0.0
    ️✔️azure-sdk-for-go - alertsmanagement/mgmt/2019-03-01/alertsmanagement - v61.2.0
    ️✔️azure-sdk-for-go - alertsmanagement/mgmt/2018-05-05/alertsmanagement - v61.2.0
    azure-sdk-for-go - preview/alertsmanagement/mgmt/2019-06-01-preview/alertsmanagement - v61.2.0
    +	Function `AlertsClient.GetAllComplete` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int32, AlertsSortByFields, string, string, TimeRange, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int64, AlertsSortByFields, SortOrder, string, TimeRange, string)`
    +	Function `AlertsClient.GetAllPreparer` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int32, AlertsSortByFields, string, string, TimeRange, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int64, AlertsSortByFields, SortOrder, string, TimeRange, string)`
    +	Function `AlertsClient.GetAll` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int32, AlertsSortByFields, string, string, TimeRange, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int64, AlertsSortByFields, SortOrder, string, TimeRange, string)`
    +	Function `SmartGroupsClient.GetAllComplete` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int32, SmartGroupsSortByFields, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int64, SmartGroupsSortByFields, SortOrder)`
    +	Function `SmartGroupsClient.GetAllPreparer` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int32, SmartGroupsSortByFields, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int64, SmartGroupsSortByFields, SortOrder)`
    +	Function `SmartGroupsClient.GetAll` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int32, SmartGroupsSortByFields, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int64, SmartGroupsSortByFields, SortOrder)`
    +	Type of `AlertsSummaryGroup.SmartGroupsCount` has been changed from `*int32` to `*int64`
    +	Type of `AlertsSummaryGroup.Total` has been changed from `*int32` to `*int64`
    +	Type of `AlertsSummaryGroupItem.Count` has been changed from `*int32` to `*int64`
    +	Type of `SmartGroupAggregatedProperty.Count` has been changed from `*int32` to `*int64`
    +	Type of `SmartGroupProperties.AlertsCount` has been changed from `*int32` to `*int64`
    azure-sdk-for-go - preview/alertsmanagement/mgmt/2019-05-05-preview/alertsmanagement - v61.2.0
    +	Function `AlertsClient.GetAllComplete` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int32, AlertsSortByFields, string, string, TimeRange, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int64, AlertsSortByFields, SortOrder, string, TimeRange, string)`
    +	Function `AlertsClient.GetAllPreparer` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int32, AlertsSortByFields, string, string, TimeRange, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int64, AlertsSortByFields, SortOrder, string, TimeRange, string)`
    +	Function `AlertsClient.GetAll` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int32, AlertsSortByFields, string, string, TimeRange, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int64, AlertsSortByFields, SortOrder, string, TimeRange, string)`
    +	Function `SmartGroupsClient.GetAllComplete` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int32, SmartGroupsSortByFields, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int64, SmartGroupsSortByFields, SortOrder)`
    +	Function `SmartGroupsClient.GetAllPreparer` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int32, SmartGroupsSortByFields, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int64, SmartGroupsSortByFields, SortOrder)`
    +	Function `SmartGroupsClient.GetAll` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int32, SmartGroupsSortByFields, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int64, SmartGroupsSortByFields, SortOrder)`
    +	Type of `AlertsSummaryGroup.SmartGroupsCount` has been changed from `*int32` to `*int64`
    +	Type of `AlertsSummaryGroup.Total` has been changed from `*int32` to `*int64`
    +	Type of `AlertsSummaryGroupItem.Count` has been changed from `*int32` to `*int64`
    +	Type of `SmartGroupAggregatedProperty.Count` has been changed from `*int32` to `*int64`
    +	Type of `SmartGroupProperties.AlertsCount` has been changed from `*int32` to `*int64`
    ️✔️azure-sdk-for-go - preview/alertsmanagement/mgmt/2018-05-05-preview/alertsmanagement - v61.2.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 219b2b3. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] notice
      cmderr	[automation_generate.sh] npm New minor version of npm available! 8.1.2 -> 8.4.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.4.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-alertsmanagement [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group AlertProcessingRulesOperations
      info	[Changelog]   - Model Condition has a new parameter field
      info	[Changelog]   - Model Essentials has a new parameter action_status
      info	[Changelog]   - Model Essentials has a new parameter description
      info	[Changelog]   - Model PatchObject has a new parameter enabled
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Model PatchObject no longer has parameter status
      info	[Changelog]   - Removed operation group ActionRulesOperations
      info	[Changelog]   - Removed operation group SmartDetectorAlertRulesOperations
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 219b2b3. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️alertsmanagement/mgmt/2019-03-01/alertsmanagement [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New function `SmartDetectorAlertRulesClient.PatchSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `SmartDetectorAlertRulesClient.PatchPreparer(context.Context, string, string, AlertRulePatchObject) (*http.Request, error)`
      info	[Changelog] - New function `SmartDetectorAlertRulesClient.Patch(context.Context, string, string, AlertRulePatchObject) (AlertRule, error)`
      info	[Changelog] - New function `AlertRulePatchObject.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `*AlertRulePatchObject.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `SmartDetectorAlertRulesClient.PatchResponder(*http.Response) (AlertRule, error)`
      info	[Changelog] - New struct `ActionStatus`
      info	[Changelog] - New struct `AlertRulePatchObject`
      info	[Changelog] - New struct `AlertRulePatchProperties`
      info	[Changelog] - New field `ActionStatus` in struct `Essentials`
      info	[Changelog] - New field `Description` in struct `Essentials`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 13 additive change(s).
    • ️✔️alertsmanagement/mgmt/2018-05-05/alertsmanagement [View full logs
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New struct `ActionStatus`
      info	[Changelog] - New field `Description` in struct `Essentials`
      info	[Changelog] - New field `ActionStatus` in struct `Essentials`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
    • ️✔️preview/alertsmanagement/mgmt/2019-06-01-preview/alertsmanagement [View full logs
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `SmartGroupsClient.GetAllComplete` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int32, SmartGroupsSortByFields, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int64, SmartGroupsSortByFields, SortOrder)`
      info	[Changelog] - Function `SmartGroupsClient.GetAll` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int32, SmartGroupsSortByFields, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int64, SmartGroupsSortByFields, SortOrder)`
      info	[Changelog] - Function `AlertsClient.GetAllPreparer` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int32, AlertsSortByFields, string, string, TimeRange, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int64, AlertsSortByFields, SortOrder, string, TimeRange, string)`
      info	[Changelog] - Function `SmartGroupsClient.GetAllPreparer` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int32, SmartGroupsSortByFields, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int64, SmartGroupsSortByFields, SortOrder)`
      info	[Changelog] - Function `AlertsClient.GetAll` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int32, AlertsSortByFields, string, string, TimeRange, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int64, AlertsSortByFields, SortOrder, string, TimeRange, string)`
      info	[Changelog] - Function `AlertsClient.GetAllComplete` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int32, AlertsSortByFields, string, string, TimeRange, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int64, AlertsSortByFields, SortOrder, string, TimeRange, string)`
      info	[Changelog] - Type of `AlertsSummaryGroupItem.Count` has been changed from `*int32` to `*int64`
      info	[Changelog] - Type of `SmartGroupAggregatedProperty.Count` has been changed from `*int32` to `*int64`
      info	[Changelog] - Type of `AlertsSummaryGroup.SmartGroupsCount` has been changed from `*int32` to `*int64`
      info	[Changelog] - Type of `AlertsSummaryGroup.Total` has been changed from `*int32` to `*int64`
      info	[Changelog] - Type of `SmartGroupProperties.AlertsCount` has been changed from `*int32` to `*int64`
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `Desc`
      info	[Changelog] - New const `Asc`
      info	[Changelog] - New function `PossibleSortOrderValues() []SortOrder`
      info	[Changelog] - New struct `ActionStatus`
      info	[Changelog] - New field `ActionStatus` in struct `Essentials`
      info	[Changelog] - New field `Description` in struct `Essentials`
      info	[Changelog]
      info	[Changelog] Total 10 breaking change(s), 6 additive change(s).
    • ️✔️preview/alertsmanagement/mgmt/2019-05-05-preview/alertsmanagement [View full logs
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `AlertsClient.GetAll` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int32, AlertsSortByFields, string, string, TimeRange, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int64, AlertsSortByFields, SortOrder, string, TimeRange, string)`
      info	[Changelog] - Function `AlertsClient.GetAllPreparer` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int32, AlertsSortByFields, string, string, TimeRange, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int64, AlertsSortByFields, SortOrder, string, TimeRange, string)`
      info	[Changelog] - Function `SmartGroupsClient.GetAll` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int32, SmartGroupsSortByFields, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int64, SmartGroupsSortByFields, SortOrder)`
      info	[Changelog] - Function `AlertsClient.GetAllComplete` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int32, AlertsSortByFields, string, string, TimeRange, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, string, string, *bool, *bool, *int64, AlertsSortByFields, SortOrder, string, TimeRange, string)`
      info	[Changelog] - Function `SmartGroupsClient.GetAllComplete` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int32, SmartGroupsSortByFields, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int64, SmartGroupsSortByFields, SortOrder)`
      info	[Changelog] - Function `SmartGroupsClient.GetAllPreparer` parameter(s) have been changed from `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int32, SmartGroupsSortByFields, string)` to `(context.Context, string, string, string, MonitorService, MonitorCondition, Severity, AlertState, TimeRange, *int64, SmartGroupsSortByFields, SortOrder)`
      info	[Changelog] - Type of `SmartGroupAggregatedProperty.Count` has been changed from `*int32` to `*int64`
      info	[Changelog] - Type of `SmartGroupProperties.AlertsCount` has been changed from `*int32` to `*int64`
      info	[Changelog] - Type of `AlertsSummaryGroupItem.Count` has been changed from `*int32` to `*int64`
      info	[Changelog] - Type of `AlertsSummaryGroup.Total` has been changed from `*int32` to `*int64`
      info	[Changelog] - Type of `AlertsSummaryGroup.SmartGroupsCount` has been changed from `*int32` to `*int64`
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `Desc`
      info	[Changelog] - New const `Asc`
      info	[Changelog] - New function `PossibleSortOrderValues() []SortOrder`
      info	[Changelog] - New struct `ActionStatus`
      info	[Changelog] - New field `ActionStatus` in struct `Essentials`
      info	[Changelog] - New field `Description` in struct `Essentials`
      info	[Changelog]
      info	[Changelog] Total 10 breaking change(s), 6 additive change(s).
    • ️✔️preview/alertsmanagement/mgmt/2018-05-05-preview/alertsmanagement [View full logs
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New struct `ActionStatus`
      info	[Changelog] - New field `Description` in struct `AlertProperties`
      info	[Changelog] - New field `ActionStatus` in struct `AlertProperties`
      info	[Changelog] - New field `AlertRule` in struct `AlertProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 219b2b3. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armalertsmanagement [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `AlertProperties.Context` has been changed from `map[string]interface{}` to `interface{}`
      info	[Changelog] - Type of `AlertProperties.EgressConfig` has been changed from `map[string]interface{}` to `interface{}`
      info	[Changelog] - Function `ErrorResponseBody.MarshalJSON` has been removed
      info	[Changelog] - Function `ErrorResponseBodyAutoGenerated.MarshalJSON` has been removed
      info	[Changelog] - Function `ErrorResponseBodyAutoGenerated2.MarshalJSON` has been removed
      info	[Changelog] - Struct `ErrorResponse` has been removed
      info	[Changelog] - Struct `ErrorResponseAutoGenerated` has been removed
      info	[Changelog] - Struct `ErrorResponseAutoGenerated2` has been removed
      info	[Changelog] - Struct `ErrorResponseBody` has been removed
      info	[Changelog] - Struct `ErrorResponseBodyAutoGenerated` has been removed
      info	[Changelog] - Struct `ErrorResponseBodyAutoGenerated2` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New struct `ActionStatus`
      info	[Changelog] - New field `Description` in struct `Essentials`
      info	[Changelog] - New field `ActionStatus` in struct `Essentials`
      info	[Changelog]
      info	[Changelog] Total 16 breaking change(s), 3 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 219b2b3. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️alertsmanagement [View full logs
    Posted by Swagger Pipeline | How to fix these errors?

    @inballeibovitch
    Copy link
    Contributor Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @openapi-workflow-bot
    Copy link

    Hi @inballeibovitch, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @inballeibovitch inballeibovitch marked this pull request as ready for review January 23, 2022 07:03
    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 24, 2022
    @chunyu3 chunyu3 self-requested a review January 30, 2022 00:41
    mstrisoline pushed a commit to mstrisoline/azure-rest-api-specs that referenced this pull request Feb 1, 2022
    …version preview/2019-03-01-preview (Azure#17366)
    
    * add description and actionStatus to alert properties
    
    * prettier fix
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Python CI-BreakingChange-Go-V2 CI-FixRequiredOnFailure FixS360
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants