-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.AlertsManagement to add version preview/2019-03-01-preview #17366
Conversation
Hi, @inballeibovitch Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isSuppressed Location: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L900 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isSuppressed Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L847 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isSuppressed Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L847 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isSuppressed Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L847 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isSuppressed Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json#L847 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isSuppressed Location: Microsoft.AlertsManagement/stable/2018-05-05/AlertsManagement.json#L1027 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isSuppressed Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L889 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isSuppressed Location: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L889 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
R2026 - AvoidAnonymousTypes |
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L852 |
R2026 - AvoidAnonymousTypes |
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L873 |
R2026 - AvoidAnonymousTypes |
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L852 |
R2026 - AvoidAnonymousTypes |
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L873 |
R3016 - DefinitionsPropertiesNamesCamelCase |
Property named: 'application Insights', for definition: 'alertsSummaryByMonitorService' must follow camelCase style. Example: 'application Insights'. Location: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L1403 |
R3016 - DefinitionsPropertiesNamesCamelCase |
Property named: 'log Analytics', for definition: 'alertsSummaryByMonitorService' must follow camelCase style. Example: 'log Analytics'. Location: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L1407 |
R3016 - DefinitionsPropertiesNamesCamelCase |
Property named: 'infrastructure Insights', for definition: 'alertsSummaryByMonitorService' must follow camelCase style. Example: 'infrastructure Insights'. Location: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L1423 |
R3016 - DefinitionsPropertiesNamesCamelCase |
Property named: 'activityLog Administrative', for definition: 'alertsSummaryByMonitorService' must follow camelCase style. Example: 'activityLog Administrative'. Location: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L1427 |
R3016 - DefinitionsPropertiesNamesCamelCase |
Property named: 'activityLog Security', for definition: 'alertsSummaryByMonitorService' must follow camelCase style. Example: 'activityLog Security'. Location: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L1431 |
R3016 - DefinitionsPropertiesNamesCamelCase |
Property named: 'activityLog Recommendation', for definition: 'alertsSummaryByMonitorService' must follow camelCase style. Example: 'activityLog Recommendation'. Location: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L1435 |
R3016 - DefinitionsPropertiesNamesCamelCase |
Property named: 'activityLog Policy', for definition: 'alertsSummaryByMonitorService' must follow camelCase style. Example: 'activityLog Policy'. Location: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L1439 |
R3016 - DefinitionsPropertiesNamesCamelCase |
Property named: 'activityLog Autoscale', for definition: 'alertsSummaryByMonitorService' must follow camelCase style. Example: 'activityLog Autoscale'. Location: Microsoft.AlertsManagement/preview/2018-05-05-preview/AlertsManagement.json#L1443 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/microsoft.alertsManagement/smartDetectorAlertRules' Location: Microsoft.AlertsManagement/stable/2019-06-01/SmartDetectorAlertRulesApi.json#L37 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.alertsManagement/smartDetectorAlertRules' Location: Microsoft.AlertsManagement/stable/2019-06-01/SmartDetectorAlertRulesApi.json#L79 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.alertsManagement/smartDetectorAlertRules/{alertRuleName}' Location: Microsoft.AlertsManagement/stable/2019-06-01/SmartDetectorAlertRulesApi.json#L124 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/microsoft.alertsManagement/smartDetectorAlertRules' Location: Microsoft.AlertsManagement/stable/2019-03-01/SmartDetectorAlertRulesApi.json#L37 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.alertsManagement/smartDetectorAlertRules' Location: Microsoft.AlertsManagement/stable/2019-03-01/SmartDetectorAlertRulesApi.json#L76 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.alertsManagement/smartDetectorAlertRules/{alertRuleName}' Location: Microsoft.AlertsManagement/stable/2019-03-01/SmartDetectorAlertRulesApi.json#L118 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/microsoft.alertsManagement/smartDetectorAlertRules' Location: Microsoft.AlertsManagement/stable/2021-04-01/SmartDetectorAlertRulesApi.json#L37 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.alertsManagement/smartDetectorAlertRules' Location: Microsoft.AlertsManagement/stable/2021-04-01/SmartDetectorAlertRulesApi.json#L79 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.alertsManagement/smartDetectorAlertRules/{alertRuleName}' Location: Microsoft.AlertsManagement/stable/2021-04-01/SmartDetectorAlertRulesApi.json#L124 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'microsoft.alertsManagement' doesn't match the namespace. Location: Microsoft.AlertsManagement/stable/2019-06-01/SmartDetectorAlertRulesApi.json#L37 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'microsoft.alertsManagement' doesn't match the namespace. Location: Microsoft.AlertsManagement/stable/2019-06-01/SmartDetectorAlertRulesApi.json#L79 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'microsoft.alertsManagement' doesn't match the namespace. Location: Microsoft.AlertsManagement/stable/2019-06-01/SmartDetectorAlertRulesApi.json#L124 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'microsoft.alertsManagement' doesn't match the namespace. Location: Microsoft.AlertsManagement/stable/2019-03-01/SmartDetectorAlertRulesApi.json#L37 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'microsoft.alertsManagement' doesn't match the namespace. Location: Microsoft.AlertsManagement/stable/2019-03-01/SmartDetectorAlertRulesApi.json#L76 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'microsoft.alertsManagement' doesn't match the namespace. Location: Microsoft.AlertsManagement/stable/2019-03-01/SmartDetectorAlertRulesApi.json#L118 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'microsoft.alertsManagement' doesn't match the namespace. Location: Microsoft.AlertsManagement/stable/2021-04-01/SmartDetectorAlertRulesApi.json#L37 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'microsoft.alertsManagement' doesn't match the namespace. Location: Microsoft.AlertsManagement/stable/2021-04-01/SmartDetectorAlertRulesApi.json#L79 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'microsoft.alertsManagement' doesn't match the namespace. Location: Microsoft.AlertsManagement/stable/2021-04-01/SmartDetectorAlertRulesApi.json#L124 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/alertsmanagement/resource-manager/readme.md tag: specification/alertsmanagement/resource-manager/readme.md#tag-package-2021-08 |
️️✔️
~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
- alertsmanagement/resource-manager/readme.md#package-2021-08
- alertsmanagement/resource-manager/readme.md#package-preview-2021-08
- alertsmanagement/resource-manager/readme.md#package-2021-04-only
- alertsmanagement/resource-manager/readme.md#package-2019-06-preview
- alertsmanagement/resource-manager/readme.md#package-2019-03
- alertsmanagement/resource-manager/readme.md#package-preview-2019-05
- alertsmanagement/resource-manager/readme.md#package-2018-05
- alertsmanagement/resource-manager/readme.md#package-2018-05-preview
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
Hi @inballeibovitch, Your PR has some issues. Please fix the CI sequentially by following the order of
|
NewApiVersionRequired reason: |
…version preview/2019-03-01-preview (Azure#17366) * add description and actionStatus to alert properties * prettier fix
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.