trafficmanager: adding the missing enum values for traffic manager endpoint #16472

tombuildsstuff · 2021-10-20T05:36:12Z

These are required in the API but undocumented - so pulling these out explicitly

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue ~~in s360~~
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…dpoint These are required in the API but undocumented - so pulling these out explicitly

openapi-workflow-bot · 2021-10-20T05:36:14Z

Hi, @tombuildsstuff Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2021-10-20T05:36:15Z

Swagger pipeline started successfully, please wait for status update in this comment.

openapi-workflow-bot · 2021-10-20T05:36:15Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-10-20T05:36:15Z

Swagger pipeline started successfully, please wait for status update in this comment.

ghost · 2021-10-20T05:36:17Z

Thank you for your contribution tombuildsstuff! We will review the pull request and get back to you soon.

tombuildsstuff · 2021-10-28T09:14:11Z

ping @msyyc

msyyc · 2021-10-29T02:06:11Z

/azp run

openapi-pipeline-app · 2021-10-29T02:06:14Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.9.1)
- current:stable/2018-08-01/trafficmanager.json compared with base:stable/2018-08-01/trafficmanager.json

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- trafficmanager/resource-manager/readme.md tag:package-2018-08
Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- trafficmanager/resource-manager/readme.md tag:package-2018-08

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L930
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1051
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1113
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1117
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1194
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1325
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1329
`❌` R4015 - NestedResourcesMustHaveListOperation	The nested resource 'HeatMapModel' does not have list operation, please add it. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1081
`❌` R4037 - MissingTypeObject	The schema 'DeleteOperationResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L953
`❌` R4037 - MissingTypeObject	The schema 'EndpointProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L964
`❌` R4037 - MissingTypeObject	The schema 'HeatMapModel' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1081
`❌` R4037 - MissingTypeObject	The schema 'UserMetricsModel' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1096
`❌` R4037 - MissingTypeObject	The schema 'QueryExperience' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1111
`❌` R4037 - MissingTypeObject	The schema 'TrafficFlow' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1133
`❌` R4037 - MissingTypeObject	The schema 'HeatMapProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1159
`❌` R4037 - MissingTypeObject	The schema 'HeatMapEndpoint' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1188
`❌` R4037 - MissingTypeObject	The schema 'Endpoint' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1201
`❌` R4037 - MissingTypeObject	The schema 'CheckTrafficManagerRelativeDnsNameAvailabilityParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1216
`❌` R4037 - MissingTypeObject	The schema 'DnsConfig' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1229
`❌` R4037 - MissingTypeObject	The schema 'MonitorConfig' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1248
`❌` R4037 - MissingTypeObject	The schema 'ProfileProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1341
`❌` R4037 - MissingTypeObject	The schema 'Profile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1427
`❌` R4037 - MissingTypeObject	The schema 'ProfileListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1442
`❌` R4037 - MissingTypeObject	The schema 'TrafficManagerNameAvailability' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1454
`❌` R4037 - MissingTypeObject	The schema 'Region' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1479
`❌` R4037 - MissingTypeObject	The schema 'GeographicHierarchyProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1499
`❌` R4037 - MissingTypeObject	The schema 'TrafficManagerGeographicHierarchy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1508
`❌` R4037 - MissingTypeObject	The schema 'UserMetricsProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1523
`❌` R4037 - MissingTypeObject	The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1532
`❌` R4037 - MissingTypeObject	The schema 'TrackedResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2018-08-01/trafficmanager.json#L1550

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

trafficmanager/resource-manager/readme.md#package-2018-08

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-10-29T02:06:14Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌[Staging] SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-trafficmanager - 1.0.0b1
❌azure-sdk-for-go - trafficmanager/mgmt/2018-08-01/trafficmanager - v59.0.0

+	Function `EndpointsClient.CreateOrUpdatePreparer` parameter(s) have been changed from `(context.Context, string, string, string, string, Endpoint)` to `(context.Context, string, string, EndpointType, string, Endpoint)`
+	Function `EndpointsClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, string, Endpoint)` to `(context.Context, string, string, EndpointType, string, Endpoint)`
+	Function `EndpointsClient.DeletePreparer` parameter(s) have been changed from `(context.Context, string, string, string, string)` to `(context.Context, string, string, EndpointType, string)`
+	Function `EndpointsClient.Delete` parameter(s) have been changed from `(context.Context, string, string, string, string)` to `(context.Context, string, string, EndpointType, string)`
+	Function `EndpointsClient.GetPreparer` parameter(s) have been changed from `(context.Context, string, string, string, string)` to `(context.Context, string, string, EndpointType, string)`
+	Function `EndpointsClient.Get` parameter(s) have been changed from `(context.Context, string, string, string, string)` to `(context.Context, string, string, EndpointType, string)`
+	Function `EndpointsClient.UpdatePreparer` parameter(s) have been changed from `(context.Context, string, string, string, string, Endpoint)` to `(context.Context, string, string, EndpointType, string, Endpoint)`
+	Function `EndpointsClient.Update` parameter(s) have been changed from `(context.Context, string, string, string, string, Endpoint)` to `(context.Context, string, string, EndpointType, string, Endpoint)`

️✔️azure-sdk-for-go - trafficmanager/mgmt/2018-04-01/trafficmanager - v59.0.0
️✔️azure-sdk-for-go - trafficmanager/mgmt/2018-03-01/trafficmanager - v59.0.0
️✔️azure-sdk-for-go - trafficmanager/mgmt/2017-05-01/trafficmanager - v59.0.0
️✔️azure-sdk-for-go - trafficmanager/mgmt/2017-03-01/trafficmanager - v59.0.0
️✔️azure-sdk-for-go - trafficmanager/mgmt/2015-11-01/trafficmanager - v59.0.0
️✔️azure-sdk-for-go - preview/trafficmanager/mgmt/2018-02-01-preview/trafficmanager - v59.0.0
️✔️azure-sdk-for-go - preview/trafficmanager/mgmt/2017-09-01-preview/trafficmanager - v59.0.0

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from d72b193. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armtrafficmanager [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*EndpointsClient.Get` parameter(s) have been changed from `(context.Context, string, string, string, string, *EndpointsClientGetOptions)` to `(context.Context, string, string, EndpointType, string, *EndpointsClientGetOptions)`
info	[Changelog] - Function `*EndpointsClient.Update` parameter(s) have been changed from `(context.Context, string, string, string, string, Endpoint, *EndpointsClientUpdateOptions)` to `(context.Context, string, string, EndpointType, string, Endpoint, *EndpointsClientUpdateOptions)`
info	[Changelog] - Function `*EndpointsClient.Delete` parameter(s) have been changed from `(context.Context, string, string, string, string, *EndpointsClientDeleteOptions)` to `(context.Context, string, string, EndpointType, string, *EndpointsClientDeleteOptions)`
info	[Changelog] - Function `*EndpointsClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, string, Endpoint, *EndpointsClientCreateOrUpdateOptions)` to `(context.Context, string, string, EndpointType, string, Endpoint, *EndpointsClientCreateOrUpdateOptions)`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `EndpointTypeExternalEndpoints`
info	[Changelog] - New const `EndpointTypeNestedEndpoints`
info	[Changelog] - New const `EndpointTypeAzureEndpoints`
info	[Changelog] - New function `PossibleEndpointTypeValues() []EndpointType`
info	[Changelog] - New function `EndpointType.ToPtr() *EndpointType`
info	[Changelog]
info	[Changelog] Total 4 breaking change(s), 5 additive change(s).

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from d72b193. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/trafficmanager/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.Management.TrafficManager [View full logs] [Release SDK Changes]

cmdout	[msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/ScenarioTests/EndpointScenarioTests.cs(49,21): error CS1503: Argument 4: cannot convert from 'string' to 'Microsoft.Azure.Management.TrafficManager.Models.EndpointType' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/Microsoft.Azure.Management.TrafficManager.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/ScenarioTests/EndpointScenarioTests.cs(60,21): error CS1503: Argument 4: cannot convert from 'string' to 'Microsoft.Azure.Management.TrafficManager.Models.EndpointType' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/Microsoft.Azure.Management.TrafficManager.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/Helpers/TrafficManagerHelper.cs(100,51): error CS7036: There is no argument given that corresponds to the required formal parameter 'apiVersion' of 'ResourcesOperationsExtensions.CreateOrUpdate(IResourcesOperations, string, string, string, string, string, string, GenericResource)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/Microsoft.Azure.Management.TrafficManager.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/Helpers/TrafficManagerHelper.cs(204,48): error CS7036: There is no argument given that corresponds to the required formal parameter 'apiVersion' of 'ResourcesOperationsExtensions.CreateOrUpdate(IResourcesOperations, string, string, string, string, string, string, GenericResource)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/Microsoft.Azure.Management.TrafficManager.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/Helpers/TrafficManagerHelper.cs(235,48): error CS7036: There is no argument given that corresponds to the required formal parameter 'apiVersion' of 'ResourcesOperationsExtensions.CreateOrUpdate(IResourcesOperations, string, string, string, string, string, string, GenericResource)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/Microsoft.Azure.Management.TrafficManager.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/Helpers/TrafficManagerHelper.cs(274,48): error CS7036: There is no argument given that corresponds to the required formal parameter 'apiVersion' of 'ResourcesOperationsExtensions.CreateOrUpdate(IResourcesOperations, string, string, string, string, string, string, GenericResource)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/Microsoft.Azure.Management.TrafficManager.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/ScenarioTests/EndpointScenarioTests.cs(49,21): error CS1503: Argument 4: cannot convert from 'string' to 'Microsoft.Azure.Management.TrafficManager.Models.EndpointType' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/Microsoft.Azure.Management.TrafficManager.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/ScenarioTests/EndpointScenarioTests.cs(60,21): error CS1503: Argument 4: cannot convert from 'string' to 'Microsoft.Azure.Management.TrafficManager.Models.EndpointType' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/Microsoft.Azure.Management.TrafficManager.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/Helpers/TrafficManagerHelper.cs(100,51): error CS7036: There is no argument given that corresponds to the required formal parameter 'apiVersion' of 'ResourcesOperationsExtensions.CreateOrUpdate(IResourcesOperations, string, string, string, string, string, string, GenericResource)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/Microsoft.Azure.Management.TrafficManager.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/Helpers/TrafficManagerHelper.cs(204,48): error CS7036: There is no argument given that corresponds to the required formal parameter 'apiVersion' of 'ResourcesOperationsExtensions.CreateOrUpdate(IResourcesOperations, string, string, string, string, string, string, GenericResource)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/Microsoft.Azure.Management.TrafficManager.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/Helpers/TrafficManagerHelper.cs(235,48): error CS7036: There is no argument given that corresponds to the required formal parameter 'apiVersion' of 'ResourcesOperationsExtensions.CreateOrUpdate(IResourcesOperations, string, string, string, string, string, string, GenericResource)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/Microsoft.Azure.Management.TrafficManager.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/Helpers/TrafficManagerHelper.cs(274,48): error CS7036: There is no argument given that corresponds to the required formal parameter 'apiVersion' of 'ResourcesOperationsExtensions.CreateOrUpdate(IResourcesOperations, string, string, string, string, string, string, GenericResource)' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/tests/Microsoft.Azure.Management.TrafficManager.Tests.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from d72b193. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.3.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.3.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-trafficmanager [View full logs] [Release SDK Changes]
- azure-mgmt-trafficmanager-1.0.0b1.zip
- azure_mgmt_trafficmanager-1.0.0b1-py3-none-any.whl
```
info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added model EndpointType
```

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from d72b193. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️trafficmanager/mgmt/2018-08-01/trafficmanager [View full logs] [Release SDK Changes]

Only show 15 items here, please refer to log for details.

info	[Changelog] - Function `EndpointsClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, string, Endpoint)` to `(context.Context, string, string, EndpointType, string, Endpoint)`
info	[Changelog] - Function `EndpointsClient.Get` parameter(s) have been changed from `(context.Context, string, string, string, string)` to `(context.Context, string, string, EndpointType, string)`
info	[Changelog] - Function `EndpointsClient.GetPreparer` parameter(s) have been changed from `(context.Context, string, string, string, string)` to `(context.Context, string, string, EndpointType, string)`
info	[Changelog] - Function `EndpointsClient.DeletePreparer` parameter(s) have been changed from `(context.Context, string, string, string, string)` to `(context.Context, string, string, EndpointType, string)`
info	[Changelog] - Function `EndpointsClient.Delete` parameter(s) have been changed from `(context.Context, string, string, string, string)` to `(context.Context, string, string, EndpointType, string)`
info	[Changelog] - Function `EndpointsClient.Update` parameter(s) have been changed from `(context.Context, string, string, string, string, Endpoint)` to `(context.Context, string, string, EndpointType, string, Endpoint)`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `EndpointTypeAzureEndpoints`
info	[Changelog] - New const `EndpointTypeExternalEndpoints`
info	[Changelog] - New const `EndpointTypeNestedEndpoints`
info	[Changelog] - New function `PossibleEndpointTypeValues() []EndpointType`
info	[Changelog]
info	[Changelog] Total 8 breaking change(s), 4 additive change(s).

️✔️trafficmanager/mgmt/2018-04-01/trafficmanager [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️trafficmanager/mgmt/2018-03-01/trafficmanager [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️trafficmanager/mgmt/2017-05-01/trafficmanager [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️trafficmanager/mgmt/2017-03-01/trafficmanager [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️trafficmanager/mgmt/2015-11-01/trafficmanager [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/trafficmanager/mgmt/2018-02-01-preview/trafficmanager [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/trafficmanager/mgmt/2017-09-01-preview/trafficmanager [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from d72b193. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] WARN deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh]  deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️track2_@azure/arm-trafficmanager [View full logs] [Release SDK Changes]
- azure-arm-trafficmanager-6.0.0.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from d72b193. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
warn	Skip detect changed packages

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2021-10-29T02:06:22Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-workflow-bot · 2021-10-29T02:08:09Z

Hi @tombuildsstuff, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

msyyc · 2021-10-29T02:11:53Z

Hi @tombuildsstuff Please follow advice of bot to fix CI. All Required but failed CI need to be fixed before merge.

msyyc · 2021-11-09T03:07:01Z

Hi @ArcturusZhang Please help confirm breaking change of Go.

tombuildsstuff · 2021-11-22T23:18:04Z

ping @ArcturusZhang - any update here?

ghost · 2021-12-12T16:02:13Z

Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

tombuildsstuff · 2021-12-13T01:21:52Z

ping @ArcturusZhang - any update here?

ghost · 2022-01-02T16:03:14Z

Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

tombuildsstuff · 2022-01-02T18:53:24Z

... it's waiting for the relevant service team to review it?

msyyc · 2022-01-14T06:34:29Z

Hi, @ArcturusZhang Please review Go breaking change.

…dpoint (Azure#16472) * trafficmanager: adding the missing enum values for traffic manager endpoint These are required in the API but undocumented - so pulling these out explicitly * trafficmanager: casing to TitleCase

trafficmanager: adding the missing enum values for traffic manager en…

8e763d7

…dpoint These are required in the API but undocumented - so pulling these out explicitly

tombuildsstuff requested a review from allencal as a code owner October 20, 2021 05:36

openapi-assignment-bot bot assigned msyyc Oct 20, 2021

ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Oct 20, 2021

tombuildsstuff mentioned this pull request Oct 20, 2021

Resource ID's: Constant Segments should be considered when naming hashicorp/pandora#366

Closed

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Oct 29, 2021

openapi-sdkautomation bot mentioned this pull request Oct 29, 2021

[AutoPR @azure/arm-trafficmanager] trafficmanager: adding the missing enum values for traffic manager endpoint AzureSDKAutomation/azure-sdk-for-js#6523

Draft

openapi-pipeline-app bot added the CI-BreakingChange-Go label Oct 29, 2021

trafficmanager: casing to TitleCase

bfd97eb

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Oct 29, 2021

ghost added the no-recent-activity label Dec 12, 2021

ghost removed the no-recent-activity label Dec 13, 2021

ghost added the no-recent-activity label Jan 2, 2022

ghost removed the no-recent-activity label Jan 2, 2022

msyyc approved these changes Jan 14, 2022

View reviewed changes

msyyc merged commit d72b193 into Azure:main Jan 14, 2022

openapi-sdkautomation bot mentioned this pull request Jan 14, 2022

[ReleasePR armtrafficmanager] add x-ms-enum to trafficmanager Azure/azure-sdk-for-go#16581

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go-V2 label Jan 14, 2022

This was referenced Jan 14, 2022

[ReleasePR track2_azure-mgmt-trafficmanager] add x-ms-enum to trafficmanager Azure/azure-sdk-for-python#22126

Closed

[ReleasePR trafficmanager/mgmt/2018-08-01/trafficmanager] add x-ms-enum to trafficmanager Azure/azure-sdk-for-go#16590

Closed

openapi-pipeline-app bot removed the CI-BreakingChange-Go label Jan 14, 2022

tombuildsstuff deleted the b/traffic-manager-endpoint-enum branch January 14, 2022 07:37

tombuildsstuff mentioned this pull request May 18, 2022

Terraform import of TME nested endpoints hashicorp/terraform-provider-azurerm#16588

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

trafficmanager: adding the missing enum values for traffic manager endpoint #16472

trafficmanager: adding the missing enum values for traffic manager endpoint #16472

tombuildsstuff commented Oct 20, 2021

openapi-workflow-bot bot commented Oct 20, 2021

openapi-pipeline-app bot commented Oct 20, 2021

openapi-workflow-bot bot commented Oct 20, 2021

openapi-pipeline-app bot commented Oct 20, 2021

ghost commented Oct 20, 2021

tombuildsstuff commented Oct 28, 2021

msyyc commented Oct 29, 2021

openapi-pipeline-app bot commented Oct 29, 2021 •

edited

Loading

openapi-pipeline-app bot commented Oct 29, 2021 •

edited

Loading

Breaking Changes Tracking

azure-pipelines bot commented Oct 29, 2021

openapi-workflow-bot bot commented Oct 29, 2021

msyyc commented Oct 29, 2021

msyyc commented Nov 9, 2021

tombuildsstuff commented Nov 22, 2021

ghost commented Dec 12, 2021

tombuildsstuff commented Dec 13, 2021

ghost commented Jan 2, 2022

tombuildsstuff commented Jan 2, 2022

msyyc commented Jan 14, 2022

trafficmanager: adding the missing enum values for traffic manager endpoint #16472

trafficmanager: adding the missing enum values for traffic manager endpoint #16472

Conversation

tombuildsstuff commented Oct 20, 2021

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Oct 20, 2021

openapi-pipeline-app bot commented Oct 20, 2021

openapi-workflow-bot bot commented Oct 20, 2021

openapi-pipeline-app bot commented Oct 20, 2021

ghost commented Oct 20, 2021

tombuildsstuff commented Oct 28, 2021

msyyc commented Oct 29, 2021

openapi-pipeline-app bot commented Oct 29, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Oct 29, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

azure-pipelines bot commented Oct 29, 2021

openapi-workflow-bot bot commented Oct 29, 2021

msyyc commented Oct 29, 2021

msyyc commented Nov 9, 2021

tombuildsstuff commented Nov 22, 2021

ghost commented Dec 12, 2021

tombuildsstuff commented Dec 13, 2021

ghost commented Jan 2, 2022

tombuildsstuff commented Jan 2, 2022

msyyc commented Jan 14, 2022

openapi-pipeline-app bot commented Oct 29, 2021 •

edited

Loading

openapi-pipeline-app bot commented Oct 29, 2021 •

edited

Loading