From 341d6197b957edd570db8e5cfead7de90f1bd304 Mon Sep 17 00:00:00 2001 From: Jiacheng Liu Date: Wed, 29 Sep 2021 21:07:11 -0700 Subject: [PATCH 1/2] Remove unused error response and add missing permissions --- .../examples/purgeDeletedVault.json | 9 --------- .../examples/updateAccessPoliciesAdd.json | 9 --------- .../preview/2021-04-01-preview/keyvault.json | 18 ++++-------------- 3 files changed, 4 insertions(+), 32 deletions(-) diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/purgeDeletedVault.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/purgeDeletedVault.json index 7141f4f20424..d07fc8577726 100644 --- a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/purgeDeletedVault.json +++ b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/purgeDeletedVault.json @@ -11,15 +11,6 @@ }, "202": { "headers": {} - }, - "404": { - "headers": {}, - "body": { - "error": { - "code": "", - "message": "" - } - } } } } diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/updateAccessPoliciesAdd.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/updateAccessPoliciesAdd.json index 97c20be93866..d3c1bb713bca 100644 --- a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/updateAccessPoliciesAdd.json +++ b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/updateAccessPoliciesAdd.json @@ -77,15 +77,6 @@ ] } } - }, - "404": { - "headers": {}, - "body": { - "error": { - "code": "", - "message": "" - } - } } } } diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/keyvault.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/keyvault.json index 30e1f92f72a5..743b15e61c49 100644 --- a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/keyvault.json +++ b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/keyvault.json @@ -332,13 +332,6 @@ "$ref": "#/definitions/VaultAccessPolicyParameters" } }, - "404": { - "description": "The specified resource does not exist.", - "schema": { - "$ref": "common.json#/definitions/CloudError" - }, - "x-ms-error-response": true - }, "default": { "description": "Error response describing why the operation failed.", "schema": { @@ -608,13 +601,6 @@ "202": { "description": "Vault is being purged." }, - "404": { - "description": "The specified resource does not exist.", - "schema": { - "$ref": "common.json#/definitions/CloudError" - }, - "x-ms-error-response": true - }, "default": { "description": "Error response describing why the operation failed.", "schema": { @@ -1100,6 +1086,7 @@ "items": { "type": "string", "enum": [ + "all", "encrypt", "decrypt", "wrapKey", @@ -1130,6 +1117,7 @@ "items": { "type": "string", "enum": [ + "all", "get", "list", "set", @@ -1151,6 +1139,7 @@ "items": { "type": "string", "enum": [ + "all", "get", "list", "delete", @@ -1180,6 +1169,7 @@ "items": { "type": "string", "enum": [ + "all", "get", "list", "delete", From 282bdfdb287eb9f40288468502227c282ddc30f6 Mon Sep 17 00:00:00 2001 From: Jiacheng Liu Date: Thu, 30 Sep 2021 04:57:44 -0700 Subject: [PATCH 2/2] Add 404 back --- .../examples/purgeDeletedVault.json | 9 +++++++++ .../examples/updateAccessPoliciesAdd.json | 9 +++++++++ .../preview/2021-04-01-preview/keyvault.json | 14 ++++++++++++++ 3 files changed, 32 insertions(+) diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/purgeDeletedVault.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/purgeDeletedVault.json index d07fc8577726..7141f4f20424 100644 --- a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/purgeDeletedVault.json +++ b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/purgeDeletedVault.json @@ -11,6 +11,15 @@ }, "202": { "headers": {} + }, + "404": { + "headers": {}, + "body": { + "error": { + "code": "", + "message": "" + } + } } } } diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/updateAccessPoliciesAdd.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/updateAccessPoliciesAdd.json index d3c1bb713bca..97c20be93866 100644 --- a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/updateAccessPoliciesAdd.json +++ b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/examples/updateAccessPoliciesAdd.json @@ -77,6 +77,15 @@ ] } } + }, + "404": { + "headers": {}, + "body": { + "error": { + "code": "", + "message": "" + } + } } } } diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/keyvault.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/keyvault.json index 743b15e61c49..3c86eb258b40 100644 --- a/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/keyvault.json +++ b/specification/keyvault/resource-manager/Microsoft.KeyVault/preview/2021-04-01-preview/keyvault.json @@ -332,6 +332,13 @@ "$ref": "#/definitions/VaultAccessPolicyParameters" } }, + "404": { + "description": "The specified resource does not exist.", + "schema": { + "$ref": "common.json#/definitions/CloudError" + }, + "x-ms-error-response": true + }, "default": { "description": "Error response describing why the operation failed.", "schema": { @@ -601,6 +608,13 @@ "202": { "description": "Vault is being purged." }, + "404": { + "description": "The specified resource does not exist.", + "schema": { + "$ref": "common.json#/definitions/CloudError" + }, + "x-ms-error-response": true + }, "default": { "description": "Error response describing why the operation failed.", "schema": {