Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Public private branch 'dev-alertsmanagement-Microsoft.AlertsManagement-2021-02-01-preview' #15899

Conversation

inballeibovitch
Copy link
Contributor

@inballeibovitch inballeibovitch commented Sep 2, 2021

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

inballeibovitch and others added 30 commits February 10, 2021 12:10
…w/2019-05-05-preview to version 2021-02-01-preview
…-01-preview' of https://github.com/inballeibovitch/azure-rest-api-specs-pr into dev-alertsmanagement-Microsoft.AlertsManagement-2021-02-01-preview
…s-pr into dev-alertsmanagement-Microsoft.AlertsManagement-2021-02-01-preview
@inballeibovitch
Copy link
Contributor Author

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/2952

@openapi-workflow-bot
Copy link

Hi, @inballeibovitch Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 2, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 2 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
    Location: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L717
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
    Location: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L797


    The following errors/warnings exist before current PR submission:

    Rule Message
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L42
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.AlertsManagement/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L30
    R4037 - MissingTypeObject The schema 'errorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L392
    R4037 - MissingTypeObject The schema 'errorResponseBody' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L400
    R4037 - MissingTypeObject The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L424
    R4037 - MissingTypeObject The schema 'ManagedResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L445
    R4037 - MissingTypeObject The schema 'ActionRule' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L669
    R4037 - MissingTypeObject The schema 'ActionRuleProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L687
    R4037 - MissingTypeObject The schema 'ActionRulesList' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L778
    R4037 - MissingTypeObject The schema 'PatchProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L794
    R4037 - MissingTypeObject The schema 'PatchObject' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L803
    R4037 - MissingTypeObject The schema 'operation' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L57
    R4037 - MissingTypeObject The schema 'operationsList' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L88
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L677
    ⚠️ R3027 - TrackedResourceListByResourceGroup The tracked resource, 'ManagedResource', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
    Location: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L445
    ⚠️ R3028 - TrackedResourceListBySubscription The tracked resource, 'ManagedResource', must have a list by subscriptions operation.
    Location: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L445
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/alertsmanagement/resource-manager/readme.md
    tag: specification/alertsmanagement/resource-manager/readme.md#tag-package-2019-06-preview
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 35 Errors, 69 Warnings failed [Detail]
    The following breaking changes are detected by comparison with the latest stable version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.AlertsManagement/alertsMetaData' removed or restructured?
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L55:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.AlertsManagement/alerts' removed or restructured?
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L91:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.AlertsManagement/alerts/{alertId}' removed or restructured?
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L181:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.AlertsManagement/alerts/{alertId}/changestate' removed or restructured?
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L221:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.AlertsManagement/alerts/{alertId}/history' removed or restructured?
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L260:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.AlertsManagement/alertsSummary' removed or restructured?
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L296:5
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'MonitorServiceList' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L56:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L725:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'scope' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L108:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L366:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'subscriptionId' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L108:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L366:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'api-version' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L108:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L366:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'alertId' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L108:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L366:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'targetResourceGroup' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L108:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L366:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'targetResource' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L108:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L366:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'targetResourceType' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L108:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L366:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'monitorService' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L108:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L366:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'severity' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L108:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L366:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'smartGroupIdFilter' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L108:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L366:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'smartGroupId' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L108:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L366:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'newState' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L108:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L366:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'alertState' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L108:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L366:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'smartGroupState' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L108:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L366:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'monitorCondition' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L108:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L366:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'alertRule' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L108:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L366:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'timeRange' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L108:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L366:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'customTimeRange' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L108:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L366:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'includeContext' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L108:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L366:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'includeEgressConfig' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L108:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L366:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'includeSmartGroupsCount' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L108:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L366:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'pageCount' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L108:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L366:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'alertsSortBy' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertsManagement.json#L108:3
    Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L366:3


    The following breaking changes are detected by comparison with latest preview version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Scope' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L391:3
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L535:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Suppression' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L391:3
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L535:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ActionGroup' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L391:3
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L535:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Diagnostics' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L391:3
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L535:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'targetResourceGroup' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L359:3
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L392:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'targetResource' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L359:3
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L392:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'targetResourceType' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L359:3
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L392:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'monitorService' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L359:3
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L392:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'severity' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L359:3
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L392:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'description' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L359:3
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L392:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'alertRuleId' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L359:3
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L392:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'actionGroup' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L359:3
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L392:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'actionRuleName' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L359:3
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L392:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'impactedScope' removed or renamed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L359:3
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L392:3
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '201'.
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L208:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '204'.
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L279:11
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2019-05-05-preview' from the old version.
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L35:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2019-05-05-preview' from the old version.
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L108:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2019-05-05-preview' from the old version.
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L184:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2019-05-05-preview' from the old version.
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L232:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2019-05-05-preview' from the old version.
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L289:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2019-05-05-preview' from the old version.
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L337:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) '2019-05-05-preview' from the old version.
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L376:5
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L409:5
    ⚠️ 1026 - TypeChanged The new version has a different type 'array' than the previous one 'object'.
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L698:9
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L785:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L461:9
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L605:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L461:9
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L605:9
    ⚠️ 1026 - TypeChanged The new version has a different type 'array' than the previous one 'object'.
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L528:5
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L669:5
    ⚠️ 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L677:9
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L768:9
    ⚠️ 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L687:5
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L774:5
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'scope' renamed or removed?
    New: Microsoft.AlertsManagement/preview/2021-08-08-preview/ActionRules.json#L693:7
    Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L780:7
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"alertsmanagement/resource-manager/readme.md",
    "tag":"package-preview-2021-08",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"alertsmanagement/resource-manager/readme.md",
    "tag":"package-preview-2021-08",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"alertsmanagement/resource-manager/readme.md",
    "tag":"package-preview-2021-08",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 2, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-alertsmanagement - 1.0.0
    ️✔️azure-sdk-for-go - alertsmanagement/mgmt/2019-03-01/alertsmanagement - v57.1.0
    ️✔️azure-sdk-for-go - alertsmanagement/mgmt/2018-05-05/alertsmanagement - v57.1.0
    ️✔️azure-sdk-for-go - preview/alertsmanagement/mgmt/2019-06-01-preview/alertsmanagement - v57.1.0
    ️✔️azure-sdk-for-go - preview/alertsmanagement/mgmt/2019-05-05-preview/alertsmanagement - v57.1.0
    ️✔️azure-sdk-for-go - preview/alertsmanagement/mgmt/2018-05-05-preview/alertsmanagement - v57.1.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 55d29f1. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️alertsmanagement/mgmt/2019-03-01/alertsmanagement [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New function `SmartDetectorAlertRulesClient.PatchResponder(*http.Response) (AlertRule, error)`
      info	[Changelog] - New function `SmartDetectorAlertRulesClient.PatchSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `AlertRulePatchObject.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `SmartDetectorAlertRulesClient.Patch(context.Context, string, string, AlertRulePatchObject) (AlertRule, error)`
      info	[Changelog] - New function `*AlertRulePatchObject.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `SmartDetectorAlertRulesClient.PatchPreparer(context.Context, string, string, AlertRulePatchObject) (*http.Request, error)`
      info	[Changelog] - New struct `AlertRulePatchObject`
      info	[Changelog] - New struct `AlertRulePatchProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 10 additive change(s).
      info	[Changelog]
    • ️✔️alertsmanagement/mgmt/2018-05-05/alertsmanagement [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/alertsmanagement/mgmt/2019-06-01-preview/alertsmanagement [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/alertsmanagement/mgmt/2019-05-05-preview/alertsmanagement [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/alertsmanagement/mgmt/2018-05-05-preview/alertsmanagement [View full logs
      info	[Changelog] No exported changes
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 55d29f1. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      cmderr	[generateScript.sh] (node:2387) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
      cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
      cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
      cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
      cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
      cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
      cmderr	[generateScript.sh] (node:2387) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
      cmderr	[generateScript.sh] (node:2387) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
    • ️✔️alertsmanagement [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi, @inballeibovitch your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @jianyexi jianyexi merged commit 55d29f1 into main Sep 13, 2021
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Sep 13, 2021
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    ….AlertsManagement-2021-02-01-preview' (Azure#15899)
    
    * Adds base for updating Microsoft.AlertsManagement from version preview/2019-05-05-preview to version 2021-02-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * update action rule schema to new api
    
    * fix linter issues
    
    * add alertsmanagement.json
    
    * fix api version
    
    * fix description in targetResource
    
    * match description
    
    * match severity description
    
    * use systemdata type
    
    * run prettier-fix
    
    * change alertsmanagement to latest version
    
    * add integer format
    
    * add x-ms-discriminator-value
    
    * remove summary
    
    * make action polymorphic
    
    * update readme
    
    * prettier fix
    
    * remove space
    
    * add examples
    
    * prettier fix
    
    * fix validation errors
    
    * fix validation errors
    
    * change file name
    
    * update monitor service names
    
    * fix PR comments
    
    * fix description
    
    * change actions to array
    
    * fix prettify issue
    
    * fix lintDiff errors
    
    * rename schedulingConfig to schedule
    
    * fix response codes for put and delete
    
    * fix prettier
    
    * remove query params
    
    * add enabled default value
    
    * rename api version and add severity to conditions
    
    * fix condition enum and remove Z from time in examples
    
    * update conditions, schedule pattern and descriptions
    @JackTn JackTn deleted the published/inballeibovitch/azure-rest-api-specs-pr/dev-alertsmanagement-Microsoft.AlertsManagement-2021-02-01-preview branch June 16, 2022 00:51
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants