-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Public private branch 'dev-alertsmanagement-Microsoft.AlertsManagement-2021-02-01-preview' #15899
Conversation
…w/2019-05-05-preview to version 2021-02-01-preview
…ement-2021-02-01-preview
…-01-preview' of https://github.com/inballeibovitch/azure-rest-api-specs-pr into dev-alertsmanagement-Microsoft.AlertsManagement-2021-02-01-preview
…s-pr into dev-alertsmanagement-Microsoft.AlertsManagement-2021-02-01-preview
The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/2952 |
Hi, @inballeibovitch Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
Hi, @inballeibovitch your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
…ev-alertsmanagement-Microsoft.AlertsManagement-2021-02-01-preview' (#1894) Create to sync Azure/azure-rest-api-specs#15899 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/alertsmanagement?expand=1)
….AlertsManagement-2021-02-01-preview' (Azure#15899) * Adds base for updating Microsoft.AlertsManagement from version preview/2019-05-05-preview to version 2021-02-01-preview * Updates readme * Updates API version in new specs and examples * update action rule schema to new api * fix linter issues * add alertsmanagement.json * fix api version * fix description in targetResource * match description * match severity description * use systemdata type * run prettier-fix * change alertsmanagement to latest version * add integer format * add x-ms-discriminator-value * remove summary * make action polymorphic * update readme * prettier fix * remove space * add examples * prettier fix * fix validation errors * fix validation errors * change file name * update monitor service names * fix PR comments * fix description * change actions to array * fix prettify issue * fix lintDiff errors * rename schedulingConfig to schedule * fix response codes for put and delete * fix prettier * remove query params * add enabled default value * rename api version and add severity to conditions * fix condition enum and remove Z from time in examples * update conditions, schedule pattern and descriptions
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.