-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ResourceHealth - Swagger - AVAILABILITYSTATUSES API - 2020-05-01 Stable & Preview API versions #15502
Conversation
Stable - 2020-05-01 API version AvailabilityStatusesAPI
Preview - 2020-05-01 API version AvailabilityStatusesAPI
Hi, @srrudray Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
This comment has been minimized.
This comment has been minimized.
Swagger Generation Artifacts
|
Hi @srrudray, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Hi, @srrudray your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
fixing the readme file
adding stable 202-05-01 API version
fixed the PR checks for ResourceHealth.json Stable 2020-05-01 API version
deleting .bak file
fixed preview resourcehealth.json
fixing the typo occurredTime
fixing typo occurredTime
fix PR errors
fix PR checks
Creating the PR to resolve the S360 - Swagger KPI Completeness Short description: I'm not sure, how to resolve some of the PR checks that are saying that why other API's are missing this API version |
Hi @srrudray, You can refer to https://aka.ms/ci-fix (state in first comments)to fix the validation error. if still has issue to fix. you can refer to #15502 (comment) to get further help. And seems you are adding 2 new version,(stable & preview with same date part 2020-05-01) can we know what different for them. and for our easy to review. best practice is (it can also be found in first comment) of this PR: |
This 2 versions are already existing in our ARM Manifest and are currently in use |
Please complete the checklist for ARM API Review to continue. Specifically following is required Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board. |
fixing semantic validation
Azure Pipelines successfully started running 1 pipeline(s). |
Signed off from ARM side |
reverting back occured typo
fix typo
fix typo
fixed typo
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit (including refactoring) and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.